[LON-CAPA-cvs] cvs: loncom /interface portfolio.pm

bisitz bisitz@source.lon-capa.org
Fri, 19 Feb 2010 10:20:31 -0000


bisitz		Fri Feb 19 10:20:31 2010 EDT

  Modified files:              
    /loncom/interface	portfolio.pm 
  Log:
  - Localization:
      - Optimized &mt() call to allow proper translation
      - Added missing mt() call to save button
      - Consistent and short button names: just "Save"
  - Wording: Re-use $type for informative text
  - Code style: Added some line breaks
  
  
Index: loncom/interface/portfolio.pm
diff -u loncom/interface/portfolio.pm:1.219 loncom/interface/portfolio.pm:1.220
--- loncom/interface/portfolio.pm:1.219	Tue Feb  2 01:51:49 2010
+++ loncom/interface/portfolio.pm	Fri Feb 19 10:20:31 2010
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # portfolio browser
 #
-# $Id: portfolio.pm,v 1.219 2010/02/02 01:51:49 raeburn Exp $
+# $Id: portfolio.pm,v 1.220 2010/02/19 10:20:31 bisitz Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -1778,8 +1778,23 @@
 
 </script>
 END_SCRIPT
-    $r->print(&mt('Select roles, course status, section(s) and group(s) for users who will be able to access the portfolio file.'));
-    $r->print('<form name="rolepicker" action="/adm/portfolio" method="post"><table><tr><th>'.&mt('Roles').'</th><th>'.&mt('[_1] status',$type).'</th><th>'.&mt('Sections').'</th><th>'.&mt('Groups').'</th></tr><tr>'.$role_selects.'</tr></table><br /><input type="button" name="rolepickbutton" value="Save selections" onclick="setRoles()" />');
+    $r->print(
+        '<p>'
+       .&mt('Select roles, '.lc($type).' status, section(s) and group(s) for users'
+           .' who will be able to access the portfolio file.')
+       .'</p>'
+    );
+    $r->print(
+        '<form name="rolepicker" action="/adm/portfolio" method="post">'
+       .'<table><tr>'
+       .'<th>'.&mt('Roles').'</th>'
+       .'<th>'.&mt("$type status").'</th>'
+       .'<th>'.&mt('Sections').'</th>'
+       .'<th>'.&mt('Groups').'</th>'
+       .'</tr><tr>'.$role_selects.'</tr>'
+       .'</table><br />'
+       .'<input type="button" name="rolepickbutton" value="'.&mt('Save').'" onclick="setRoles()" />'
+    );
     return;
 }