[LON-CAPA-cvs] cvs: loncom /interface groupsort.pm

[raeburn]

raeburn		Sat Dec 27 20:24:18 2025 EDT

  Modified files:              
    /loncom/interface	groupsort.pm 
  Log:
  - Satisfy w3c validation.
  
  
Index: loncom/interface/groupsort.pm
diff -u loncom/interface/groupsort.pm:1.77 loncom/interface/groupsort.pm:1.78
--- loncom/interface/groupsort.pm:1.77	Tue May 30 15:16:38 2017
+++ loncom/interface/groupsort.pm	Sat Dec 27 20:24:18 2025
@@ -2,7 +2,7 @@
 # The LON-CAPA group sort handler
 # Allows for sorting prior to import into RAT.
 #
-# $Id: groupsort.pm,v 1.77 2017/05/30 15:16:38 raeburn Exp $
+# $Id: groupsort.pm,v 1.78 2025/12/27 20:24:18 raeburn Exp $
 # 
 # Copyright Michigan State University Board of Trustees
 #
@@ -333,6 +333,7 @@
 # output start of web page
     my $js = <<END;
 <script type="text/javascript">
+// <![CDATA[
 function insertRowInLastRow() {
     opener.insertrow(opener.maxrow);
     opener.addobj(opener.maxrow,'e&2');
@@ -359,6 +360,7 @@
     document.forms.groupsort.newval.value=newval;
     document.forms.groupsort.submit();
 }
+// ]]>
 </script>
 END
     # read pertinent machine configuration
@@ -501,7 +503,7 @@
 			  "</td>");
 	    }
 	    $r->print("<td>");
-	    $r->print("<img src='$iconname' />");
+	    $r->print('<img src="'.$iconname.'" alt="" />');
 	    $r->print("</td><td>");
             if (($env{'form.recover'}) &&
                 ($resource->{'url'} =~ m{/uploaded/$match_domain/$match_courseid/supplemental/})) {
@@ -524,7 +526,9 @@
     } else {
 	$r->print(<<END);
 <script type="text/javascript">
+// <![CDATA[
     finish_import();
+// ]]>
 </script>
 END
     }
@@ -570,14 +574,14 @@
     my ($total,$sel,$disabled) = @_;
     my $string;
     $string = '<select name="alt'.$sel.'"';
-    $string .= " onchange='selectchange($sel)'.$disabled.'>";
-    $string .= "<option name='o0' value='0'>".&mt('discard')."</option>";
+    $string .= ' onchange="selectchange('."'$sel'".');"'.$disabled.'>';
+    $string .= '<option value="0">'.&mt('discard').'</option>';
     for my $cur (1..$total) {
-	$string .= "<option name='o$cur' value='$cur'";
+	$string .= '<option value="'.$cur.'"';
 	if ($cur == $sel) {
-	    $string .= "selected";
+	    $string .= ' selected="selected"';
 	}
-	$string .= ">$cur</option>";
+	$string .= '>'.$cur.'</option>';
     }
     $string .= "</select>\n";
     return $string;