[LON-CAPA-cvs] cvs: loncom /interface portfolio.pm

[raeburn]

raeburn		Mon Dec 15 02:15:29 2025 EDT

  Modified files:              
    /loncom/interface	portfolio.pm 
  Log:
  - Fix typo and remove lines no longer needed after 1.273 changes.
    Add closing form tag for pop-up role/section/group selection window. 
  
  
Index: loncom/interface/portfolio.pm
diff -u loncom/interface/portfolio.pm:1.273 loncom/interface/portfolio.pm:1.274
--- loncom/interface/portfolio.pm:1.273	Mon Dec 15 01:23:05 2025
+++ loncom/interface/portfolio.pm	Mon Dec 15 02:15:29 2025
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # portfolio browser
 #
-# $Id: portfolio.pm,v 1.273 2025/12/15 01:23:05 raeburn Exp $
+# $Id: portfolio.pm,v 1.274 2025/12/15 02:15:29 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -1278,12 +1278,9 @@
 	    &Apache::loncommon::get_env_multiple('form.preserve_role_'.$num);
 	if (@delete_role_ids) {
 	    foreach my $id (@preserves) {
-                if (($id ne '') && (grep(/^$id$/, at delete_role_ids)) {
+                if (($id ne '') && (grep(/^$id$/, at delete_role_ids))) {
                     next;
                 }
-		if (grep {$_ = $id} (@delete_role_ids)) {
-		    next;
-		}
 		push(@role_ids,$id); 
 	    }
 	} else {
@@ -1979,6 +1976,7 @@
        .'</tr><tr>'.$role_selects.'</tr>'
        .'</table><br />'
        .'<input type="button" name="rolepickbutton" value="'.&mt('Save').'" onclick="setRoles()" />'
+       .'</form>'
     );
     return;
 }