[LON-CAPA-cvs] cvs: loncom /interface portfolio.pm

raeburn raeburn at source.lon-capa.org
Tue Apr 30 10:17:06 EDT 2013


raeburn		Tue Apr 30 14:17:06 2013 EDT

  Modified files:              
    /loncom/interface	portfolio.pm 
  Log:
  - Coding style: defined(), push()
  
  
Index: loncom/interface/portfolio.pm
diff -u loncom/interface/portfolio.pm:1.242 loncom/interface/portfolio.pm:1.243
--- loncom/interface/portfolio.pm:1.242	Wed Apr 24 02:23:51 2013
+++ loncom/interface/portfolio.pm	Tue Apr 30 14:17:05 2013
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # portfolio browser
 #
-# $Id: portfolio.pm,v 1.242 2013/04/24 02:23:51 raeburn Exp $
+# $Id: portfolio.pm,v 1.243 2013/04/30 14:17:05 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -640,7 +640,7 @@
 
 sub done {
     my ($linktext,$url)=@_;
-    unless (defined $linktext) {
+    unless (defined($linktext)) {
         $linktext='Return to directory';
     }
     my %anchor_fields = (
@@ -1219,7 +1219,7 @@
                 $totalnew = $lastitem;
                 my @numbers;   
                 for (my $i=$firstitem; $i<$lastitem; $i++) {
-                    push (@numbers,$i);
+                    push(@numbers,$i);
                 }
                 &display_access_row($r,$status,$newitem,\@numbers,
                                     $access_controls{$file_name},$now,$then);




More information about the LON-CAPA-cvs mailing list