[LON-CAPA-cvs] cvs: loncom /interface lonmsg.pm
bisitz
bisitz@source.lon-capa.org
Thu, 28 Oct 2010 16:20:50 -0000
bisitz Thu Oct 28 16:20:50 2010 EDT
Modified files:
/loncom/interface lonmsg.pm
Log:
Bugfix:
Allow students to send course feedback to course personnel who have a username which contains a "@" character.
Background:
"@" in usernames were replaced by ":" in the sub routine "secapply" since a change in lonfeedback.pm 1.36 to address bug #728. The sub routine moved lateron with version 1.242 to lonmsg.pm 1.197.
The replacement was probably made to ensure the user made entries to follow the format "username:domain". "username@domain" was replaced by "username:domain". Unfortunately, "username@institution:domain" was incorrectly replaced by "username:institution:domain".
The current course configuration doesn't allow free entries like "username:domain". The username is entered, but the domain is chosen from a dropdown list. The "@"->":"-replacement isn't needed anymore. courseprefs.pm takes care about this. Removing the replacement allows to receive feedback again for "@"-users.
Index: loncom/interface/lonmsg.pm
diff -u loncom/interface/lonmsg.pm:1.227 loncom/interface/lonmsg.pm:1.228
--- loncom/interface/lonmsg.pm:1.227 Mon Sep 13 23:35:44 2010
+++ loncom/interface/lonmsg.pm Thu Oct 28 16:20:50 2010
@@ -1,7 +1,7 @@
# The LearningOnline Network with CAPA
# Routines for messaging
#
-# $Id: lonmsg.pm,v 1.227 2010/09/13 23:35:44 raeburn Exp $
+# $Id: lonmsg.pm,v 1.228 2010/10/28 16:20:50 bisitz Exp $
#
# Copyright Michigan State University Board of Trustees
#
@@ -985,7 +985,6 @@
my $rec=shift;
my $defaultflag=shift;
$rec=~s/\s+//g;
- $rec=~s/\@/\:/g;
my ($adr,$sections_or_groups)=($rec=~/^([^\(]+)\(([^\)]+)\)/);
if ($sections_or_groups) {
foreach my $item (split(/\;/,$sections_or_groups)) {