[LON-CAPA-cvs] cvs: loncom /interface loncommon.pm

bisitz bisitz@source.lon-capa.org
Thu, 18 Mar 2010 17:25:52 -0000


bisitz		Thu Mar 18 17:25:52 2010 EDT

  Modified files:              
    /loncom/interface	loncommon.pm 
  Log:
  Submission Links:
  - XHTML: "&" in URL
  - Optimized white spacing of target attribute inclusion
  
  
Index: loncom/interface/loncommon.pm
diff -u loncom/interface/loncommon.pm:1.959 loncom/interface/loncommon.pm:1.960
--- loncom/interface/loncommon.pm:1.959	Thu Mar 18 13:48:45 2010
+++ loncom/interface/loncommon.pm	Thu Mar 18 17:25:52 2010
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # a pile of common routines
 #
-# $Id: loncommon.pm,v 1.959 2010/03/18 13:48:45 onken Exp $
+# $Id: loncommon.pm,v 1.960 2010/03/18 17:25:52 bisitz Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -3687,10 +3687,13 @@
     }
     if (!$symb) { $symb=&Apache::lonnet::symbread(); }
     $symb=&escape($symb);
-    if ($target) { $target="target=\"$target\""; }
-    return '<a href="/adm/grades?&command=submission&'.
-	'symb='.$symb.'&student='.$uname.
-	'&userdom='.$udom.'" '.$target.'>'.$text.'</a>';
+    if ($target) { $target=" target=\"$target\""; }
+    return
+        '<a href="/adm/grades?command=submission'.
+        '&amp;symb='.$symb.
+        '&amp;student='.$uname.
+        '&amp;userdom='.$udom.'"'.
+        $target.'>'.$text.'</a>';
 }
 ##############################################