[LON-CAPA-cvs] cvs: loncom /interface loncoursegroups.pm

bisitz bisitz@source.lon-capa.org
Thu, 07 May 2009 16:36:33 -0000


bisitz		Thu May  7 16:36:33 2009 EDT

  Modified files:              
    /loncom/interface	loncoursegroups.pm 
  Log:
  Optimized the design for group settings above step 4:
  - Added missing &mt call to (un/) available group tools display
  - Changed group tools table to simple list
  
  (work in progress)
  
  
Index: loncom/interface/loncoursegroups.pm
diff -u loncom/interface/loncoursegroups.pm:1.98 loncom/interface/loncoursegroups.pm:1.99
--- loncom/interface/loncoursegroups.pm:1.98	Thu May  7 16:09:55 2009
+++ loncom/interface/loncoursegroups.pm	Thu May  7 16:36:33 2009
@@ -1,6 +1,6 @@
 # The LearningOnline Network with CAPA
 #
-# $Id: loncoursegroups.pm,v 1.98 2009/05/07 16:09:55 bisitz Exp $
+# $Id: loncoursegroups.pm,v 1.99 2009/05/07 16:36:33 bisitz Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -1985,42 +1985,25 @@
   <td valign="top">'.$description.'</td>
   <td>
 ');
+
     if (@{$available} > 0) {
-        $r->print('<b>'.&mt('Available for assignment to members:').'</b>'.
-                    '<table class="LC_group_priv"><tr>');
-        my $rowcell = int(@{$available}/2) + @{$available}%2;
+        $r->print('<b>'.&mt('Available for assignment to members:').'</b>');
+        $r->print('<ul>');
         for (my $i=0; $i<@{$available}; $i++) {
-            if (@{$available} > 3) {
-                if ($i==$rowcell) {
-                    $r->print('</tr><tr>');
-                }
-            }
-            $r->print('<td>'.$$functions{$$available[$i]}.
-		      '</td><td>&nbsp;</td>');
+            $r->print('<li>'.&mt($$functions{$$available[$i]}).'</li>');
         }
-        if ((@{$available} > 3) && (@{$available}%2)) {
-            $r->print('<td>&nbsp;</td><td>&nbsp;</td>');
-        }
-        $r->print('</tr></table><br />');
+        $r->print('</ul>');
     }
+
     if (@{$unavailable} > 0) {
-        $r->print('<b>'.&mt('Unavailable for assignment:').'</b>'.
-                    '<table class="LC_group_priv"><tr>');
-        my $rowcell = int(@{$unavailable}/2) + @{$unavailable}%2;
-        for (my $j=0; $j<@{$unavailable}; $j++) {
-            if (@{$unavailable} > 3) {
-                if ($j==$rowcell) {
-                    $r->print('</tr><tr>');
-                }
-            }
-            $r->print('<td>'.$$functions{$$unavailable[$j]}.
-		      '</td><td>&nbsp;</td>');
+        $r->print('<b>'.&mt('Unavailable for assignment:').'</b>');
+        $r->print('<ul>');
+        for (my $i=0; $i<@{$unavailable}; $i++) {
+            $r->print('<li>'.&mt($$functions{$$unavailable[$i]}).'</li>');
         }
-        if ((@{$unavailable} > 3) && (@{$unavailable}%2)) {
-            $r->print('<td>&nbsp;</td><td>&nbsp;</td>');
-        }
-        $r->print('</tr></table>');
+        $r->print('</ul>');
     }
+
     my $quota_text=&mt('[_1] Mb',$quota);
     my $granu_text=&mt($granularity);
     $r->print(<<"END");