[LON-CAPA-cvs] cvs: loncom /homework grades.pm

raeburn raeburn@source.lon-capa.org
Wed, 24 Dec 2008 06:31:42 -0000


This is a MIME encoded message

--raeburn1230100302
Content-Type: text/plain

raeburn		Wed Dec 24 06:31:42 2008 EDT

  Modified files:              
    /loncom/homework	grades.pm 
  Log:
  - Add option to peform verification of scantron grading.
    - If enabled, scantron bubble record for each student being graded 
       will be compared with corresponding last submission stored.
      If the two strings do not match, scantron is re-run for that student.
      The comparison is repeated after the second pass - there is still a mismatch
        an error message is displayed; if they did match a warning is displayed that
        two passes were needed.
    - Code previously in &checkscantron_results() subroutine reused.
  
  - New subroutines created to facilitate code reuse:
  &scantron_partids_tograde() 
   - returns refs to %analysis and @parts from call to &ssi_with_retries()
   - contains partid.respid for non-hidden parts in a resource. 
  &grade_student_bubbles() 
   - submits %form to &ssi_with_retries() for actual grading
  &verify_scantron_grading() 
   - extracts the equivalent bubble pattern for a particular resource from
     the last submission for a student. 
  &letter_to_digits() 
   - routine to provide a hash for converting letters A -> J to corresponding numbers 1 - 0.
  
  
--raeburn1230100302
Content-Type: text/plain
Content-Disposition: attachment; filename="raeburn-20081224063142.txt"

Index: loncom/homework/grades.pm
diff -u loncom/homework/grades.pm:1.541 loncom/homework/grades.pm:1.542
--- loncom/homework/grades.pm:1.541	Mon Dec 22 14:55:28 2008
+++ loncom/homework/grades.pm	Wed Dec 24 06:31:41 2008
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # The LON-CAPA Grading handler
 #
-# $Id: grades.pm,v 1.541 2008/12/22 14:55:28 raeburn Exp $
+# $Id: grades.pm,v 1.542 2008/12/24 06:31:41 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -6177,12 +6177,18 @@
     }
     if (!$stop) {
 	my $warning=&scantron_warning_screen('Start Grading');
-	$r->print(&mt('Validation process complete.').'<br />
-'.$warning.'
-<input type="submit" name="submit" value="'.&mt('Start Grading').'" />
-<input type="hidden" name="command" value="scantron_process" />
-');
-
+	$r->print(&mt('Validation process complete.').'<br />'.
+                  $warning.
+                  &mt('Perform verification for each student after storage of submissions?').
+                  '&nbsp;<span class="LC_nobreak"><label>'.
+                  '<input type="radio" name="verifyrecord" value="1" />'.&mt('Yes').'</label>'.
+                  ('&nbsp;'x3).'<label>'.
+                  '<input type="radio" name="verifyrecord" value="0" checked="checked" />'.&mt('No').
+                  '</label></span><br />'.
+                  &mt('Grading will take longer if you use verification.').'<br />'.
+                  &mt("Alternatively, the 'Review scantron data' utility (see grading menu) can be used for all students after grading is complete.").'<br /><br />'.
+                  '<input type="submit" name="submit" value="'.&mt('Start Grading').'" />'.
+                  '<input type="hidden" name="command" value="scantron_process" />'."\n");
     } else {
 	$r->print('<input type="hidden" name="command" value="scantron_validate" />');
 	$r->print("<input type='hidden' name='validatepass' value='".$currentphase."' />");
@@ -7240,20 +7246,83 @@
     my $response_number = 0;
     my $bubble_line     = 0;
     foreach my $resource (@resources) {
-        my $symb = $resource->symb();
+        my ($analysis,$parts) = &scantron_partids_tograde($resource,$cid,$uname,$udom);
+        if ((ref($analysis) eq 'HASH') && (ref($parts) eq 'ARRAY')) {
+	    foreach my $part_id (@{$parts}) {
+                my $lines;
+
+	        # TODO - make this a persistent hash not an array.
+
+                # optionresponse, matchresponse and rankresponse type items 
+                # render as separate sub-questions in exam mode.
+                if (($analysis->{$part_id.'.type'} eq 'optionresponse') ||
+                    ($analysis->{$part_id.'.type'} eq 'matchresponse') ||
+                    ($analysis->{$part_id.'.type'} eq 'rankresponse')) {
+                    my ($numbub,$numshown);
+                    if ($analysis->{$part_id.'.type'} eq 'optionresponse') {
+                        if (ref($analysis->{$part_id.'.options'}) eq 'ARRAY') {
+                            $numbub = scalar(@{$analysis->{$part_id.'.options'}});
+                        }
+                    } elsif ($analysis->{$part_id.'.type'} eq 'matchresponse') {
+                        if (ref($analysis->{$part_id.'.items'}) eq 'ARRAY') {
+                            $numbub = scalar(@{$analysis->{$part_id.'.items'}});
+                        }
+                    } elsif ($analysis->{$part_id.'.type'} eq 'rankresponse') {
+                        if (ref($analysis->{$part_id.'.foils'}) eq 'ARRAY') {
+                            $numbub = scalar(@{$analysis->{$part_id.'.foils'}});
+                        }
+                    }
+                    if (ref($analysis->{$part_id.'.shown'}) eq 'ARRAY') {
+                        $numshown = scalar(@{$analysis->{$part_id.'.shown'}});
+                    }
+                    my $bubbles_per_line = 10;
+                    my $inner_bubble_lines = int($numbub/$bubbles_per_line);
+                    if (($numbub % $bubbles_per_line) != 0) {
+                        $inner_bubble_lines++;
+                    }
+                    for (my $i=0; $i<$numshown; $i++) {
+                        $subdivided_bubble_lines{$response_number} .= 
+                            $inner_bubble_lines.',';
+                    }
+                    $subdivided_bubble_lines{$response_number} =~ s/,$//;
+                    $lines = $numshown * $inner_bubble_lines;
+                } else {
+                    $lines = $analysis->{"$part_id.bubble_lines"};
+                } 
+
+                $first_bubble_line{$response_number} = $bubble_line;
+	        $bubble_lines_per_response{$response_number} = $lines;
+                $responsetype_per_response{$response_number} = 
+                    $analysis->{$part_id.'.type'};
+	        $response_number++;
+
+	        $bubble_line +=  $lines;
+	        $total_lines +=  $lines;
+	    }
+        }
+    }
+    &Apache::lonnet::delenv('scantron\.');
+
+    &save_bubble_lines();
+    $env{'form.scantron_maxbubble'} =
+	$total_lines;
+    return $env{'form.scantron_maxbubble'};
+}
 
-        my @parts;
+sub scantron_partids_tograde {
+    my ($resource,$cid,$uname,$udom) = @_;
+    my (%analysis,@parts); 
 
+    if (ref($resource)) {
+        my $symb = $resource->symb();
         my $result=&ssi_with_retries($resource->src(), $ssi_retries,
                                         ('symb' => $symb,
                                          'grade_target' => 'analyze',
                                          'grade_courseid' => $cid,
                                          'grade_domain' => $udom,
                                          'grade_username' => $uname));
-        my (undef, $an) =
-            split(/_HASH_REF__/,$result, 2);
-
-	my %analysis = &Apache::lonnet::str2hash($an);
+        my (undef, $an) = split(/_HASH_REF__/,$result, 2);
+        %analysis = &Apache::lonnet::str2hash($an);
 
         if (ref($analysis{'parts'}) eq 'ARRAY') {
             foreach my $part (@{$analysis{'parts'}}) {
@@ -7263,69 +7332,10 @@
                 }
             }
         }
-
-	foreach my $part_id (@parts) {
-            my $lines;
-
-	    # TODO - make this a persistent hash not an array.
-
-            # optionresponse, matchresponse and rankresponse type items 
-            # render as separate sub-questions in exam mode.
-            if (($analysis{$part_id.'.type'} eq 'optionresponse') ||
-                ($analysis{$part_id.'.type'} eq 'matchresponse') ||
-                ($analysis{$part_id.'.type'} eq 'rankresponse')) {
-                my ($numbub,$numshown);
-                if ($analysis{$part_id.'.type'} eq 'optionresponse') {
-                    if (ref($analysis{$part_id.'.options'}) eq 'ARRAY') {
-                        $numbub = scalar(@{$analysis{$part_id.'.options'}});
-                    }
-                } elsif ($analysis{$part_id.'.type'} eq 'matchresponse') {
-                    if (ref($analysis{$part_id.'.items'}) eq 'ARRAY') {
-                        $numbub = scalar(@{$analysis{$part_id.'.items'}});
-                    }
-                } elsif ($analysis{$part_id.'.type'} eq 'rankresponse') {
-                    if (ref($analysis{$part_id.'.foils'}) eq 'ARRAY') {
-                        $numbub = scalar(@{$analysis{$part_id.'.foils'}});
-                    }
-                }
-                if (ref($analysis{$part_id.'.shown'}) eq 'ARRAY') {
-                    $numshown = scalar(@{$analysis{$part_id.'.shown'}});
-                }
-                my $bubbles_per_line = 10;
-                my $inner_bubble_lines = int($numbub/$bubbles_per_line);
-                if (($numbub % $bubbles_per_line) != 0) {
-                    $inner_bubble_lines++;
-                }
-                for (my $i=0; $i<$numshown; $i++) {
-                    $subdivided_bubble_lines{$response_number} .= 
-                        $inner_bubble_lines.',';
-                }
-                $subdivided_bubble_lines{$response_number} =~ s/,$//;
-                $lines = $numshown * $inner_bubble_lines;
-            } else {
-                $lines = $analysis{"$part_id.bubble_lines"};
-            } 
-
-            $first_bubble_line{$response_number} = $bubble_line;
-	    $bubble_lines_per_response{$response_number} = $lines;
-            $responsetype_per_response{$response_number} = 
-                $analysis{$part_id.'.type'};
-	    $response_number++;
-
-	    $bubble_line +=  $lines;
-	    $total_lines +=  $lines;
-	}
-
     }
-    &Apache::lonnet::delenv('scantron\.');
-
-    &save_bubble_lines();
-    $env{'form.scantron_maxbubble'} =
-	$total_lines;
-    return $env{'form.scantron_maxbubble'};
+    return (\%analysis,\@parts);
 }
 
-
 sub scantron_validate_missingbubbles {
     my ($r,$currentphase) = @_;
     #get student info
@@ -7397,6 +7407,14 @@
     my $navmap=Apache::lonnavmaps::navmap->new();
     my $map=$navmap->getResourceByUrl($sequence);
     my @resources=$navmap->retrieveResources($map,\&scantron_filter,1,0);
+
+    my ($uname,$udom,%partids_by_symb);
+    foreach my $resource (@resources) {
+        my $ressymb = $resource->symb(); 
+        my ($analysis,$parts) = 
+            &scantron_partids_tograde($resource,$env{'request.course.id'},$uname,$udom);
+        $partids_by_symb{$ressymb} = $parts;
+    }
 #    $r->print("geto ".scalar(@resources)."<br />");
     my $result= <<SCANTRONFORM;
 <form method="post" enctype="multipart/form-data" action="/adm/grades" name="scantronupload">
@@ -7406,7 +7424,7 @@
     $r->print($result);
 
     my @delayqueue;
-    my %completedstudents;
+    my (%completedstudents,%scandata);
     
     my $lock=&Apache::lonnet::set_lock(&mt('Grading bubblesheet exam'));
     my $count=&get_todo_count($scanlines,$scan_data);
@@ -7415,9 +7433,10 @@
 				    'inline',undef,'scantronupload');
     &Apache::lonhtmlcommon::Update_PrgWin($r,\%prog_state,
 					  'Processing first student');
+    $r->print('<br />');
     my $start=&Time::HiRes::time();
     my $i=-1;
-    my ($uname,$udom,$started);
+    my $started;
 
     &scantron_get_maxbubble();	# Need the bubble lines array to parse.
     
@@ -7433,6 +7452,9 @@
 	return '';		# Dunno why the other returns return '' rather than just returning.
     }
 
+    my %lettdig = &letter_to_digits();
+    my $numletts = scalar(keys(%lettdig));
+
     while ($i<$scanlines->{'count'}) {
  	($uname,$udom)=('','');
  	$i++;
@@ -7465,36 +7487,85 @@
 	    &scantron_putfile($scanlines,$scan_data);
 	}
 	
-	my $i=0;
-	foreach my $resource (@resources) {
-	    $i++;
-	    my %form=('submitted'     =>'scantron',
-		      'grade_target'  =>'grade',
-		      'grade_username'=>$uname,
-		      'grade_domain'  =>$udom,
-		      'grade_courseid'=>$env{'request.course.id'},
-		      'grade_symb'    =>$resource->symb());
-	    if (exists($scan_record->{'scantron.CODE'})
-		&& 
-		&Apache::lonnet::validCODE($scan_record->{'scantron.CODE'})) {
-		$form{'CODE'}=$scan_record->{'scantron.CODE'};
-	    } else {
-		$form{'CODE'}='';
-	    } 
-	    my $result=&ssi_with_retries($resource->src(), $ssi_retries, %form);
-	    if ($ssi_error) {
-		$ssi_error = 0;	# So end of handler error message does not trigger.
-		$r->print("</form>");
-		&ssi_print_error($r);
-		$r->print(&show_grading_menu_form($symb));
-                &Apache::lonnet::remove_lock($lock);
-		return '';	# Why return ''?  Beats me.
-	    }
+        my $scancode;
+        if ((exists($scan_record->{'scantron.CODE'})) &&
+            (&Apache::lonnet::validCODE($scan_record->{'scantron.CODE'}))) {
+            $scancode = $scan_record->{'scantron.CODE'};
+        } else {
+            $scancode = '';
+        }
+
+        if (&grade_student_bubbles($r,$uname,$udom,$scan_record,$scancode,
+                                   @resources) eq 'ssi_error') {
+            $ssi_error = 0; # So end of handler error message does not trigger.
+            $r->print("</form>");
+            &ssi_print_error($r);
+            $r->print(&show_grading_menu_form($symb));
+            &Apache::lonnet::remove_lock($lock);
+            return '';      # Why return ''?  Beats me.
+        }
 
-	    if (&Apache::loncommon::connection_aborted($r)) { last; }
-	}
 	$completedstudents{$uname}={'line'=>$line};
-	if (&Apache::loncommon::connection_aborted($r)) { last; }
+        my $lastpos = $env{'form.scantron_maxbubble'}*$scantron_config{'Qlength'};
+        my $studentdata = substr($line,$scantron_config{'Qstart'}-1,$lastpos);
+        chomp($studentdata);
+        $studentdata =~ s/\r$//;
+        my $studentrecord = '';
+        my $counter = -1;
+        if ($env{'form.verifyrecord'}) {
+            my $lastpos = $env{'form.scantron_maxbubble'}*$scantron_config{'Qlength'};
+            my $studentdata = substr($line,$scantron_config{'Qstart'}-1,$lastpos);
+            chomp($studentdata);
+            $studentdata =~ s/\r$//;
+            my $studentrecord = '';
+            my $counter = -1;
+            foreach my $resource (@resources) {
+                ($counter,my $recording) =
+                    &verify_scantron_grading($resource,$udom,$uname,$env{'request.course.id'},
+                                             $counter,$studentdata,\%partids_by_symb,
+                                             \%scantron_config,\%lettdig,$numletts);
+                $studentrecord .= $recording;
+            }
+            if ($studentrecord ne $studentdata) {
+                $counter = -1;
+                $studentrecord = '';
+                foreach my $resource (@resources) {
+                    ($counter,my $recording) =
+                        &verify_scantron_grading($resource,$udom,$uname,$env{'request.course.id'},
+                                                 $counter,$studentdata,\%partids_by_symb,
+                                                 \%scantron_config,\%lettdig,$numletts);
+                    $studentrecord .= $recording;
+                }
+                if ($studentrecord ne $studentdata) {
+                    $r->print('<p><span class="LC_error">');
+                    if ($scancode eq '') {
+                        $r->print(&mt('Mismatch grading bubble sheet for user: [_1] with ID: [_2].',
+                                  $uname.':'.$udom,$scan_record->{'scantron.ID'}));
+                    } else {
+                        $r->print(&mt('Mismatch grading bubble sheet for user: [_1] with ID: [_2] and CODE: [_3].',
+                                  $uname.':'.$udom,$scan_record->{'scantron.ID'},$scancode));
+                    }
+                    $r->print('</span><br />'.&Apache::loncommon::start_data_table()."\n".
+                              &Apache::loncommon::start_data_table_header_row()."\n".
+                              '<th>'.&mt('Source').'</th><th>'.&mt('Bubbled responses').'</th>'.
+                              &Apache::loncommon::end_data_table_header_row()."\n".
+                              &Apache::loncommon::start_data_table_row().
+                              '<td>'.&mt('Bubble Sheet').'</td>'.
+                              '<td><span class="LC_nobreak">'.$studentdata.'</span></td>'.
+                              &Apache::loncommon::end_data_table_row().
+                              &Apache::loncommon::start_data_table_row().
+                              '<td>Stored submissions</td>'.
+                              '<td><span class="LC_nobreak">'.$studentrecord.'</span></td>'."\n".
+                              &Apache::loncommon::end_data_table_row().
+                              &Apache::loncommon::end_data_table().'</p>');
+                } else {
+                    $r->print('<br /><span class="LC_warning">'.
+                             &mt('A second grading pass was needed for user: [_1] with ID: [_2], because a mismatch was seen on the first pass.',$uname.':'.$udom,$scan_record->{'scantron.ID'}).'<br />'.
+                             &mt("As a consequence, this user's submission history records two tries.").
+                                 '</span><br />');
+                }
+            }
+        }
     } continue {
 	&Apache::lonxml::clear_problem_counter();
 	&Apache::lonnet::delenv('scantron\.');
@@ -7509,6 +7580,23 @@
     return '';
 }
 
+sub grade_student_bubbles {
+    my ($r,$uname,$udom,$scan_record,$scancode,@resources) = @_;
+    foreach my $resource (@resources) {
+        my %form = ('submitted'     => 'scantron',
+                    'grade_target'  => 'grade',
+                    'grade_username'=> $uname,
+                    'grade_domain'  => $udom,
+                    'grade_courseid'=> $env{'request.course.id'},
+                    'grade_symb'    => $resource->symb(),
+                    'code'          => $scancode);
+        my $result=&ssi_with_retries($resource->src(),$ssi_retries,%form);
+        return 'ssi_error' if ($ssi_error);
+        last if (&Apache::loncommon::connection_aborted($r));
+    }
+    return;
+}
+
 sub scantron_upload_scantron_data {
     my ($r)=@_;
     $r->print(&Apache::loncommon::coursebrowser_javascript($env{'request.role.domain'}));
@@ -7663,18 +7751,7 @@
     if (!$symb) {return '';}
     my $grading_menu_button=&show_grading_menu_form($symb);
     my $cid = $env{'request.course.id'};
-    my %lettdig = (
-                    A => 1,
-                    B => 2,
-                    C => 3,
-                    D => 4,
-                    E => 5,
-                    F => 6,
-                    G => 7,
-                    H => 8,
-                    I => 9,
-                    J => 0,
-                  );
+    my %lettdig = &letter_to_digits();
     my $numletts = scalar(keys(%lettdig));
     my $cnum = $env{'course.'.$cid.'.num'};
     my $cdom = $env{'course.'.$cid.'.domain'};
@@ -7688,6 +7765,13 @@
     my $navmap=Apache::lonnavmaps::navmap->new();
     my $map=$navmap->getResourceByUrl($sequence);
     my @resources=$navmap->retrieveResources($map,undef,1,0);
+    my ($uname,$udom,%partids_by_symb);
+    foreach my $resource (@resources) {
+        my $ressymb = $resource->symb();
+        my ($analysis,$parts) =
+            &scantron_partids_tograde($resource,$env{'request.course.id'},$uname,$udom);
+        $partids_by_symb{$ressymb} = $parts;
+    }
     my (%scandata,%lastname,%bylast);
     $r->print('
 <form method="post" enctype="multipart/form-data" action="/adm/grades" name="checkscantron">'."\n");
@@ -7741,126 +7825,12 @@
         $scandata{$pid} =~ s/\r$//;
         ($username,$domain)=split(/:/,$uname);
         my $counter = -1;
-        my (%expected,%startpos);
         foreach my $resource (@resources) {
-            next if (!$resource->is_problem());
-            my $symb = $resource->symb();
-            my $partsref = $resource->parts();
-            my @parts;
-            my @part_ids = ();
-            if (ref($partsref) eq 'ARRAY') {
-               @parts = @{$partsref};
-               foreach my $part (@parts) {
-                   my @resp_ids = $resource->responseIds($part);
-                   foreach my $resp (@resp_ids) {
-                       $counter ++;
-                       my $part_id = $part.'.'.$resp;
-                       $expected{$part_id} = 0;
-                       push(@part_ids,$part_id);
-                       if ($env{"form.scantron.sub_bubblelines.$counter"}) {
-                           my @sub_lines = split(/,/,$env{"form.scantron.sub_bubblelines.$counter"});
-                           foreach my $item (@sub_lines) {
-                               $expected{$part_id} += $item;
-                           }
-                       } else {
-                           $expected{$part_id} = $env{"form.scantron.bubblelines.$counter"};
-                       }
-                       $startpos{$part_id} = $env{"form.scantron.first_bubble_line.$counter"};
-                   }
-                }
-            }
-            if ($symb) {
-                my %recorded;
-                my (%returnhash) =
-                    &Apache::lonnet::restore($symb,$cid,$domain,$username);
-                if ($returnhash{'version'}) {
-                    my %lasthash=();
-                    my $version;
-                    for ($version=1;$version<=$returnhash{'version'};$version++) {
-                        foreach my $key (sort(split(/\:/,$returnhash{$version.':keys'}))) {
-                            $lasthash{$key}=$returnhash{$version.':'.$key};
-                        }
-                    }
-                    foreach my $key (keys(%lasthash)) {
-                        if ($key =~ /\.scantron$/) {
-                            my $value = &unescape($lasthash{$key});
-                            my ($part_id) = ($key =~ /^resource\.(.+)\.scantron$/);
-                            if ($value eq '') {
-                                for (my $i=0; $i<$expected{$part_id}; $i++) {
-                                    for (my $j=0; $j<$scantron_config{'length'}; $j++) {
-                                        $recorded{$part_id} .= $;
-                                    }
-                                }
-                            } else {
-                                my @tocheck;
-                                my @items = split(//,$value);
-                                if (($scantron_config{'Qon'} eq 'letter') ||
-                                    ($scantron_config{'Qon'} eq 'number')) {
-                                    if (@items < $expected{$part_id}) {
-                                        my $fragment = substr($scandata{$pid},$startpos{$part_id},$expected{$part_id});
-                                        my @singles = split(//,$fragment);
-                                        foreach my $pos (@singles) {
-                                            if ($pos eq ' ') {
-                                                push(@tocheck,$pos);
-                                            } else {
-                                                my $next = shift(@items);
-                                                push(@tocheck,$next);
-                                            }
-                                        }
-                                    } else {
-                                        @tocheck = @items;
-                                    }
-                                    foreach my $letter (@tocheck) {
-                                        if ($scantron_config{'Qon'} eq 'letter') {
-                                            if ($letter !~ /^[A-J]$/) {
-                                                $letter = $scantron_config{'Qoff'};
-                                            }
-                                            $recorded{$part_id} .= $letter;
-                                        } elsif ($scantron_config{'Qon'} eq 'number') {
-                                            my $digit;
-                                            if ($letter !~ /^[A-J]$/) {
-                                                $digit = $scantron_config{'Qoff'};
-                                            } else {
-                                                $digit = $lettdig{$letter};
-                                            }
-                                            $recorded{$part_id} .= $digit;
-                                        }
-                                    }
-                                } else {
-                                    @tocheck = @items;
-                                    for (my $i=0; $i<$expected{$part_id}; $i++) {
-                                        my $curr_sub = shift(@tocheck);
-                                        my $digit;
-                                        if ($curr_sub =~ /^[A-J]$/) {
-                                            $digit = $lettdig{$curr_sub}-1;
-                                        }
-                                        if ($curr_sub eq 'J') {
-                                            $digit += scalar($numletts);
-                                        }
-                                        for (my $j=0; $j<$scantron_config{'Qlength'}; $j++) {
-                                            if ($j == $digit) {
-                                                $recorded{$part_id} .= $scantron_config{'Qon'};
-                                            } else {
-                                                $recorded{$part_id} .= $scantron_config{'Qoff'};
-                                            }
-                                        }
-                                    }
-                                }
-                            }
-                        }
-                    }
-                }
-                foreach my $part_id (@part_ids) {
-                    if ($recorded{$part_id} eq '') {
-                        for (my $i=0; $i<$expected{$part_id}; $i++) {
-                            for (my $j=0; $j<$scantron_config{'Qlength'}; $j++) {
-                                $recorded{$part_id} .= $scantron_config{'Qoff'};
-                            }
-                        }
-                    }
-                    $record{$pid} .= $recorded{$part_id};
-                }
-            }
+            ($counter,my $recording) =
+                &verify_scantron_grading($resource,$domain,$username,$cid,$counter,
+                                         $scandata{$pid},\%partids_by_symb,
+                                         \%scantron_config,\%lettdig,$numletts);
+            $record{$pid} .= $recording;
         }
     }
     &Apache::lonhtmlcommon::Close_PrgWin($r,\%prog_state);
@@ -7922,6 +7892,138 @@
     return;
 }
 
+sub verify_scantron_grading {
+    my ($resource,$domain,$username,$cid,$counter,$scandata,$partids_by_symb,
+        $scantron_config,$lettdig,$numletts) = @_;
+    my ($record,%expected,%startpos);
+    return ($counter,$record) if (!ref($resource));
+    return ($counter,$record) if (!$resource->is_problem());
+    my $symb = $resource->symb();
+    return ($counter,$record) if (ref($partids_by_symb) ne 'HASH');
+    return ($counter,$record) if (ref($partids_by_symb->{$symb}) ne 'ARRAY');
+    foreach my $part_id (@{$partids_by_symb->{$symb}}) {
+        $counter ++;
+        $expected{$part_id} = 0;
+        if ($env{"form.scantron.sub_bubblelines.$counter"}) {
+            my @sub_lines = split(/,/,$env{"form.scantron.sub_bubblelines.$counter"});
+            foreach my $item (@sub_lines) {
+                $expected{$part_id} += $item;
+            }
+        } else {
+            $expected{$part_id} = $env{"form.scantron.bubblelines.$counter"};
+        }
+        $startpos{$part_id} = $env{"form.scantron.first_bubble_line.$counter"};
+    }
+    if ($symb) {
+        my %recorded;
+        my (%returnhash) = &Apache::lonnet::restore($symb,$cid,$domain,$username);
+        if ($returnhash{'version'}) {
+            my %lasthash=();
+            my $version;
+            for ($version=1;$version<=$returnhash{'version'};$version++) {
+                foreach my $key (sort(split(/\:/,$returnhash{$version.':keys'}))) {
+                    $lasthash{$key}=$returnhash{$version.':'.$key};
+                }
+            }
+            foreach my $key (keys(%lasthash)) {
+                if ($key =~ /\.scantron$/) {
+                    my $value = &unescape($lasthash{$key});
+                    my ($part_id) = ($key =~ /^resource\.(.+)\.scantron$/);
+                    if ($value eq '') {
+                        for (my $i=0; $i<$expected{$part_id}; $i++) {
+                            for (my $j=0; $j<$scantron_config->{'length'}; $j++) {
+                                $recorded{$part_id} .= $scantron_config->{'Qoff'};
+                            }
+                        }
+                    } else {
+                        my @tocheck;
+                        my @items = split(//,$value);
+                        if (($scantron_config->{'Qon'} eq 'letter') ||
+                            ($scantron_config->{'Qon'} eq 'number')) {
+                            if (@items < $expected{$part_id}) {
+                                my $fragment = substr($scandata,$startpos{$part_id},$expected{$part_id});
+                                my @singles = split(//,$fragment);
+                                foreach my $pos (@singles) {
+                                    if ($pos eq ' ') {
+                                        push(@tocheck,$pos);
+                                    } else {
+                                        my $next = shift(@items);
+                                        push(@tocheck,$next);
+                                    }
+                                }
+                            } else {
+                                @tocheck = @items;
+                            }
+                            foreach my $letter (@tocheck) {
+                                if ($scantron_config->{'Qon'} eq 'letter') {
+                                    if ($letter !~ /^[A-J]$/) {
+                                        $letter = $scantron_config->{'Qoff'};
+                                    }
+                                    $recorded{$part_id} .= $letter;
+                                } elsif ($scantron_config->{'Qon'} eq 'number') {
+                                    my $digit;
+                                    if ($letter !~ /^[A-J]$/) {
+                                        $digit = $scantron_config->{'Qoff'};
+                                    } else {
+                                        $digit = $lettdig->{$letter};
+                                    }
+                                    $recorded{$part_id} .= $digit;
+                                }
+                            }
+                        } else {
+                            @tocheck = @items;
+                            for (my $i=0; $i<$expected{$part_id}; $i++) {
+                                my $curr_sub = shift(@tocheck);
+                                my $digit;
+                                if ($curr_sub =~ /^[A-J]$/) {
+                                    $digit = $lettdig->{$curr_sub}-1;
+                                }
+                                if ($curr_sub eq 'J') {
+                                    $digit += scalar($numletts);
+                                }
+                                for (my $j=0; $j<$scantron_config->{'Qlength'}; $j++) {
+                                    if ($j == $digit) {
+                                        $recorded{$part_id} .= $scantron_config->{'Qon'};
+                                    } else {
+                                        $recorded{$part_id} .= $scantron_config->{'Qoff'};
+                                    }
+                                }
+                            }
+                        }
+                    }
+                }
+            }
+        }
+        foreach my $part_id (@{$partids_by_symb->{$symb}}) {
+            if ($recorded{$part_id} eq '') {
+                for (my $i=0; $i<$expected{$part_id}; $i++) {
+                    for (my $j=0; $j<$scantron_config->{'Qlength'}; $j++) {
+                        $recorded{$part_id} .= $scantron_config->{'Qoff'};
+                    }
+                }
+            }
+            $record .= $recorded{$part_id};
+        }
+    }
+    return ($counter,$record);
+}
+
+sub letter_to_digits { 
+    my %lettdig = (
+                    A => 1,
+                    B => 2,
+                    C => 3,
+                    D => 4,
+                    E => 5,
+                    F => 6,
+                    G => 7,
+                    H => 8,
+                    I => 9,
+                    J => 0,
+                  );
+    return %lettdig;
+}
+
 
 #-------- end of section for handling grading scantron forms -------
 #

--raeburn1230100302--