[LON-CAPA-cvs] cvs: loncom /interface portfolio.pm /localize/localize de.pm

bisitz bisitz@source.lon-capa.org
Fri, 28 Nov 2008 17:04:32 -0000


bisitz		Fri Nov 28 17:04:32 2008 EDT

  Modified files:              
    /loncom/interface	portfolio.pm 
    /loncom/localize/localize	de.pm 
  Log:
  Optimized screen layout for portfolio files in selection mode:
  - Wrapped list of selected files from different folders in data table
  - Added missing &mt() calls to button texts
  - Wrapped buttons in paragraph
  - Improved check files message and moved it under the selected files table
    (better place because selection does not take place in the selected files table)
  
  
Index: loncom/interface/portfolio.pm
diff -u loncom/interface/portfolio.pm:1.197 loncom/interface/portfolio.pm:1.198
--- loncom/interface/portfolio.pm:1.197	Fri Nov 28 16:10:20 2008
+++ loncom/interface/portfolio.pm	Fri Nov 28 17:04:25 2008
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # portfolio browser
 #
-# $Id: portfolio.pm,v 1.197 2008/11/28 16:10:20 bisitz Exp $
+# $Id: portfolio.pm,v 1.198 2008/11/28 17:04:25 bisitz Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -477,8 +477,10 @@
             <input type="hidden" name="continue" value="true" />
             <input type="hidden" name="fieldname" value="'.$env{'form.fieldname'}.'" />
             <input type="hidden" name="mode" value="selectfile" />
-            <input type="submit" name="submit" value="Select checked files, and continue selecting." /><br />
-            <input type="button" name="doit" onClick= "finishSelect();" value="Select checked files, and close window" />
+            <p>
+            <input type="submit" name="submit" value="'.&mt('Select checked files, and continue selecting').'" /><br />
+            <input type="button" name="doit" onClick= "finishSelect();" value="'.&mt('Select checked files, and close window').'" />
+            </p>
             <input type="hidden" name="currentpath" value="'.$current_path.'" />
         </form>');        
     } else {
@@ -1773,15 +1775,28 @@
         </script>
 ENDSMP
     $r->print($javascript);
-    $r->print("<h1>".&mt('Select portfolio files')."</h1>".
-                &mt('Check as many as you wish in response to the problem.')."<br />");
+    $r->print("<h1>".&mt('Select portfolio files')."</h1>");
     my @otherfiles=&Apache::lonnet::files_not_in_path($env{'user.name'}, $env{'form.currentpath'});
     if (@otherfiles) {
-	$r->print("<strong>".&mt('Files selected from other directories:')."</strong><br />");
+	$r->print(&Apache::loncommon::start_data_table()
+                 .&Apache::loncommon::start_data_table_header_row()
+                 .'<th>'.&mt('Files selected from other directories:')."</th>"
+                 .&Apache::loncommon::end_data_table_header_row()
+        );
 	foreach my $file (@otherfiles) {
-	    $r->print($file."<br />");
+	    $r->print(&Apache::loncommon::start_data_table_row()
+                     .'<td>'.$file."</td>"
+                     .&Apache::loncommon::end_data_table_row()
+            );
 	}
+        $r->print(&Apache::loncommon::end_data_table()
+                 .'<br />'
+        );
     }
+    $r->print('<div>'
+             .&mt('Check as many files as you wish in response to the problem:')
+             .'</div>'
+    );
 }
 
 
Index: loncom/localize/localize/de.pm
diff -u loncom/localize/localize/de.pm:1.161 loncom/localize/localize/de.pm:1.162
--- loncom/localize/localize/de.pm:1.161	Fri Nov 28 12:09:10 2008
+++ loncom/localize/localize/de.pm	Fri Nov 28 17:04:31 2008
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # German Localization Lexicon
 #
-# $Id: de.pm,v 1.161 2008/11/28 12:09:10 bisitz Exp $
+# $Id: de.pm,v 1.162 2008/11/28 17:04:31 bisitz Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -11563,13 +11563,13 @@
 => 'Text, der voreingestellt angezeigt werden soll:',
 
 
-   'Check as many as you wish in response to the problem.'
+   'Check as many files as you wish in response to the problem:'
 => 'Wählen Sie alle Dateien aus, die als Antwort eingereicht werden sollen:',
 
    'Select portfolio files'
 => 'Auswahl Portfolio-Dateien',
 
-   'Select checked files, and continue selecting.'
+   'Select checked files, and continue selecting'
 => 'Auswahl übernehmen und weiter auswählen',
 
    'Select checked files, and close window'