[LON-CAPA-cvs] cvs: loncom /interface multidownload.pl

[banghart]

banghart		Wed Apr 25 21:04:21 2007 EDT

  Modified files:              
    /loncom/interface	multidownload.pl 
  Log:
  	Saving work in progress.
  	- use vgr to check for permission to download
  	- eliminate unused routine
  	- change directory naming for scratch space. still needs fixing
  	- use absolute URL for link to zip file
  	- make permissions more restrictive for directories created
  
  
Index: loncom/interface/multidownload.pl
diff -u loncom/interface/multidownload.pl:1.4 loncom/interface/multidownload.pl:1.5
--- loncom/interface/multidownload.pl:1.4	Tue Apr 24 20:32:49 2007
+++ loncom/interface/multidownload.pl	Wed Apr 25 21:04:21 2007
@@ -2,7 +2,7 @@
 # CGI-script to allow download of all essay submissions of 
 # multiple students.
 #
-# $Id: multidownload.pl,v 1.4 2007/04/25 00:32:49 banghart Exp $
+# $Id: multidownload.pl,v 1.5 2007/04/26 01:04:21 banghart Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -44,10 +44,6 @@
 use LONCAPA::Enrollment;
 use strict;
 
-sub is_student {
-    return ($env{'request.role'}=~/^st\./);
-}
-
 $|=1;
 if (! &LONCAPA::loncgi::check_cookie_and_load_env()) {
     print <<END;
@@ -66,9 +62,8 @@
 &Apache::loncommon::content_type(undef,'text/html');
 my $identifier = $ENV{'QUERY_STRING'};
 print(&Apache::loncommon::start_page('Multiple Downloads'));
-$env{'request.role'} =~ m/^(.+)\./;
-my $role = $1;
-if ($role eq 'cc') {
+my $scope .= '/'.$env{'request.course.sec'};
+if (&Apache::lonnet::allowed('vgr',$scope)) {
     my $symb = $env{'cgi.'.$identifier.'.symb'};
     my $courseid = $env{'request.course.id'};
     my @stuchecked = split(/\n/,$env{'cgi.'.$identifier.'.students'});
@@ -77,21 +72,24 @@
     my @part_response_id = &Apache::grades::flatten_responseType($responseType);
     my $doc_zip_root = $Apache::lonnet::perlvar{'lonZipDir'};
     my ($partlist,$handgrade,$responseType) = &Apache::grades::response_type($symb);
-    mkdir($doc_zip_root."/zipdir",0777);
+    my $uname = $env{'user.name'};
+    my $udom = $env{'user.domain'};
+    mkdir($doc_zip_root."/zipdir",0700);
+    mkdir($doc_zip_root."/zipdir/$uname$udom",0700);
     foreach my $stu (@stuchecked) {
-        my ($uname,$udom,$fullname) = split(/:/,$stu);
-        mkdir($doc_zip_root."/zipdir/$uname",0777);
-        my %record = &Apache::lonnet::restore($symb,$courseid,$udom,$uname);
+        my ($stuname,$studom,$fullname) = split(/:/,$stu);
+        mkdir($doc_zip_root."/zipdir/$uname$udom/$stuname",0700);
+        my %record = &Apache::lonnet::restore($symb,$courseid,$studom,$stuname);
         foreach my $part (@part_response_id) {
             my ($partid,$respid) = @{$part};
-            mkdir($doc_zip_root."/zipdir/$uname/part$partid",0777);
-            mkdir($doc_zip_root."/zipdir/$uname/part$partid/resp$respid",0777);
-            my $files = &Apache::grades::get_submitted_files($udom,$uname,$partid,$respid,\%record);
+            mkdir($doc_zip_root."/zipdir/$uname$udom/$stuname/part$partid",0700);
+            mkdir($doc_zip_root."/zipdir/$uname$udom/$stuname/part$partid/resp$respid",0700);
+            my $files = &Apache::grades::get_submitted_files($studom,$stuname,$partid,$respid,\%record);
             foreach my $file (@$files) {
                 $file =~ /(^.*\/)(.+$)/;
                 my $file_name_only = $2;
                 my $file_content = &Apache::lonnet::getfile($file);
-                if (open(my $fh,">$doc_zip_root/zipdir/$uname/part$partid/resp$respid/$file_name_only")) {
+                if (open(my $fh,">$doc_zip_root/zipdir/$uname$udom/$stuname/part$partid/resp$respid/$file_name_only")) {
                     print($fh $file_content);
                     close($fh);
                 } else {
@@ -101,13 +99,12 @@
         }
     }
     mkdir($doc_zip_root."/zipout",0777);
-    my $statement = "zip -r $doc_zip_root/zipout/output.zip $doc_zip_root/zipdir/* > /dev/null";
+    my $statement = "zip -r $doc_zip_root/zipout/output.zip $doc_zip_root/zipdir/$uname$udom/* > /dev/null";
     system($statement);
-    $statement = "rm -rf $doc_zip_root/zipdir";
+    $statement = "rm -rf $doc_zip_root/zipdir/$uname$udom";
     system($statement);
-    print('<a href="../zipout/output.zip">Click to download</a><br />');
+    print('<a href="/zipspool/zipout/output.zip">Click to download</a><br />');
 } else {
     print('You are not authorized to download student submissions.');
 }
-# print($env{'request.role'}.' == roles <br />');
-return 1;
+