[LON-CAPA-cvs] cvs: modules /raeburn FIE_usage.pl

albertel lon-capa-cvs@mail.lon-capa.org
Thu, 25 May 2006 22:12:33 -0000


albertel		Thu May 25 18:12:33 2006 EDT

  Modified files:              
    /modules/raeburn	FIE_usage.pl 
  Log:
  - some perf improvments (no need to make copies when can just make a ref)
  - typo in the functions assigment
  
  
Index: modules/raeburn/FIE_usage.pl
diff -u modules/raeburn/FIE_usage.pl:1.5 modules/raeburn/FIE_usage.pl:1.6
--- modules/raeburn/FIE_usage.pl:1.5	Thu May 25 17:29:37 2006
+++ modules/raeburn/FIE_usage.pl	Thu May 25 18:12:33 2006
@@ -141,7 +141,7 @@
         my $ownermail;
 
         $owner = $crsenv{'internal.courseowner'};
-        %{$cparms{$cid}} = ( 
+        $cparms{$cid} = { 
                       coursecode => $crsenv{'internal.coursecode'},
                       grading => $crsenv{'grading'},
                       showphotos => $crsenv{'internal.showphotos'},
@@ -154,7 +154,7 @@
                       disable_receipt_display => $crsenv{'disable_receipt_display'},
                       languages => $crsenv{'languages'},
                       clonedfrom => $crsenv{'clonedfrom'},
-        );
+        };
         $summary{coursecode} = $cparms{$cid}{coursecode};
         if ($cparms{$cid}{clonedfrom}) {
             $summary{cloned} = 1;
@@ -500,7 +500,7 @@
         if ($totalmaps > 0) {
             $summary{randompicks} = 100 * $numrandompicks{$cid}/$totalmaps;
         }
-        %{$savedsummary{$cid}} = %summary;
+        $savedsummary{$cid} = \%summary;
       }
     }
     delete($env{'user.name'});
@@ -607,7 +607,7 @@
             $savedsummary{$cid}{functions} += $allfunctions{$cid}{$func};
         }
         if ($alltags{$cid}{script} > 0) {
-            $savedsummary{$cid} = $savedsummary{$cid}{functions}/$alltags{$cid}{script};
+            $savedsummary{$cid}{functions} = $savedsummary{$cid}{functions}/$alltags{$cid}{script};
         }
         print FILE "\nScript Vars: \n";
         my @filepaths = sort(keys(%script_vars));