[LON-CAPA-cvs] cvs: loncom /homework grades.pm

[banghart]

banghart		Sat Feb 25 20:04:48 2006 EDT

  Modified files:              
    /loncom/homework	grades.pm 
  Log:
  	Replace a $_ with more useful variable name
  	Get rid of some commented obsolete code lines
  	Add $respid to gradeBox
  
  
Index: loncom/homework/grades.pm
diff -u loncom/homework/grades.pm:1.316 loncom/homework/grades.pm:1.317
--- loncom/homework/grades.pm:1.316	Sat Feb 25 19:30:17 2006
+++ loncom/homework/grades.pm	Sat Feb 25 20:04:47 2006
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # The LON-CAPA Grading handler
 #
-# $Id: grades.pm,v 1.316 2006/02/26 00:30:17 albertel Exp $
+# $Id: grades.pm,v 1.317 2006/02/26 01:04:47 banghart Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -1413,7 +1413,7 @@
 
 #--- displays the grading box, used in essay type problem and grading by page/sequence
 sub gradeBox {
-    my ($request,$symb,$uname,$udom,$counter,$partid,$record) = @_;
+    my ($request,$symb,$uname,$udom,$counter,$partid,$record,$respid) = @_;
     my $checkIcon = '<img src="'.$request->dir_config('lonIconsURL').
 	'/check.gif" height="16" border="0" />';
     my $wgt    = &Apache::lonnet::EXT('resource.'.$partid.'.weight',$symb,$udom,$uname);
@@ -1825,15 +1825,6 @@
 			    $display_part.' <font color="#999999">( ID '.$respid.
 			    ' )</font>&nbsp; &nbsp;';
 			my $files=&get_submitted_files($udom,$uname,$partid,$respid,\%record);
-#			if ($record{"resource.$partid.$respid.portfiles"}) {
-#			    my $file_url = '/uploaded/'.$udom.'/'.$uname.'/portfolio';
-#			    foreach my $file (split(',',$record{"resource.$partid.$respid.portfiles"})) {
-#				push(@files,$file_url.$file);
-#			    }
-#			}
-#			if ($record{"resource.$partid.$respid.uploadedurl"}) {
-#			    push(@files,$record{"resource.$partid.$respid.uploadedurl"});
-#			}
 			if (@$files) {
 			    $lastsubonly.='<br /><font color="red" size="1">Like all files provided by users, this file may contain virusses</font><br />';
 			    my $file_counter = 0;
@@ -1918,15 +1909,14 @@
     my %seen = ();
     my @partlist;
     my @gradePartRespid;
-    for (sort keys(%$handgrade)) {
-	my ($partid,$respid) = split(/_/);
+    for my $part_resp(sort keys(%$handgrade)) {
+	my ($partid,$respid) = split(/_/, $part_resp);
 	next if ($seen{$partid} > 0);
 	$seen{$partid}++;
-	next if ($$handgrade{$_} =~ /:no$/ && $env{'form.lastSub'} =~ /^(hdgrade)$/);
+	next if ($$handgrade{$part_resp} =~ /:no$/ && $env{'form.lastSub'} =~ /^(hdgrade)$/);
 	push @partlist,$partid;
 	push @gradePartRespid,$partid.'.'.$respid;
-
-	$request->print(&gradeBox($request,$symb,$uname,$udom,$counter,$partid,\%record));
+	$request->print(&gradeBox($request,$symb,$uname,$udom,$counter,$partid,\%record,$respid));
     }
     $result='<input type="hidden" name="partlist'.$counter.
 	'" value="'.(join ":",@partlist).'" />'."\n";