[LON-CAPA-cvs] cvs: loncom /interface lonannounce.pm

[albertel]

albertel		Thu Jan 12 18:03:42 2006 EDT

  Modified files:              
    /loncom/interface	lonannounce.pm 
  Log:
  - death to $_
  
  
Index: loncom/interface/lonannounce.pm
diff -u loncom/interface/lonannounce.pm:1.41 loncom/interface/lonannounce.pm:1.42
--- loncom/interface/lonannounce.pm:1.41	Thu Jan 12 18:00:08 2006
+++ loncom/interface/lonannounce.pm	Thu Jan 12 18:03:41 2006
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Announce
 #
-# $Id: lonannounce.pm,v 1.41 2006/01/12 23:00:08 albertel Exp $
+# $Id: lonannounce.pm,v 1.42 2006/01/12 23:03:41 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -74,9 +74,9 @@
     my $coursedom=$env{'course.'.$courseid.'.domain'};
     my %thiscal=&Apache::lonnet::dump('calendar',$coursedom,$coursenum);
     my %returnhash=();
-    foreach (keys %thiscal) {
-        unless (($_=~/^error\:/) || ($thiscal{$_}=~/^error\:/)) {
-	   $returnhash{$courseid.'@'.$_}=$thiscal{$_};
+    foreach my $item (keys(%thiscal)) {
+        unless (($item=~/^error\:/) || ($thiscal{$item}=~/^error\:/)) {
+	   $returnhash{$courseid.'@'.$item}=$thiscal{$item};
         }
     }
     if ($courseid eq $env{'request.course.id'}) {
@@ -395,8 +395,8 @@
 # ------------------------------------------------------------ Process commands
     if ($serverpost) {
 	if ($env{'form.serveraction'}) {
-	    foreach (keys %env) {
-		if ($_=~/^form\.postto\_(\w+)/) {
+	    foreach my $key (keys(%env)) {
+		if ($key=~/^form\.postto\_(\w+)/) {
 		    $r->print( 
 			'<br />Posting '.$1.': '.&Apache::lonnet::postannounce
 			($1,$env{'form.serverannnounce'}));
@@ -412,11 +412,11 @@
 Check machines:<br />
 SERVERANNOUNCE
 # list servers
-    foreach (sort keys %Apache::lonnet::hostname) {
-	if (&Apache::lonnet::allowed('psa',$Apache::lonnet::hostdom{$_})) {
-	    $r->print ('<br /><input type="checkbox" name="postto_'.$_.'" /> '.
-		       $_.' <tt>'.$Apache::lonnet::hostname{$_}.'</tt> '.
-		       '<a href="http://'.$Apache::lonnet::hostname{$_}.
+    foreach my $host (sort(keys(%Apache::lonnet::hostname))) {
+	if (&Apache::lonnet::allowed('psa',$Apache::lonnet::hostdom{$host})) {
+	    $r->print ('<br /><input type="checkbox" name="postto_'.$host.'" /> '.
+		       $host.' <tt>'.$Apache::lonnet::hostname{$host}.'</tt> '.
+		       '<a href="http://'.$Apache::lonnet::hostname{$host}.
 		       '/announcement.txt" target="annowin">current</a>');
 	}
     }
@@ -453,8 +453,8 @@
 # ---------------------------------------------------------------- Remove items
         if ($env{'form.action'} eq 'del') {
 	    my @delwhich=();
-            foreach (keys %env) {
-		if ($_=~/^form\.remove\_(.+)$/) {
+            foreach my $key (keys(%env)) {
+		if ($key=~/^form\.remove\_(.+)$/) {
 		    push(@delwhich,$1);
                 }
             }
@@ -469,8 +469,8 @@
     }
 # ----------------------------------------------------- Summarize all calendars
     my %allcal=();
-    foreach (&Apache::loncommon::findallcourses()) {
-	%allcal=(%allcal,&readcalendar($_));
+    foreach my $course (&Apache::loncommon::findallcourses()) {
+	%allcal=(%allcal,&readcalendar($course));
     }
 
 # ------------------------------- Initialize table and forward backward buttons