[LON-CAPA-cvs] cvs: loncom /interface/statistics lonstudentsubmissions.pm

matthew lon-capa-cvs@mail.lon-capa.org
Tue, 12 Apr 2005 21:49:49 -0000


matthew		Tue Apr 12 17:49:49 2005 EDT

  Modified files:              
    /loncom/interface/statistics	lonstudentsubmissions.pm 
  Log:
  Two bugs with HTML output.
  Skip columns with a width of '0' as it _really_ messes up firefox.
  Some responses were not being unescaped.
  
  
Index: loncom/interface/statistics/lonstudentsubmissions.pm
diff -u loncom/interface/statistics/lonstudentsubmissions.pm:1.40 loncom/interface/statistics/lonstudentsubmissions.pm:1.41
--- loncom/interface/statistics/lonstudentsubmissions.pm:1.40	Thu Apr  7 02:56:24 2005
+++ loncom/interface/statistics/lonstudentsubmissions.pm	Tue Apr 12 17:49:49 2005
@@ -1,6 +1,6 @@
 # The LearningOnline Network with CAPA
 #
-# $Id: lonstudentsubmissions.pm,v 1.40 2005/04/07 06:56:24 albertel Exp $
+# $Id: lonstudentsubmissions.pm,v 1.41 2005/04/12 21:49:49 matthew Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -263,6 +263,9 @@
                                                           '</nobr></th>';
                 }
             }
+            if ($part_span == 0) {
+                next;
+            }
             if (! $single_part) {
                 my $tmpname = $partid;
                 if ($partid =~/^\d+$/) {
@@ -340,8 +343,9 @@
                                                'html','normal',
                                                @extra_resp_headers);
                     my $width = scalar(@headers);
+                    next if ($width < 1);
                     my $resp_data;
-                    $resp_data->{'fake'} = qq{<td colspan="$width">&nbsp</td>};
+                    $resp_data->{'fake'} = qq{<td colspan="$width">&nbsp;</td>};
                     if (! defined($results)) {
                         $results = [];
                     }
@@ -514,7 +518,7 @@
         return '';
     }
     # 
-    my $submission = &HTML::Entities::decode($response->{'Submission'});
+    my $submission = &HTML::Entities::decode(&Apache::lonnet::unescape($response->{'Submission'})); 
     return '' if (! defined($submission) || $submission eq '');
     $submission =~ s/\\\"/\"/g;
     $submission =~ s/\\\'/\'/g;