[LON-CAPA-cvs] cvs: loncom /xml londefdef.pm

[Guy Albertelli II]

Hi Alex,

Thanks for making the changes I suggessted, looks good so far.

a couple of minor quibbles.

1)

 $header_of_table .= @{ $Apache::londefdef::table{'columns'} }[$in].
                                 $Apache::londefdef::table{'vvinc'};

Is probably cleaner written as:

 $header_of_table .= $Apache::londefdef::table{'columns'}[$in].
                           $Apache::londefdef::table{'vvinc'};


2)

 if (substr(&Apache::lonxml::get_param('align',$parstack,$safeeval),0,1) ne '') {
     push @ {$Apache::londefdef::table{'rows'} }, substr(&Apache::lonxml::get_param('align',$parstack,$safeeval),0,1);


is more easily understood as:  note the spacing on the @{ and the push( )

 my $alignchar=substr(&Apache::lonxml::get_param('align',$parstack,$safeeval),0,1);
 if ( $alignchar ne '' )
     push( @{ $Apache::londefdef::table{'rows'} }, $alignchar);




Let me know if you need any help once you get to nesting tables.

-- 
albertel@msu.edu        BM: n^20 t20 z20 qS 
Guy Albertelli -7-9-4-  O-
    I would love to but . . . I have some real hard words to look
    up in the dictionary.