[LON-CAPA-cvs] cvs: loncom /interface lonfeedback.pm

raeburn raeburn at source.lon-capa.org
Fri Jan 30 21:43:24 EST 2026


raeburn		Sat Jan 31 02:43:24 2026 EDT

  Modified files:              
    /loncom/interface	lonfeedback.pm 
  Log:
  - WCAG 2.2 compliance
   - Include landmark for page's main content to support "Skip to main content"
     for Add/remove attachments page
   - Include labels for form elements
    Satisfy minimum size for touch targets
  
  
Index: loncom/interface/lonfeedback.pm
diff -u loncom/interface/lonfeedback.pm:1.397 loncom/interface/lonfeedback.pm:1.398
--- loncom/interface/lonfeedback.pm:1.397	Sat Jan 31 01:55:01 2026
+++ loncom/interface/lonfeedback.pm	Sat Jan 31 02:43:24 2026
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Feedback
 #
-# $Id: lonfeedback.pm,v 1.397 2026/01/31 01:55:01 raeburn Exp $
+# $Id: lonfeedback.pm,v 1.398 2026/01/31 02:43:24 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -1039,10 +1039,11 @@
         $postingform .= &add_blog_checkbox($crstype);
     }
     $postingform .= "</form>\n";
-    $postingform .= &generate_attachments_button('',$attachnum,$ressymb,
-                                                     $now,$currnewattach,
-                                                     $currdelold,'',$mode,
-                                                     $blockblog);
+    $postingform .= '<div class="LC_touch_target">'.
+                    &generate_attachments_button('',$attachnum,$ressymb,
+                                                 $now,$currnewattach,
+                                                 $currdelold,'',$mode,
+                                                 $blockblog);
     if ((ref($currnewattach) eq 'ARRAY') && (@{$currnewattach} > 0)) {
         $newattachmsg = '<br /><b>'.$lt{'newa'}.'</b><br />';
         if (@{$currnewattach} > 1) {
@@ -1057,7 +1058,7 @@
              $newattachmsg .= '<a href="'.$$currnewattach[0].'">'.$1.'</a><br />'."\n";
          }
     }
-    $postingform .= $newattachmsg;
+    $postingform .= $newattachmsg.'</div>';
     $postingform .= '<div class="LC_touch_target">'.
                     &generate_preview_button().
                     '</div>';
@@ -2150,7 +2151,10 @@
                 $r->print("$newattachmsg");
             }
         }
-        $r->print(&generate_attachments_button($postidx,$attachnum,$ressymb,$now,\@currnewattach,\@currdelold,$numoldver,'',$blockblog));
+        $r->print('<div class="LC_touch_target">'.
+                  &generate_attachments_button($postidx,$attachnum,$ressymb,$now,\@currnewattach,
+                                               \@currdelold,$numoldver,'',$blockblog).
+                  '</div>');
     }
     $r->print('<div class="LC_touch_target">'.
               &generate_preview_button().'</div>'.
@@ -3732,17 +3736,17 @@
     }
     $r->print(<<END);
 $start_page
+<div class="LC_landmark" role="main" id="LC_main_content">
 $toolarge
 <form name="modattachments" method="post" enctype="multipart/form-data" action="/adm/feedback?attach=$symb">
-
- <h1>$lt{'clic'}</h1>
+<h1 class="LC_heading_1">$lt{'clic'}</h1>
 END
     $r->print(&Apache::lonhtmlcommon::start_pick_box());
     $r->print(&Apache::lonhtmlcommon::row_title(&mt('Subject')));
     $r->print('<b>'.$subject.'</b>');
     $r->print(&Apache::lonhtmlcommon::row_closure());
-    $r->print(&Apache::lonhtmlcommon::row_title($lt{'adda'}));
-    $r->print('<input type="file" name="addnewattach" class="LC_flUpload" />'
+    $r->print(&Apache::lonhtmlcommon::row_title('<label for="addnewattach">'.$lt{'adda'}.'</label>'));
+    $r->print('<input type="file" name="addnewattach" id="addnewattach" class="LC_flUpload" />'
         .'<input type="hidden" id="LC_free_space" value="131072" />'
         .'<input type="button" name="upload" value="Upload" '
         .'onclick="this.form.submit()" />  '.$attachmaxtext);
@@ -3792,6 +3796,7 @@
     $r->print(<<END);
  <input type="button" name="rtntoedit" value="$lt{'stch'}" onclick="setAction()" />
 </form>
+</div>
 $end_page
 END
     return;




More information about the LON-CAPA-cvs mailing list