From raeburn at source.lon-capa.org  Mon Jan 26 12:34:25 2026
From: raeburn at source.lon-capa.org (raeburn)
Date: Mon, 26 Jan 2026 17:34:25 -0000
Subject: [LON-CAPA-cvs] cvs: loncom /interface loncommon.pm
	londependencies.pm londocs.pm
Message-ID: <cvsraeburn1769448865@cvsserver>

raeburn		Mon Jan 26 17:34:25 2026 EDT

  Modified files:              
    /loncom/interface	londependencies.pm londocs.pm loncommon.pm 
  Log:
  - WCAG 2 compliance
   - Include landmark for page's main content to support "Skip to main content"
   - Sequential headings
   - Include labels for form elements
   - Group form elements in fieldset with legend for screenreaders
   - Include empty alt tag for icons
  - Satisfy w3c validation: balance opening <p> with </p>, remove duplicate "
  
  
-------------- next part --------------
Index: loncom/interface/londependencies.pm
diff -u loncom/interface/londependencies.pm:1.5 loncom/interface/londependencies.pm:1.6
--- loncom/interface/londependencies.pm:1.5	Sun Aug 13 20:52:59 2017
+++ loncom/interface/londependencies.pm	Mon Jan 26 17:34:25 2026
@@ -2,7 +2,7 @@
 # Handler to manage dependencies for HTML files uploaded directly
 # to a course. 
 #
-# $Id: londependencies.pm,v 1.5 2017/08/13 20:52:59 raeburn Exp $
+# $Id: londependencies.pm,v 1.6 2026/01/26 17:34:25 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -132,10 +132,11 @@
     }
     my $js = &Apache::loncommon::ask_embedded_js();
     my $output = &Apache::loncommon::start_page($title,$js,
-                                                {'only_body' => 1});
+                                                {'only_body' => 1}).
+                 '<div class="LC_landmark" role="main" id="LC_main_content">';
     if ($earlyout) {
         $r->print($output.&mt('Cannot display dependency information - invalid file: [_1].',$url).
-                  &Apache::loncommon::end_page());
+                  '</div>'.&Apache::loncommon::end_page());
         return OK;
     }
     if ($action eq 'modifyhrefs') {
@@ -156,13 +157,13 @@
         } else {
             $output .= &mt('Cannot display dependency information - invalid file: [_1].',$url);
         }
-        $output .= '<p><a href="javascript:window.close()">'.&mt('Close window').'</a>';
+        $output .= '<p><a href="javascript:window.close()">'.&mt('Close window').'</a></p>';
     }
     if (($action eq 'modifyhrefs') && ($numrefchanges > 0)) {
         $output .= '<p><a href="javascript:window.opener.location.reload(true);javascript:window.close();">'.
-                   &mt('Close pop-up window and reload page').'</a>'; 
+                   &mt('Close pop-up window and reload page').'</a></p>'; 
     }
-    $output .= &Apache::loncommon::end_page();
+    $output .= '</div>'.&Apache::loncommon::end_page();
     $r->print($output);
     return OK;
 }
@@ -209,11 +210,11 @@
                 }
             }
             if ($outcome ne '') {
-                $output .= '<h4>'.&mt('Deleted unused files').'</h4>'.
+                $output .= '<h2 class="LC_heading_3">'.&mt('Deleted unused files').'</h2>'.
                            '<ul>'.$outcome.'</ul>';
             }
             if ($error ne '') {
-                $output .= '<h4>'.&mt('Error(s) deleting unused files').'</h4>'.
+                $output .= '<h2 class="LC_heading_3">'.&mt('Error(s) deleting unused files').'</h2>'.
                            '<p class="LC_warning">'.$error.'</p>';
             }
         }
@@ -222,7 +223,7 @@
                 &Apache::loncommon::upload_embedded($context,$destination,$cnum,$cdom,
                                                     $dir_root,$url_root,undef,undef,undef,
                                                     $state,'/adm/dependencies');
-            $output .= '<h4>'.&mt('Uploaded files').'</h4>'. 
+            $output .= '<h2 class="LC_heading_3">'.&mt('Uploaded files').'</h2>'.
                        $result;
             unless ($numpathchgs) {
                 if ($context eq 'syllabus') {
Index: loncom/interface/londocs.pm
diff -u loncom/interface/londocs.pm:1.736 loncom/interface/londocs.pm:1.737
--- loncom/interface/londocs.pm:1.736	Tue Jan 13 03:18:22 2026
+++ loncom/interface/londocs.pm	Mon Jan 26 17:34:25 2026
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Documents
 #
-# $Id: londocs.pm,v 1.736 2026/01/13 03:18:22 raeburn Exp $
+# $Id: londocs.pm,v 1.737 2026/01/26 17:34:25 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -7517,6 +7517,9 @@
               &Apache::lonnet::update_supp_caches($coursedom,$coursenum);
               undef($suppchanges);
           }
+          if ($uploadphase) {
+              $r->print('<div class="LC_landmark" role="main" id="LC_main_content">');
+          }
           $r->print($upload_output);
       } elsif ($env{'form.phase'} eq 'upload_embedded') {
           # Process file upload - phase two - upload embedded objects 
@@ -7533,7 +7536,8 @@
               &Apache::loncommon::upload_embedded('coursedoc',$destination,
                   $docuname,$docudom,$dir_root,$url_root,undef,undef,undef,$state,
                   $actionurl);
-          $r->print($result.&return_to_editor());
+          $r->print('<div class="LC_landmark" role="main" id="LC_main_content">'.
+                    $result.&return_to_editor());
       } elsif ($env{'form.phase'} eq 'check_embedded') {
           # Process file upload - phase three - modify references in HTML file
           $uploadphase = 'modified_orightml';
@@ -7544,14 +7548,17 @@
               &Apache::loncommon::modify_html_refs('coursedoc',$destination,
                                                    $docuname,$docudom,undef,
                                                    $dir_root);
-          $r->print($result.&return_to_editor());
+          $r->print('<div class="LC_landmark" role="main" id="LC_main_content">'.
+                    $result.&return_to_editor());
       } elsif ($env{'form.phase'} eq 'decompress_uploaded') {
           $uploadphase = 'decompress_phase_one';
-          $r->print(&decompression_phase_one().
+          $r->print('<div class="LC_landmark" role="main" id="LC_main_content">'.
+                    &decompression_phase_one().
                     &return_to_editor());
       } elsif ($env{'form.phase'} eq 'decompress_cleanup') {
           $uploadphase = 'decompress_phase_two';
-          $r->print(&decompression_phase_two().
+          $r->print('<div class="LC_landmark" role="main" id="LC_main_content">'.
+                    &decompression_phase_two().
                     &return_to_editor());
       }
   }
@@ -8494,6 +8501,8 @@
 		&Apache::lonnet::gettitle($r->uri).'</h1><p class="LC_warning">'.
 &mt('It is recommended that you use an up-to-date virus scanner before handling this file.')."</p><table>".
                 &entryline(0,&mt("Click to download or use your browser's Save Link function"),$showdoc).'</table>');
+  } elsif ($uploadphase) {
+      $r->print('</div>');
   }
  }
  unless ($noendpage) {
Index: loncom/interface/loncommon.pm
diff -u loncom/interface/loncommon.pm:1.1503 loncom/interface/loncommon.pm:1.1504
--- loncom/interface/loncommon.pm:1.1503	Sat Jan 24 02:20:56 2026
+++ loncom/interface/loncommon.pm	Mon Jan 26 17:34:25 2026
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # a pile of common routines
 #
-# $Id: loncommon.pm,v 1.1503 2026/01/24 02:20:56 raeburn Exp $
+# $Id: loncommon.pm,v 1.1504 2026/01/26 17:34:25 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -13571,7 +13571,7 @@
             next if ($embed_file =~ m{^\w+://});
         }
         $upload_output .= &start_data_table_row().
-                          '<td valign="top"><img src="'.&icon($embed_file).'" />&nbsp;'.
+                          '<td valign="top"><img src="'.&icon($embed_file).'" alt="" />&nbsp;'.
                           '<span class="LC_filename">'.$embed_file.'</span>';
         unless ($mapping{$embed_file} eq $embed_file) {
             $upload_output .= '<br /><span class="LC_info" style="font-size:smaller;">'.
@@ -13603,7 +13603,7 @@
             my ($size,$mtime) = &get_dependency_details(\%currfile,\%currsubfile,$embed_file);
             $modify_output .= &start_data_table_row().
                               '<td><a href="'.$path.'/'.$embed_file.'" style="text-decoration:none;">'.
-                              '<img src="'.&icon($embed_file).'" border="0" />'.
+                              '<img src="'.&icon($embed_file).'" border="0" alt="" />'.
                               '&nbsp;<span class="LC_filename">'.$embed_file.'</span></a></td>'.
                               '<td>'.$size.'</td>'.
                               '<td>'.$mtime.'</td>'.
@@ -13619,7 +13619,7 @@
             $counter ++;
         } else {
             $upload_output .= &start_data_table_row().
-                              '<td valign="top"><img src="'.&icon($embed_file).'" />&nbsp;'.
+                              '<td valign="top"><img src="'.&icon($embed_file).'" alt="" />&nbsp;'.
                               '<span class="LC_filename">'.$embed_file.'</span></td>'.
                               '<td align="right"><span class="LC_info LC_fontsize_medium">'.&mt('Already exists').'</span></td>'.
                               &Apache::loncommon::end_data_table_row()."\n";
@@ -13629,7 +13629,7 @@
     foreach my $oldfile (sort {lc($a) cmp lc($b)} keys(%unused)) {
         my ($size,$mtime) = &get_dependency_details(\%currfile,\%currsubfile,$oldfile);
         $delete_output .= &start_data_table_row().
-                          '<td><img src="'.&icon($oldfile).'" />'.
+                          '<td><img src="'.&icon($oldfile).'" alt="" />'.
                           '&nbsp;<span class="LC_filename">'.$oldfile.'</span></td>'.
                           '<td>'.$size.'</td>'.
                           '<td>'.$mtime.'</td>'.
@@ -13643,12 +13643,21 @@
         $delidx ++;
     }
     if ($upload_output) {
-        $upload_output = &start_data_table().
+        $upload_output = '<fieldset class="LC_borderless">'.
+                         '<legend class="LC_visually_hidden">'.&mt('Upload files').'</legend>'."\n".
+                         &start_data_table().
+                         &start_data_table_header_row().
+                         '<th>'.&mt('File').'</th>'.
+                         '<th>'.&mt('Upload?').'</th>'.
+                         &end_data_table_header_row().
                          $upload_output.
-                         &end_data_table()."\n";
+                         &end_data_table()."\n".
+                         '</fieldset><br />'."\n";
     }
     if ($modify_output) {
-        $modify_output = &start_data_table().
+        $modify_output = '<fieldset class="LC_borderless">'.
+                         '<legend class="LC_visually_hidden">'.&mt('Modify files').'</legend>'."\n".
+                         &start_data_table().
                          &start_data_table_header_row().
                          '<th>'.&mt('File').'</th>'.
                          '<th>'.&mt('Size (KB)').'</th>'.
@@ -13656,10 +13665,13 @@
                          '<th>'.&mt('Upload replacement?').'</th>'.
                          &end_data_table_header_row().
                          $modify_output.
-                         &end_data_table()."\n";
+                         &end_data_table()."\n".
+                         '</fieldset><br />'."\n";
     }
     if ($delete_output) {
-        $delete_output = &start_data_table().
+        $delete_output = '<fieldset class="LC_borderless">'.
+                         '<legend class="LC_visually_hidden">'.&mt('Delete files').'</legend>'."\n".
+                         &start_data_table().
                          &start_data_table_header_row().
                          '<th>'.&mt('File').'</th>'.
                          '<th>'.&mt('Size (KB)').'</th>'.
@@ -13667,7 +13679,8 @@
                          '<th>'.&mt('Delete?').'</th>'.
                          &end_data_table_header_row().
                          $delete_output.
-                         &end_data_table()."\n";
+                         &end_data_table()."\n".
+                         '</fieldset><br />'."\n";
     }
     my $applies = 0;
     if ($numremref) {
@@ -13681,28 +13694,29 @@
     }
     if ($counter || $numunused) {
         $output = '<form name="upload_embedded" action="'.$actionurl.'"'.
-                  ' method="post" enctype="multipart/form-data">'."\n".
-                  $state.'<h3>'.$heading.'</h3>'; 
+                  ' method="post" enctype="multipart/form-data">'."\n".$state;
         if ($actionurl eq '/adm/dependencies') {
+            $output .= '<h1 class="LC_heading_2">'.$heading.'</h1>';
             if ($numnew) {
-                $output .= '<h4>'.&mt('Missing dependencies').'</h4>'.
+                $output .= '<h2 class="LC_heading_3">'.&mt('Missing dependencies').'</h2>'.
                            '<p>'.&mt('The following files need to be uploaded.').'</p>'."\n".
                            $upload_output.'<br />'."\n";
             }
             if ($numexisting) {
-                $output .= '<h4>'.&mt('Uploaded dependencies (in use)').'</h4>'.
+                $output .= '<h2 class="LC_heading_3">'.&mt('Uploaded dependencies (in use)').'</h2>'.
                            '<p>'.&mt('Upload a new file to replace the one currently in use.').'</p>'."\n".
                            $modify_output.'<br />'."\n";
                            $buttontext = &mt('Save changes');
             }
             if ($numunused) {
-                $output .= '<h4>'.&mt('Unused files').'</h4>'.
+                $output .= '<h2 class="LC_heading_3">'.&mt('Unused files').'</h2>'.
                            '<p>'.&mt('The following uploaded files are no longer used.').'</p>'."\n".
                            $delete_output.'<br />'."\n";
                            $buttontext = &mt('Save changes');
             }
         } else {
-            $output .= $upload_output.'<br />'."\n";
+            $output .= '<h2 class="LC_heading_2">'.$heading.'</h2>'."\n".
+                       $upload_output.'<br />'."\n";
         }
         $output .= '<input type ="hidden" name="number_embedded_items" value="'.
                    $counter.'" />'."\n";
@@ -13829,7 +13843,9 @@
                    (ref($codebase) eq 'HASH'));
     my $output;
     if (($context eq 'upload_embedded') && ($type ne 'delete')) {
-       $output = '<input name="embedded_item_'.$num.'" type="file" value="" />'."\n";
+       my $labeltext = &mt('Choose file for embedded item [_1]',
+                           &HTML::Entities::encode($embed_file,'"&<>'));
+       $output = '<input name="embedded_item_'.$num.'" type="file" value="" aria-label="'.$labeltext.'" />'."\n";
     }
     $output .= '<input name="embedded_orig_'.$num.'" type="hidden" value="'.
                &escape($embed_file).'" />';
@@ -13880,7 +13896,7 @@
 
 sub ask_embedded_js {
     return <<"END";
-<script type="text/javascript"">
+<script type="text/javascript">
 // <![CDATA[
 function toggleBrowse(counter) {
     var chkboxid = document.getElementById('mod_upload_dep_'+counter);

From raeburn at source.lon-capa.org  Wed Jan 28 12:46:12 2026
From: raeburn at source.lon-capa.org (raeburn)
Date: Wed, 28 Jan 2026 17:46:12 -0000
Subject: [LON-CAPA-cvs] cvs: loncom /auth lonlogin.pm /interface loncommon.pm
Message-ID: <cvsraeburn1769622372@cvsserver>

raeburn		Wed Jan 28 17:46:12 2026 EDT

  Modified files:              
    /loncom/interface	loncommon.pm 
    /loncom/auth	lonlogin.pm 
  Log:
  - WCAG 2 compliance
    Change class name, given use in satisfying WCAG SC 2.5.8 in more contexts.
  
  
Index: loncom/interface/loncommon.pm
diff -u loncom/interface/loncommon.pm:1.1504 loncom/interface/loncommon.pm:1.1505
--- loncom/interface/loncommon.pm:1.1504	Mon Jan 26 17:34:25 2026
+++ loncom/interface/loncommon.pm	Wed Jan 28 17:46:10 2026
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # a pile of common routines
 #
-# $Id: loncommon.pm,v 1.1504 2026/01/26 17:34:25 raeburn Exp $
+# $Id: loncommon.pm,v 1.1505 2026/01/28 17:46:10 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -9772,7 +9772,7 @@
 /*
   styles used for response display
 */
-div.LC_radiofoil, div.LC_rankfoil, div.LC_optionfoil, div.LC_matchfoil, div.LC_login_links {
+div.LC_radiofoil, div.LC_rankfoil, div.LC_optionfoil, div.LC_matchfoil, div.LC_touch_target {
   margin: .51em 0em .51em 0em;
 }
 table.LC_itemgroup {
Index: loncom/auth/lonlogin.pm
diff -u loncom/auth/lonlogin.pm:1.215 loncom/auth/lonlogin.pm:1.216
--- loncom/auth/lonlogin.pm:1.215	Sat Dec 13 05:56:02 2025
+++ loncom/auth/lonlogin.pm	Wed Jan 28 17:46:12 2026
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Login Screen
 #
-# $Id: lonlogin.pm,v 1.215 2025/12/13 05:56:02 raeburn Exp $
+# $Id: lonlogin.pm,v 1.216 2026/01/28 17:46:12 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -875,12 +875,12 @@
 
     my $forgotpw = &forgotpwdisplay(%lt);
     if ($forgotpw) {
-        $forgotpw = '<div class="LC_login_links">'.
+        $forgotpw = '<div class="LC_touch_target">'.
                     $forgotpw.'</div>';
     }
     my $loginhelp = &Apache::lonauth::loginhelpdisplay($authdomain);
     if ($loginhelp) {
-        $loginhelp = '<div class="LC_login_links">'.
+        $loginhelp = '<div class="LC_touch_target">'.
                      '<a href="'.$loginhelp.'">'.$lt{'help'}.'</a></div>';
     }
 
@@ -918,12 +918,12 @@
 ENDSERVERFORM
     my $coursecatalog;
     if (($showcoursecat eq '') || ($showcoursecat)) {
-        $coursecatalog = '<div class="LC_login_links">'.
+        $coursecatalog = '<div class="LC_touch_target">'.
                          &coursecatalog_link($lt{'catalog'}).'</div>';
     }
     my $newuserlink;
     if ($shownewuserlink) {
-        $newuserlink = '<div class="LC_login_links">'.
+        $newuserlink = '<div class="LC_touch_target">'.
                        &newuser_link($lt{'newuser'}).'</div>';
     }
     my $logintitle =
@@ -1398,11 +1398,11 @@
         }
     }
     if ($servadm && $showadminmail) {
-        $contactblock = '<div class="LC_login_links">'.$lt->{'servadm'}.':<br />'.
+        $contactblock = '<div class="LC_touch_target">'.$lt->{'servadm'}.':<br />'.
                         '<tt>'.$servadm.'</tt></div>';
     }
     if ($showhelpdesk) {
-        $contactblock .= '<div class="LC_login_links">'.
+        $contactblock .= '<div class="LC_touch_target">'.
                          '<a href="javascript:helpdesk()">'.$lt->{'helpdesk'}.'</a></div>';
         my $thisurl = &escape('/adm/login');
         $$helpdeskscript = <<"ENDSCRIPT";



From raeburn at source.lon-capa.org  Fri Jan 30 12:18:01 2026
From: raeburn at source.lon-capa.org (raeburn)
Date: Fri, 30 Jan 2026 17:18:01 -0000
Subject: [LON-CAPA-cvs] cvs: loncom /interface loncoursegroups.pm
Message-ID: <cvsraeburn1769793481@cvsserver>

raeburn		Fri Jan 30 17:18:01 2026 EDT

  Modified files:              
    /loncom/interface	loncoursegroups.pm 
  Log:
  - WCAG 2 compliance
    - Replace use of <table> with <div> for layout
    - Group form elements in fieldset with legend for screenreaders
    - Satisfy minimum size for touch targets
  
  
-------------- next part --------------
Index: loncom/interface/loncoursegroups.pm
diff -u loncom/interface/loncoursegroups.pm:1.137 loncom/interface/loncoursegroups.pm:1.138
--- loncom/interface/loncoursegroups.pm:1.137	Wed Jan 21 20:53:31 2026
+++ loncom/interface/loncoursegroups.pm	Fri Jan 30 17:18:01 2026
@@ -1,6 +1,6 @@
 # The LearningOnline Network with CAPA
 #
-# $Id: loncoursegroups.pm,v 1.137 2026/01/21 20:53:31 raeburn Exp $
+# $Id: loncoursegroups.pm,v 1.138 2026/01/30 17:18:01 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -1781,16 +1781,15 @@
              .'</label>&nbsp;<label>'
              .'<input type="radio" name="granularity" value="No" checked="checked" />'.&mt('No')
              .'</label>'
-             .'</fieldset>'
     );
     if ($action eq 'modify') {
-        $r->print(' <span class="LC_nobreak">('
+        $r->print(' &nbsp;&nbsp;<span class="LC_nobreak">('
                  .&mt('Currently set to [_1].'
                      ,'"'.&mt($$stored{'granularity'}).'"')
                  .')</span>'
         );
     }
-    $r->print(&Apache::lonhtmlcommon::row_closure());
+    $r->print('</fieldset>'.&Apache::lonhtmlcommon::row_closure());
 
     # Disk Quota
     $r->print(&Apache::lonhtmlcommon::row_title('<label for="quota">'.$lt{'dquo'}.'</label>'));
@@ -2331,7 +2330,6 @@
       'asyo' => "As you have chosen not to include any collaborative tools ".
                 "in the group, no default optional privileges need to be set.",
                 'will receive by default for a specific tool.',
-      'oppr' => 'Optional privileges',
       'defp' => 'The default privileges new members will receive are:', 
       'chec' => 'Optional privileges selection',
     );
@@ -2375,8 +2373,8 @@
         if ($totaloptionalprivs) {
             $r->print('
 <br /><fieldset class="LC_borderless"><legend class="LC_visually_hidden">'.$lt{'chec'}.'</legend>
-<label><span class="LC_nobreak"><input type="radio" name="specificity" value="No" '.$specific{'No'}.' />&nbsp;'.$lt{'algm'}.'</span></label><br />
-<label><span class="LC_nobreak"><input type="radio" name="specificity" value="Yes" '.$specific{'Yes'}.' />&nbsp;'.$lt{'smgp'}.'</span></label></fieldset><br /><br />');
+<div class="LC_touch_target"><label><span class="LC_nobreak"><input type="radio" name="specificity" value="No" '.$specific{'No'}.' />&nbsp;'.$lt{'algm'}.'</span></label></div>
+<div class="LC_touch_target"><label><span class="LC_nobreak"><input type="radio" name="specificity" value="Yes" '.$specific{'Yes'}.' />&nbsp;'.$lt{'smgp'}.'</span></label></fieldset></div><br />');
         } else {
             $r->print('<input type="hidden" name="specificity" value="No" />');
         }
@@ -2392,7 +2390,8 @@
                 $r->print('('.&mt('if enabled below').').');
             }
             $r->print('<br /><br />');
-            &check_uncheck_buttons($r,$formname,'defpriv',$lt{'oppr'});
+            my $oprv = &mt('Optional Privileges');
+            &check_uncheck_buttons($r,$formname,'defpriv',$oprv);
             $r->print('<br />');
         } else {
             $r->print($lt{'algm'}.'<br /><br />');
@@ -2445,8 +2444,8 @@
 	if ($dynamic ne '') {
 	    $dynamic .= '</td><td class="LC_groups_optional">';
 	}
-        $dynamic .= '<div role="grid" class="LC_grid LC_group_priv" style="margin: 0; padding: 0;">'.
-                    '<div role="row" class="LC_grid_row">';
+        my $dynitems = '<div role="grid" class="LC_grid LC_group_priv" style="margin: 0; padding: 0;">'.
+                       '<div role="row" class="LC_grid_row">';
         foreach my $priv (sort(keys(%{$$toolprivs{$tool}}))) {
             if (exists($$fixedprivs{$tool}{$priv})) {
 		if ($fixed ne '') {
@@ -2456,30 +2455,37 @@
                          .'<span class="LC_nobreak">'.&mt($$toolprivs{$tool}{$priv}).'&nbsp;';
                 if ($action eq 'modify') {
                     if (grep(/^$tool$/,@{$available})) {
-                        $fixed .= '<small>'.&mt('(on)').'<small>&nbsp;';
+                        $fixed .= '<span class="LC_fontsize_medium">'.&mt('(on)').'</span>&nbsp;';
                     } else {
-                        $fixed .= '<small>'.&mt('(off)').'<small>&nbsp;';
+                        $fixed .= '<span class="LC_fontsize_medium">'.&mt('(off)').'</span>&nbsp;';
                     }
                 }
                 $fixed .= '</span>';
             } else {
                 $privcount++;
                 if ($privcount == 3) {
-                    $dynamic .= '</div>
-                                 <div role="row" class="LC_grid_row">'."\n";
+                    $dynitems .= '</div>
+                                  <div role="row" class="LC_grid_row">'."\n";
                 }
-                $dynamic .= '<div role="gridcell" class="LC_grid_cell"><span class="LC_nobreak"><label><input type="checkbox" name="defpriv" value="'.$priv.'" />'.&mt($$toolprivs{$tool}{$priv}).'</label></span></div>'."\n";
+                $dynitems .= '<div role="gridcell" class="LC_grid_cell"><span class="LC_nobreak"><label><input type="checkbox" name="defpriv" value="'.$priv.'" />'.&mt($$toolprivs{$tool}{$priv}).'</label></span></div>'."\n";
             }
         }
         if ($privcount == 0) {
-            $dynamic .= '<div role="gridcell" class="LC_grid_cell">'.&mt('None').'</div>'."\n";
+            $dynitems .= '<div role="gridcell" class="LC_grid_cell">'.&mt('None').'</div>'."\n";
         }
         if ($privcount < 3) {
-            $dynamic .= '<div role="gridcell" class="LC_grid_cell">&nbsp;</div>'."\n";
+            $dynitems .= '<div role="gridcell" class="LC_grid_cell">&nbsp;</div>'."\n";
         } elsif ($privcount%2) {
-            $dynamic = '<div role="gridcell" class="LC_grid_cell">&nbsp;</div>'."\n";
+            $dynitems .= '<div role="gridcell" class="LC_grid_cell">&nbsp;</div>'."\n";
+        }
+        $dynitems .= '</div></div>';
+        if ($privcount) {
+            $dynamic .= '<fieldset class="LC_borderless"><legend class="LC_visually_hidden">'.
+                        &mt('Optional privileges for '.$functions->{$tool}).'</legend>'.
+                        $dynitems.'</fieldset>';
+        } else {
+            $dynamic .= $dynitems;
         }
-	$dynamic .= '</div></div>';
     }
     $r->print(&Apache::lonhtmlcommon::row_title($lt{'fixp'},undef,
 						'LC_groups_fixed').
@@ -2633,53 +2639,49 @@
                                             $available);
     my $numcurrent = scalar(keys(%{$current}));
     if ($numcurrent > 0) {
-        $r->print('
-   <table>
-    <tr>');
         if ($num_items->{'active'}) {
-            $r->print('<td>');
+            $r->print('<div class="LC_floatleft">');
             &check_uncheck_buttons($r,$formname,'expire',$lt{'expi'});
-            $r->print('</td>');
+            $r->print('</div>');
         }
         if ($num_items->{'previous'}) {
-            $r->print('<td>');
+            $r->print('<div class="LC_floatleft">');
             &check_uncheck_buttons($r,$formname,'reenable',$lt{'reen'});
-            $r->print('</td>');
+            $r->print('</div>');
         }
         if ($num_items->{'future'}) {
-            $r->print('<td>');
+            $r->print('<div class="LC_floatleft">');
             &check_uncheck_buttons($r,$formname,'activate',$lt{'acti'});
-            $r->print('</td>');
+            $r->print('</div>');
         }
-        $r->print('<td>');
+        $r->print('<div class="LC_floatleft">');
         &check_uncheck_buttons($r,$formname,'deletion',$lt{'dele'});
-        $r->print('</td>');
+        $r->print('</div>');
         if (@{$available} > 0) {
             if ($specificity eq 'Yes') {
-                $r->print('<td>');
+                $r->print('<div class="LC_floatleft">');
                 &check_uncheck_buttons($r,$formname,'changepriv',$lt{'chpr'});
-                $r->print('</td>');
+                $r->print('</div>');
             }
             if ($granularity eq 'Yes') {
                 $r->print(&check_uncheck_tools($r,$available));
                 $r->print('
-     <td>
+    <div class="LC_floatleft">
+     <fieldset><legend>'.$lt{'curf'}.'</legend>
       <span class="LC_nobreak">
-       <fieldset><legend>'.$lt{'curf'}.'</legend>
        <input type="button" value="'.&mt('check all').'"
        onclick="javascript:checkAllTools(document.'.$formname.')" />
        &nbsp;&nbsp;
        <input type="button" value="'.&mt('uncheck all').'"
         onclick="javascript:uncheckAllTools(document.'.$formname.')" />
-      </fieldset>
-     </span>
-    </td>
+      </span>
+     </fieldset>
+    </div>
 ');
             }
         }
         $r->print(<<"END");
-   </tr>
-  </table>
+  <div style="padding:0;clear:both;margin:0;border:0"></div>
   <br />
 END
         $r->print(&Apache::loncommon::start_data_table().
@@ -2707,14 +2709,15 @@
             if ($granularity eq 'Yes') {
                 $r->print(&Apache::loncommon::start_data_table_row('LC_data_table_dense LC_data_table_highlight').'
  <td colspan="7">&nbsp;</td>
- <td colspan="'.$colspan.'" align="center"><span class="LC_nobreak"><b>'.&mt('All:').
-  '</b>&nbsp;');
+ <td colspan="'.$colspan.'" align="center">
+ <fieldset class="LC_borderless"><legend class="LC_visually_hidden">'.&mt('Apply tool setting to all listed members').'</legend>
+ <span class="LC_nobreak"><b>'.&mt('All:').'</b>&nbsp;');
                 foreach my $tool (@{$available}) {
                     $r->print('<label><input type="checkbox" name="togglefunc"'.
    ' onclick="javascript:toggleTools(document.'.$formname.'.user_'.$tool.',this);"'.
    ' value="'.$tool.'" />'.'<b>'.$tool.'</b></label>&nbsp;&nbsp;&nbsp;');
                 }
-                $r->print('</span></td></tr>');
+                $r->print('</span></fieldset></td></tr>');
             }
         }
         my %Sortby = ();
@@ -2740,7 +2743,10 @@
                 my $start = $$current{$user}{start};
                 my $end = $$current{$user}{end};
                 $r->print(&Apache::loncommon::start_data_table_row('LC_data_table_dense').'
-                            <td>');
+                          <td><fieldset class="LC_borderless"><legend class="LC_visually_hidden">
+                          '.&mt('Actions for [_1]',$fullname).'
+                          </legend>'
+                );
                 if ($$current{$user}{changestate} eq 'reenable') {
                     $r->print('<span class="LC_nobreak"><label>'. 
    '<input type="checkbox" name="reenable" value="'.$user.'" />'.
@@ -2763,16 +2769,21 @@
    '</label></span>');
                 }
                 $r->print('
-   </td>'.
+   </fieldset></td>'.
    '<td>'.$fullname.'</td>'.
    '<td>'.$uname.'</td>'.
-   '<td>'. $udom.'</td>'.
+   '<td>'.$udom.'</td>'.
    '<td>'.$id.'</td>'.
    '<td>'.$start.'</td>'.
    '<td>'.$end.'</td>');
                 if ($hastools) {
-                    $r->print('<td align="left"><span class="LC_nobreak">'.
+                    $r->print('<td align="left">');
+                    if ($granularity eq 'Yes') {
+                        $r->print('<fieldset class="LC_borderless">'.
+                                  '<legend class="LC_visually_hidden">'.&mt('Current tools for [_1]',$fullname).'</legend>'.
+                                  '<span class="LC_nobreak">'.
                                   '&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;');
+                    }
                     foreach my $tool (@{$$current{$user}{currtools}}) {
                         if ($granularity eq 'Yes') {
                             $r->print('<label><input type="checkbox" '. 
@@ -2787,17 +2798,24 @@
                          }
                          $r->print('&nbsp;&nbsp;&nbsp;');
                     }
-                    $r->print('</span></td>');
+                    $r->print('</span>');
+                    if ($granularity eq 'Yes') {
+                        $r->print('</fieldset>');
+                    }
+		    $r->print('</td>');
                 }
                 if ($addtools) {
                     $r->print('<td align="left">');
                     if ($granularity eq 'Yes') {
+                        $r->print('<fieldset class="LC_borderless">'.
+                                  '<legend class="LC_visually_hidden">'.&mt('Additional tools for [_1]',$fullname).'</legend>');
                         foreach my $tool (@{$$current{$user}{newtools}}) {
                             $r->print('<span class="LC_nobreak"><label><input type="checkbox"
                                           name="user_'.$tool.'" value="'.
                                           $user.'" />'.$tool.
                                           '</label></span>&nbsp;&nbsp;&nbsp;');
                         }
+                        $r->print('</fieldset>');
                     } else {
                         foreach my $tool (@{$$current{$user}{newtools}}) {
                             $r->print('<span class="LC_nobreak"><input type="hidden" 

From raeburn at source.lon-capa.org  Fri Jan 30 13:20:35 2026
From: raeburn at source.lon-capa.org (raeburn)
Date: Fri, 30 Jan 2026 18:20:35 -0000
Subject: [LON-CAPA-cvs] cvs: loncom /interface lonfeedback.pm
Message-ID: <cvsraeburn1769797235@cvsserver>

raeburn		Fri Jan 30 18:20:35 2026 EDT

  Modified files:              
    /loncom/interface	lonfeedback.pm 
  Log:
  - WCAG 2.2 compliance
    - Include landmark for page's main content to support "Skip to main content"
    - Include labels for form elements
    - Group form elements in fieldset with legend for screenreaders
    - Include empty alt tag for icons 
    - Satisfy minimum size for touch targets
  
  
Index: loncom/interface/lonfeedback.pm
diff -u loncom/interface/lonfeedback.pm:1.393 loncom/interface/lonfeedback.pm:1.394
--- loncom/interface/lonfeedback.pm:1.393	Fri Sep 15 23:00:16 2023
+++ loncom/interface/lonfeedback.pm	Fri Jan 30 18:20:34 2026
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Feedback
 #
-# $Id: lonfeedback.pm,v 1.393 2023/09/15 23:00:16 raeburn Exp $
+# $Id: lonfeedback.pm,v 1.394 2026/01/30 18:20:34 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -989,6 +989,7 @@
              'podi' => 'Post Discussion',
              'poan' => 'Post Anonymous Discussion',
              'newa' => 'New attachments',
+             'poco' => 'Post Content',
     );
     if ($crstype eq 'Community') {
         $lt{'note'} = &mt('Note: in anonymous discussion, your name is visible only to community facilitators');
@@ -1014,9 +1015,9 @@
 <input type="hidden" name="sendit" value="true" />
 <input type="hidden" name="timestamp" value="$now" />
 <a name="newpost"></a>
-<font size="1">$lt{'note'}</font><br />
-<b>$lt{'title'}:</b>&nbsp;<input type="text" name="subject" value="$subject" size="30" /><br />
-<textarea name="comment" cols="80" rows="14" id="comment" $textareaclass>$comment</textarea>
+<span class="LC_fontsize_medium">$lt{'note'}</span><br />
+<label><b>$lt{'title'}:</b>&nbsp;<input type="text" name="subject" value="$subject" size="30" /></label><br />
+<textarea name="comment" cols="80" rows="14" id="comment" $textareaclass aria-label="$lt{'poco'}">$comment</textarea>
 ENDDISCUSS
     if ($env{'form.origpage'}) {
         $postingform .= '<input type="hidden" name="origpage" value="'.
@@ -1057,7 +1058,9 @@
          }
     }
     $postingform .= $newattachmsg;
-    $postingform .= &generate_preview_button();
+    $postingform .= '<div class="LC_touch_target">'.
+                    &generate_preview_button().
+                    '</div>';
     return $postingform;
 }
 
@@ -2034,7 +2037,8 @@
   }
   $r->print(<<END);
 $start_page
-<h1>$lt{'myqu'}</h1>
+<div class="LC_landmark" role="main" id="LC_main_content">
+<h1 class="LC_heading_1">$lt{'myqu'}</h1>
 $header
 <form action="/adm/feedback" method="post" name="mailform"
 enctype="multipart/form-data">
@@ -2062,18 +2066,19 @@
 <p>
 $textareaheader
 </p>
-<p>
+<div>
 $latexHelp
-</p>
-<p>
+</div>
 END
 
     
-    $r->print(&Apache::lonhtmlcommon::row_title(&mt('Subject')));
-    $r->print('<input type="text" name="subject" size="30" value="'.
-              $subject.'" /></p>');
+    $r->print(&Apache::lonhtmlcommon::row_title('<label for="subject">'.
+                                                &mt('Subject').'</label>'));
+    $r->print('<input type="text" name="subject" id="subject" size="30" value="'.
+              $subject.'" />');
     $r->print(&Apache::lonhtmlcommon::row_closure());
-    $r->print(&Apache::lonhtmlcommon::row_title(&mt('Message')));
+    $r->print(&Apache::lonhtmlcommon::row_title('<label for="comment">'.
+                                                &mt('Message').'</label>'));
     $r->print('<textarea name="comment" id="comment" cols="55" rows="10" '.
               $textareaclass.'>'.$comment.
               '</textarea>');
@@ -2101,7 +2106,7 @@
     } else {
         $r->print(<<END);
 <p>
-$lt{'atta'} $attachmaxtext: <input type="file" name="attachment" class="LC_flUpload" />
+<label for="attachment">$lt{'atta'}</label> $attachmaxtext: <input type="file" name="attachment" class="LC_flUpload" id="attachment" />
 <input type="hidden" id="LC_free_space" value="131072" />
 </p>
 END
@@ -2153,9 +2158,10 @@
         }
         $r->print(&generate_attachments_button($postidx,$attachnum,$ressymb,$now,\@currnewattach,\@currdelold,$numoldver,'',$blockblog));
     }
-    $r->print(&generate_preview_button().
+    $r->print('<div class="LC_touch_target">'.
+              &generate_preview_button().'</div>'.
+              '</div>'.
 	      &Apache::loncommon::end_page());
-
 }
 
 sub print_display_options {
@@ -3069,22 +3075,24 @@
     }
     if (keys(%discoptions)) {
         if ($discoptions{'nonanon'}) {
-            $discussoptions='<label><input type="radio" name="discuss" value="nonanon" checked="checked" /> '.
+            $discussoptions='<div class_"LC_touch_target">'.
+                            '<label><input type="radio" name="discuss" value="nonanon" checked="checked" /> '.
                             $contribdisc.
-                            '</label>';
+                            '</label></div>';
         }
         if ($discoptions{'anon'}) {
-            $discussoptions .= '<br /><label><input type="radio" name="discuss" value="anon"'.$checkradio.' /> '.
+            $discussoptions .= '<div class_"LC_touch_target">'.
+                               '<label><input type="radio" name="discuss" value="anon"'.$checkradio.' /> '.
                                $anoncontrib.
                                ' <i>('.$namevis.')</i></label> '.
-                               '<a href="/adm/preferences?action=changescreenname">'.&mt('Change Screenname').'</a>';
+                               '<a href="/adm/preferences?action=changescreenname">'.&mt('Change Screenname').'</a></div>';
         }
         if (!$blockblog) {
             $discussoptions.= &add_blog_checkbox($crstype);
         }
     }
     if ($msgoptions) {
-        $msgoptions='<tr><th><img src="'.&Apache::loncommon::lonhttpdurl('/res/adm/pages/feedback.png').'" />'
+        $msgoptions='<tr><th><img src="'.&Apache::loncommon::lonhttpdurl('/res/adm/pages/feedback.png').'" alt="" />'
                    .'<br />'.&mt('Send Feedback').'<br />'.&Apache::lonhtmlcommon::coursepreflink(&mt('Feedback Settings'),'feedback').'</th>'.
                    '<td>'.$msgoptions.'</td></tr>';
     }
@@ -3093,7 +3101,10 @@
                         .'<br />'.&mt('Discussion Contributions').'<br />'.&Apache::lonhtmlcommon::coursepreflink(&mt('Discussion Settings'),'discussion').'</th>'.
                         '<td>'.$discussoptions.'</td></tr>';
     }
-    return  &Apache::loncommon::start_data_table().$msgoptions.$discussoptions.&Apache::loncommon::end_data_table();
+    return '<fieldset class="LC_borderless"><legend class="LC_visually_hidden">'.
+           &mt('Select Destination').'</legend>'.
+           &Apache::loncommon::start_data_table().$msgoptions.$discussoptions.&Apache::loncommon::end_data_table().
+           '</fieldset>';
 }
 
 sub resource_output {
@@ -3566,7 +3577,8 @@
     my $end_page = &Apache::loncommon::end_page();
 
     $r->print($start_page
-             .'<h1>'.&mt('Preview').'</h1>'
+             .'<div class="LC_landmark" role="main" id="LC_main_content">'
+             .'<h1 class="LC_heading_1">'.&mt('Preview').'</h1>'
              .&Apache::lonhtmlcommon::start_pick_box()
              .&Apache::lonhtmlcommon::row_title(&mt('Subject'))
              .$subject
@@ -3575,6 +3587,7 @@
              .$message
              .&Apache::lonhtmlcommon::row_closure(1)
              .&Apache::lonhtmlcommon::end_pick_box()
+             .'</div>'
              .$end_page
     );
 }
@@ -3632,7 +3645,6 @@
     unless ($fieldname) { $fieldname='comment'; }
     my $pre=&mt("Show Preview and Check Spelling");
     return(<<ENDPREVIEW);
-<br />
 <form name="preview" action="/adm/feedback?preview=1" method="post" target="preview">
 <input type="hidden" name="subject" />
 <input type="hidden" name="comment" />
@@ -3957,14 +3969,14 @@
         document.attachment.blog.value = 0;
     }
 }
-</script><br />
+</script><div class="LC_touch_target">
 <label><input type="checkbox" name="blog" '.$checkstatus.' /> ';
     if ($crstype eq 'Community') {
         $output .= &mt('Add to my public community blog');
     } else {
         $output .= &mt('Add to my public course blog');
     } 
-    $output .= '</label><br />'."\n";
+    $output .= '</label></div>'."\n";
     return $output;
 }
 



From raeburn at source.lon-capa.org  Fri Jan 30 20:16:46 2026
From: raeburn at source.lon-capa.org (raeburn)
Date: Sat, 31 Jan 2026 01:16:46 -0000
Subject: [LON-CAPA-cvs] cvs: loncom /interface lonfeedback.pm
Message-ID: <cvsraeburn1769822206@cvsserver>

raeburn		Sat Jan 31 01:16:46 2026 EDT

  Modified files:              
    /loncom/interface	lonfeedback.pm 
  Log:
  - Fix typos in rev. 1.394
  
  
Index: loncom/interface/lonfeedback.pm
diff -u loncom/interface/lonfeedback.pm:1.394 loncom/interface/lonfeedback.pm:1.395
--- loncom/interface/lonfeedback.pm:1.394	Fri Jan 30 18:20:34 2026
+++ loncom/interface/lonfeedback.pm	Sat Jan 31 01:16:46 2026
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Feedback
 #
-# $Id: lonfeedback.pm,v 1.394 2026/01/30 18:20:34 raeburn Exp $
+# $Id: lonfeedback.pm,v 1.395 2026/01/31 01:16:46 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -3075,13 +3075,13 @@
     }
     if (keys(%discoptions)) {
         if ($discoptions{'nonanon'}) {
-            $discussoptions='<div class_"LC_touch_target">'.
+            $discussoptions='<div class="LC_touch_target">'.
                             '<label><input type="radio" name="discuss" value="nonanon" checked="checked" /> '.
                             $contribdisc.
                             '</label></div>';
         }
         if ($discoptions{'anon'}) {
-            $discussoptions .= '<div class_"LC_touch_target">'.
+            $discussoptions .= '<div class="LC_touch_target">'.
                                '<label><input type="radio" name="discuss" value="anon"'.$checkradio.' /> '.
                                $anoncontrib.
                                ' <i>('.$namevis.')</i></label> '.



From raeburn at source.lon-capa.org  Fri Jan 30 20:38:41 2026
From: raeburn at source.lon-capa.org (raeburn)
Date: Sat, 31 Jan 2026 01:38:41 -0000
Subject: [LON-CAPA-cvs] cvs: loncom /interface lonfeedback.pm
Message-ID: <cvsraeburn1769823521@cvsserver>

raeburn		Sat Jan 31 01:38:41 2026 EDT

  Modified files:              
    /loncom/interface	lonfeedback.pm 
  Log:
  - Satisfy w3c validation.
  
  
Index: loncom/interface/lonfeedback.pm
diff -u loncom/interface/lonfeedback.pm:1.395 loncom/interface/lonfeedback.pm:1.396
--- loncom/interface/lonfeedback.pm:1.395	Sat Jan 31 01:16:46 2026
+++ loncom/interface/lonfeedback.pm	Sat Jan 31 01:38:41 2026
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Feedback
 #
-# $Id: lonfeedback.pm,v 1.395 2026/01/31 01:16:46 raeburn Exp $
+# $Id: lonfeedback.pm,v 1.396 2026/01/31 01:38:41 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -1021,7 +1021,7 @@
 ENDDISCUSS
     if ($env{'form.origpage'}) {
         $postingform .= '<input type="hidden" name="origpage" value="'.
-                        $env{'form.origpage'}.'" />'."\n";
+                        &HTML::Entities::encode($env{'form.origpage'},'"<>&').'" />'."\n";
         foreach my $att (@{$currnewattach}) {
             $postingform .= '<input type="hidden" name="currnewattach" '.
                             'value="'.$att.'" />'."\n";
@@ -2059,19 +2059,13 @@
   $r->print(<<END);
 $options
 <br />
-END
-$r->print(&Apache::lonhtmlcommon::start_pick_box());
-$r->print(<<END);
-$quote
-<p>
 $textareaheader
-</p>
+$quote
 <div>
 $latexHelp
 </div>
 END
-
-    
+    $r->print(&Apache::lonhtmlcommon::start_pick_box());
     $r->print(&Apache::lonhtmlcommon::row_title('<label for="subject">'.
                                                 &mt('Subject').'</label>'));
     $r->print('<input type="text" name="subject" id="subject" size="30" value="'.
@@ -3702,7 +3696,10 @@
 
     my $end_page = 
 	&Apache::loncommon::end_page();
-				       
+    my $origpage;
+    if ($env{'form.origpage'} ne '') {
+        $origpage = &HTML::Entities::encode($env{'form.origpage'},'"<>&');
+    }
     $r->print(<<END);
 $start_page
 $toolarge
@@ -3752,7 +3749,7 @@
 <input type="hidden" name="timestamp" value="$env{'form.timestamp'}" />
 <input type="hidden" name="idx" value="$env{'form.idx'}" />
 <input type="hidden" name="numoldver" value="$env{'form.numoldver'}" />
-<input type="hidden" name="origpage" value="$env{'form.origpage'}" />
+<input type="hidden" name="origpage" value="$origpage" />
 <input type="hidden" name="blog" value="$env{'form.blog'}" />
 <input type="hidden" name="discuss" value="$env{'form.discuss'}" />
 END
@@ -3801,7 +3798,7 @@
 sub generate_attachments_button {
     my ($idx,$attachnum,$ressymb,$now,$currnewattach,$deloldattach,
         $numoldver,$mode,$blockblog) = @_;
-    my $origpage = $ENV{'REQUEST_URI'};
+    my $origpage = &HTML::Entities::encode($ENV{'REQUEST_URI'},'"<>&');
     my $att=$attachnum.' '.&mt("attachments");
     my %lt = &Apache::lonlocal::texthash(
                 'clic' => 'Add/remove attachments',



From raeburn at source.lon-capa.org  Fri Jan 30 20:55:01 2026
From: raeburn at source.lon-capa.org (raeburn)
Date: Sat, 31 Jan 2026 01:55:01 -0000
Subject: [LON-CAPA-cvs] cvs: loncom /interface lonfeedback.pm
Message-ID: <cvsraeburn1769824501@cvsserver>

raeburn		Sat Jan 31 01:55:01 2026 EDT

  Modified files:              
    /loncom/interface	lonfeedback.pm 
  Log:
  - Behavior of feedback icon/link in links/icons on right side of header 
    consistent with behavior of "Post Discussion" and Feedback links in footer:
    when "This discussion is closed" shown in footer
  - Warning shown when no message can be sent reflects context, i.e., launch
    from Footer (just discussion or just feedback), or from header (either)
  
  
Index: loncom/interface/lonfeedback.pm
diff -u loncom/interface/lonfeedback.pm:1.396 loncom/interface/lonfeedback.pm:1.397
--- loncom/interface/lonfeedback.pm:1.396	Sat Jan 31 01:38:41 2026
+++ loncom/interface/lonfeedback.pm	Sat Jan 31 01:55:01 2026
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Feedback
 #
-# $Id: lonfeedback.pm,v 1.396 2026/01/31 01:38:41 raeburn Exp $
+# $Id: lonfeedback.pm,v 1.397 2026/01/31 01:55:01 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -2755,9 +2755,19 @@
 sub fail_redirect {
   my ($r,$feedurl,$delay) = @_;
   if ($feedurl=~/^\/adm\//) { $feedurl.='?register=1' };
+  my $msg;
   my %lt = &Apache::lonlocal::texthash(
                  'sorr' => 'Sorry, no recipients ...',
+                 'this' => 'This discussion is closed.',
+                 'none' => 'No recipients for feedback and discussion is closed',
   );
+  if ($env{'form.sendmessageonly'}) {
+      $msg = $lt{'sorr'};
+  } elsif ($env{'form.editdisc'} || $env{'form.replydisc'}) {
+      $msg = $lt{'this'};
+  } else {
+      $msg = $lt{'none'};
+  }
   my $logo=&Apache::loncommon::lonhttpdurl('/adm/lonIcons/lonlogos.gif');
   my %parms=('only_body'   => 1);
   if ($delay !~ /^\d+(|\.\d+)$/) {
@@ -2782,7 +2792,7 @@
   }
   $r->print(<<ENDFAILREDIR);
 <img align="right" src="$logo" />
-<p class="LC_warning">$lt{'sorr'}</p>
+<p class="LC_warning">$msg</p>
 <form name="reldt" action="$feedurl" target="$windowname">
 </form>
 ENDFAILREDIR
@@ -3030,7 +3040,27 @@
         my $cdom = $env{'course.'.$env{'request.course.id'}.'.domain'};
         my $cnum = $env{'course.'.$env{'request.course.id'}.'.num'};
         my $realsymb = &get_realsymb($symb);
-        if (!$blocked && &discussion_open(undef,$realsymb) &&
+        my $status = undef;
+        if (($feedurl=~/$LONCAPA::assess_re/) ||
+            (($symb =~ /ext\.tool$/) &&
+             (&Apache::lonnet::EXT('resource.0.gradable',$symb) =~ /^yes$/i))) {
+            my $type;
+            if ($feedurl =~ /\.task$/) {
+                $type = 'Task';
+            } elsif ($symb =~ /ext\.tool$/) {
+                $type = 'tool';
+            } else {
+                $type = 'problem';
+            }
+            if ($type eq 'tool') {
+                ($status) =
+                    &Apache::lonhomework::check_slot_access('0',$type,$symb,['0']);
+            } else {
+                ($status) =
+                    &Apache::lonhomework::check_slot_access('0',$type,$symb);
+            }
+        }
+        if (!$blocked && &discussion_open($status,$realsymb) &&
             (&Apache::lonnet::allowed('pch',
                                       $env{'request.course.id'}.
                                       ($env{'request.course.sec'}?'/'.$env{'request.course.sec'}:'')) ||



From raeburn at source.lon-capa.org  Fri Jan 30 21:43:24 2026
From: raeburn at source.lon-capa.org (raeburn)
Date: Sat, 31 Jan 2026 02:43:24 -0000
Subject: [LON-CAPA-cvs] cvs: loncom /interface lonfeedback.pm
Message-ID: <cvsraeburn1769827404@cvsserver>

raeburn		Sat Jan 31 02:43:24 2026 EDT

  Modified files:              
    /loncom/interface	lonfeedback.pm 
  Log:
  - WCAG 2.2 compliance
   - Include landmark for page's main content to support "Skip to main content"
     for Add/remove attachments page
   - Include labels for form elements
    Satisfy minimum size for touch targets
  
  
Index: loncom/interface/lonfeedback.pm
diff -u loncom/interface/lonfeedback.pm:1.397 loncom/interface/lonfeedback.pm:1.398
--- loncom/interface/lonfeedback.pm:1.397	Sat Jan 31 01:55:01 2026
+++ loncom/interface/lonfeedback.pm	Sat Jan 31 02:43:24 2026
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Feedback
 #
-# $Id: lonfeedback.pm,v 1.397 2026/01/31 01:55:01 raeburn Exp $
+# $Id: lonfeedback.pm,v 1.398 2026/01/31 02:43:24 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -1039,10 +1039,11 @@
         $postingform .= &add_blog_checkbox($crstype);
     }
     $postingform .= "</form>\n";
-    $postingform .= &generate_attachments_button('',$attachnum,$ressymb,
-                                                     $now,$currnewattach,
-                                                     $currdelold,'',$mode,
-                                                     $blockblog);
+    $postingform .= '<div class="LC_touch_target">'.
+                    &generate_attachments_button('',$attachnum,$ressymb,
+                                                 $now,$currnewattach,
+                                                 $currdelold,'',$mode,
+                                                 $blockblog);
     if ((ref($currnewattach) eq 'ARRAY') && (@{$currnewattach} > 0)) {
         $newattachmsg = '<br /><b>'.$lt{'newa'}.'</b><br />';
         if (@{$currnewattach} > 1) {
@@ -1057,7 +1058,7 @@
              $newattachmsg .= '<a href="'.$$currnewattach[0].'">'.$1.'</a><br />'."\n";
          }
     }
-    $postingform .= $newattachmsg;
+    $postingform .= $newattachmsg.'</div>';
     $postingform .= '<div class="LC_touch_target">'.
                     &generate_preview_button().
                     '</div>';
@@ -2150,7 +2151,10 @@
                 $r->print("$newattachmsg");
             }
         }
-        $r->print(&generate_attachments_button($postidx,$attachnum,$ressymb,$now,\@currnewattach,\@currdelold,$numoldver,'',$blockblog));
+        $r->print('<div class="LC_touch_target">'.
+                  &generate_attachments_button($postidx,$attachnum,$ressymb,$now,\@currnewattach,
+                                               \@currdelold,$numoldver,'',$blockblog).
+                  '</div>');
     }
     $r->print('<div class="LC_touch_target">'.
               &generate_preview_button().'</div>'.
@@ -3732,17 +3736,17 @@
     }
     $r->print(<<END);
 $start_page
+<div class="LC_landmark" role="main" id="LC_main_content">
 $toolarge
 <form name="modattachments" method="post" enctype="multipart/form-data" action="/adm/feedback?attach=$symb">
-
- <h1>$lt{'clic'}</h1>
+<h1 class="LC_heading_1">$lt{'clic'}</h1>
 END
     $r->print(&Apache::lonhtmlcommon::start_pick_box());
     $r->print(&Apache::lonhtmlcommon::row_title(&mt('Subject')));
     $r->print('<b>'.$subject.'</b>');
     $r->print(&Apache::lonhtmlcommon::row_closure());
-    $r->print(&Apache::lonhtmlcommon::row_title($lt{'adda'}));
-    $r->print('<input type="file" name="addnewattach" class="LC_flUpload" />'
+    $r->print(&Apache::lonhtmlcommon::row_title('<label for="addnewattach">'.$lt{'adda'}.'</label>'));
+    $r->print('<input type="file" name="addnewattach" id="addnewattach" class="LC_flUpload" />'
         .'<input type="hidden" id="LC_free_space" value="131072" />'
         .'<input type="button" name="upload" value="Upload" '
         .'onclick="this.form.submit()" />  '.$attachmaxtext);
@@ -3792,6 +3796,7 @@
     $r->print(<<END);
  <input type="button" name="rtntoedit" value="$lt{'stch'}" onclick="setAction()" />
 </form>
+</div>
 $end_page
 END
     return;