[LON-CAPA-cvs] cvs: loncom /homework grades.pm

raeburn raeburn at source.lon-capa.org
Sun Aug 24 14:01:20 EDT 2025


raeburn		Sun Aug 24 18:01:20 2025 EDT

  Modified files:              
    /loncom/homework	grades.pm 
  Log:
  - Bug 6623. Remove unused scalar and commented out code. Fix order of args
    passed to lonhomework::partial_credit_overdue().    
  
  
Index: loncom/homework/grades.pm
diff -u loncom/homework/grades.pm:1.820 loncom/homework/grades.pm:1.821
--- loncom/homework/grades.pm:1.820	Thu Aug 21 16:21:41 2025
+++ loncom/homework/grades.pm	Sun Aug 24 18:01:20 2025
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # The LON-CAPA Grading handler
 #
-# $Id: grades.pm,v 1.820 2025/08/21 16:21:41 raeburn Exp $
+# $Id: grades.pm,v 1.821 2025/08/24 18:01:20 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -2329,7 +2329,6 @@
             my $version;
             my $lastsubmittime = 0;
             my $lastduedate = 0;
-            my $lastresettime;
             for ($version=1;$version<=$record->{'version'};$version++) {
                 if ((exists($record->{$version.':resource.'.$part.'.pastdue'})) &&
                     (exists($record->{$version.':resource.'.$part.'.duedate'}))) {
@@ -2340,27 +2339,10 @@
                         $lastduedate = $record->{$version.':resource.'.$part.'.duedate'};
                     }
                 }
-#                foreach my $key (sort(split(/\:/,
-#                                        $record->{$version.':keys'}))) {
-#                    if ($key =~ /\Q$part\E\.[^.]+\.portfiles$/) {
-#                        if (($record->{$version.':'.$key} ne '') &&
-#                            ($record->{$version.':'.$key} !~ /\.\d+\.\w+$/)) {
-#                            if ($record->{$version.':timestamp'} > $lastsubmittime) {
-#                                $lastsubmittime = $record->{$version.':timestamp'};
-#                            }
-#                        }
-#                    } elsif ($key =~ /\Q$part\E\.[^.]+\.submission$/) {
-#                        if ($record->{$version.':'.$key} ne '') {
-#                            if ($record->{$version.':timestamp'} > $lastsubmittime) {
-#                                $lastsubmittime = $record->{$version.':timestamp'};
-#                            }
-#                        }
-#                    }
-#                }
             }
             $newlatefrac =
-                &Apache::lonhomework::partial_credit_overdue($part,$lastsubmittime,
-                                                             $lastduedate,$symb,$udom,$uname);
+                &Apache::lonhomework::partial_credit_overdue($part,$lastduedate,$lastsubmittime,
+                                                             $symb,$udom,$uname);
         }
     }
     return $newlatefrac;




More information about the LON-CAPA-cvs mailing list