[LON-CAPA-cvs] cvs: loncom /homework rankresponse.pm

raeburn raeburn at source.lon-capa.org
Mon Jan 27 09:46:20 EST 2025


raeburn		Mon Jan 27 14:46:20 2025 EDT

  Modified files:              
    /loncom/homework	rankresponse.pm 
  Log:
  - WCAG 2 compliance. Use label tag instead of aria-label.
  
  
Index: loncom/homework/rankresponse.pm
diff -u loncom/homework/rankresponse.pm:1.75 loncom/homework/rankresponse.pm:1.76
--- loncom/homework/rankresponse.pm:1.75	Sat Jan 25 23:24:23 2025
+++ loncom/homework/rankresponse.pm	Mon Jan 27 14:46:20 2025
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # rank style response
 #
-# $Id: rankresponse.pm,v 1.75 2025/01/25 23:24:23 raeburn Exp $
+# $Id: rankresponse.pm,v 1.76 2025/01/27 14:46:20 raeburn Exp $
 # Copyright Michigan State University Board of Trustees
 #
 # This file is part of the LearningOnline Network with CAPA (LON-CAPA).
@@ -408,7 +408,6 @@
         }
         foreach my $name (@whichfoils) {
 	    my $lastopt=$lastresponse{$name};
-            my $text=$Apache::response::foilgroup{$name.'.text'};
 	    my $optionlist='';
 	    if ($target ne 'tex') {
                 $optionlist = "<option value=\"\"></option>\n";
@@ -434,20 +433,20 @@
 		} 
 	    }
 	    if ($target ne 'tex' && $Apache::lonhomework::type ne 'exam') {
-                my $labeltext = &mt('Choose ranking for:').' '.$text;
-		$optionlist='<select onchange="javascript:setSubmittedPart(\''.
+		$optionlist='<label><select onchange="javascript:setSubmittedPart(\''.
 		  $part.'\');" name="HWVAL_'.
-		    $Apache::inputtags::response[-1].':'.$temp.'" aria-label="'.$labeltext.'">'.
+		    $Apache::inputtags::response[-1].':'.$temp.'">'.
 		        $optionlist."</select>\n";
 	    } elsif ($env{'form.pdfFormFields'} eq 'yes') {
                 #do nothing
             } else {
 		$optionlist=' '.$temp.' '.$optionlist.' ';
 	    }
+	    my $text=$Apache::response::foilgroup{$name.'.text'};
 	    if ($target ne 'tex') {
                 $result .= '<div class="LC_rankfoil">';
 		if ($Apache::lonhomework::type ne 'exam') {
-		    $result.=$optionlist.$text."\n";
+		    $result.=$optionlist.$text."</label>\n";
 		} else {
 		    $result.=$text."\n";
 		}




More information about the LON-CAPA-cvs mailing list