[LON-CAPA-cvs] cvs: loncom /interface courseprefs.pm lonconfigsettings.pm

[raeburn]

raeburn		Thu Apr 13 15:21:00 2023 EDT

  Modified files:              
    /loncom/interface	lonconfigsettings.pm courseprefs.pm 
  Log:
  - Bug 6754 
    Order of components in name for secret field when adding new external 
    tool same as used when adding new link protection item (both use 
    lonconfigsettings::ltisecret_js() for validation).
  
  
Index: loncom/interface/lonconfigsettings.pm
diff -u loncom/interface/lonconfigsettings.pm:1.68 loncom/interface/lonconfigsettings.pm:1.69
--- loncom/interface/lonconfigsettings.pm:1.68	Sun Mar 19 16:05:48 2023
+++ loncom/interface/lonconfigsettings.pm	Thu Apr 13 15:21:00 2023
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler to set domain-wide configuration settings
 #
-# $Id: lonconfigsettings.pm,v 1.68 2023/03/19 16:05:48 raeburn Exp $
+# $Id: lonconfigsettings.pm,v 1.69 2023/04/13 15:21:00 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -503,7 +503,7 @@
             &Apache::loncommon::passwd_validation_js($name.'secretinput',$dom,$name,'add');
         if ($numrules) {
             $js .= <<ENDJS
-${name}secretinput = document.display.elements['${name}_add_secret'].value;
+${name}secretinput = document.display.elements['${name}_secret_add'].value;
 if (document.display.elements['${name}_add'].checked) {
     $intargjs
 }
@@ -512,7 +512,7 @@
         }
         $js .= <<ENDJS;
 uncheckLinkProtMakeVis('$name','visible','add');
-document.display.elements['${name}_add_secret'].type = 'password';
+document.display.elements['${name}_secret_add'].type = 'password';
 
 ENDJS
     }
Index: loncom/interface/courseprefs.pm
diff -u loncom/interface/courseprefs.pm:1.118 loncom/interface/courseprefs.pm:1.119
--- loncom/interface/courseprefs.pm:1.118	Sun Mar 19 16:05:48 2023
+++ loncom/interface/courseprefs.pm	Thu Apr 13 15:21:00 2023
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler to set configuration settings for a course
 #
-# $Id: courseprefs.pm,v 1.118 2023/03/19 16:05:48 raeburn Exp $
+# $Id: courseprefs.pm,v 1.119 2023/04/13 15:21:00 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -2011,7 +2011,7 @@
                 if ($env{$keyitem} ne '') {
                     $ltitools{$newid}{'key'} = $env{$keyitem};
                 }
-                my $secretitem = 'form.ltitools_add_secret';
+                my $secretitem = 'form.ltitools_secret_add';
                 $env{$secretitem} =~ s/(`)/'/g;
                 if ($env{$secretitem} ne '') {
                     if ($privnum && $cipher) {
@@ -6679,8 +6679,8 @@
     } else {
         $datatable .= '<span class="LC_nobreak">'.$lt{'key'}.':<input type="text" size="25" name="ltitools_add_key" value="" autocomplete="off"'.$disabled.' /></span> '."\n".
                       (' 'x2).
-                      '<span class="LC_nobreak">'.$lt{'secret'}.':<input type="password" size="20" name="ltitools_add_secret" value="" autocomplete="new-password"'.$disabled.' />'.
-                      '<label><input type="checkbox" name="ltitools_add_visible" id="ltitools_add_visible" onclick="if (this.checked) { this.form.ltitools_add_secret.type='."'text'".' } else { this.form.ltitools_add_secret.type='."'password'".' }"'.$disabled.' />'.&mt('Visible input').'</label></span> '."\n";
+                      '<span class="LC_nobreak">'.$lt{'secret'}.':<input type="password" size="20" name="ltitools_secret_add" value="" autocomplete="new-password"'.$disabled.' />'.
+                      '<label><input type="checkbox" name="ltitools_add_visible" id="ltitools_add_visible" onclick="if (this.checked) { this.form.ltitools_secret_add.type='."'text'".' } else { this.form.ltitools_secret_add.type='."'password'".' }"'.$disabled.' />'.&mt('Visible input').'</label></span> '."\n";
     }
     $datatable .= '<br /><br />'.
                   '</fieldset>'.