[LON-CAPA-cvs] cvs: loncom(version_2_11_X) /interface domainprefs.pm

raeburn raeburn at source.lon-capa.org
Mon Oct 24 00:01:18 EDT 2016


raeburn		Mon Oct 24 04:01:18 2016 EDT

  Modified files:              (Branch: version_2_11_X)
    /loncom/interface	domainprefs.pm 
  Log:
  - For 2.11 
    Include "Support Settings" configuration.
    - Reverse part of 1.160.6.1; backport 1.282.
  
  
-------------- next part --------------
Index: loncom/interface/domainprefs.pm
diff -u loncom/interface/domainprefs.pm:1.160.6.72 loncom/interface/domainprefs.pm:1.160.6.73
--- loncom/interface/domainprefs.pm:1.160.6.72	Sun Sep 18 19:24:14 2016
+++ loncom/interface/domainprefs.pm	Mon Oct 24 04:01:16 2016
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler to set domain-wide configuration settings
 #
-# $Id: domainprefs.pm,v 1.160.6.72 2016/09/18 19:24:14 raeburn Exp $
+# $Id: domainprefs.pm,v 1.160.6.73 2016/10/24 04:01:16 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -213,15 +213,16 @@
                 'quotas','autoenroll','autoupdate','autocreate',
                 'directorysrch','usercreation','usermodification',
                 'contacts','defaults','scantron','coursecategories',
-                'serverstatuses','requestcourses','coursedefaults',
-                'usersessions','loadbalancing','requestauthor',
+                'serverstatuses','requestcourses','helpsettings',
+                'coursedefaults','usersessions','loadbalancing',
+                'requestauthor','selfenrollment','inststatus'],$dom);
                 'selfenrollment','inststatus'],$dom);
     my @prefs_order = ('rolecolors','login','defaults','quotas','autoenroll',
                        'autoupdate','autocreate','directorysrch','contacts',
                        'usercreation','selfcreation','usermodification','scantron',
                        'requestcourses','requestauthor','coursecategories',
-                       'serverstatuses','coursedefaults','selfenrollment',
-                       'usersessions');
+                       'serverstatuses','helpsettings','coursedefaults',
+                       'selfenrollment','usersessions');
     my %existing;
     if (ref($domconfig{'loadbalancing'}) eq 'HASH') {
         %existing = %{$domconfig{'loadbalancing'}};
@@ -413,6 +414,16 @@
                   print => \&print_serverstatuses,
                   modify => \&modify_serverstatuses,
                  },
+        'helpsettings' =>
+                 {text   => 'Support settings',
+                  help   => 'Domain_Configuration_Help_Settings',
+                  header => [{col1 => 'Help Page Settings (logged-in users)',
+                              col2 => 'Value'},
+                             {col1 => 'Helpdesk Roles',
+                              col2 => 'Settings'},],
+                  print  => \&print_helpsettings,
+                  modify => \&modify_helpsettings,
+                 },
         'coursedefaults' => 
                  {text => 'Course/Community defaults',
                   help => 'Domain_Configuration_Course_Defaults',
@@ -621,6 +632,8 @@
         $output = &modify_quotas($r,$dom,$action,$lastactref,%domconfig);
     } elsif ($action eq 'requestauthor') {
         $output = &modify_quotas($r,$dom,$action,$lastactref,%domconfig);
+    } elsif ($action eq 'helpsettings') {
+        $output = &modify_helpsettings($r,$dom,$confname,%domconfig);
     } elsif ($action eq 'coursedefaults') {
         $output = &modify_coursedefaults($dom,$lastactref,%domconfig);
     } elsif ($action eq 'selfenrollment') {
@@ -641,6 +654,22 @@
         $output = &coursecategories_javascript($settings);
     } elsif ($action eq 'defaults') {
         $output = &defaults_javascript($settings); 
+    } elsif ($action eq 'helpsettings') {
+        my (%privs,%levelscurrent);
+        my %full=();
+        my %levels=(
+                     course => {},
+                     domain => {},
+                     system => {},
+                   );
+        my $context = 'domain';
+        my $crstype = 'Course';
+        my $formname = 'display';
+        &Apache::lonuserutils::custom_role_privs(\%privs,\%full,\%levels,\%levelscurrent);
+        my @templateroles = &Apache::lonuserutils::custom_template_roles($context,$crstype);
+        $output =
+            &Apache::lonuserutils::custom_roledefs_js($context,$crstype,$formname,\%full,
+                                                      \@templateroles);
     }
     $output .=
          '<table class="LC_nested_outer">
@@ -676,7 +705,8 @@
         $rowtotal ++;
         if (($action eq 'autoupdate') || ($action eq 'usercreation') || ($action eq 'selfcreation') ||
             ($action eq 'usermodification') || ($action eq 'defaults') || ($action eq 'coursedefaults') ||
-            ($action eq 'selfenrollment') || ($action eq 'usersessions') || ($action eq 'directorysrch')) {
+            ($action eq 'selfenrollment') || ($action eq 'usersessions') || ($action eq 'directorysrch') ||
+            ($action eq 'helpsettings')) {
             $output .= $item->{'print'}->('top',$dom,$settings,\$rowtotal);
         } elsif ($action eq 'coursecategories') {
             $output .= $item->{'print'}->('top',$dom,$item,$settings,\$rowtotal);
@@ -731,7 +761,8 @@
             }
             $rowtotal ++;
         } elsif (($action eq 'usermodification') || ($action eq 'coursedefaults') ||
-                  ($action eq 'defaults') || ($action eq 'directorysrch')) {
+                 ($action eq 'defaults') || ($action eq 'directorysrch') ||
+                 ($action eq 'helpsettings')) {
             $output .= $item->{'print'}->('bottom',$dom,$settings,\$rowtotal);
         } elsif ($action eq 'login') {
             if ($numheaders == 4) {
@@ -894,8 +925,6 @@
             $output .= $item->{'print'}->($dom,$settings,\$rowtotal);
         } elsif ($action eq 'scantron') {
             $output .= &print_scantronformat($r,$dom,$confname,$settings,\$rowtotal);
-        } elsif ($action eq 'helpsettings') {
-            $output .= &print_helpsettings($dom,$confname,$settings,\$rowtotal);
         }
     }
     $output .= '
@@ -2854,18 +2883,92 @@
 }
 
 sub print_helpsettings {
-    my ($dom,$confname,$settings,$rowtotal) = @_;
+    my ($position,$dom,$settings,$rowtotal) = @_;
+    my $confname = $dom.'-domainconfig';
     my ($datatable,$itemcount);
-    $itemcount = 1;
-    my (%choices,%defaultchecked, at toggles);
-    $choices{'submitbugs'} = &mt('Display link to: [_1]?',
-                                 &Apache::loncommon::modal_link('http://bugs.loncapa.org',
-                                 &mt('LON-CAPA bug tracker'),600,500));
-    %defaultchecked = ('submitbugs' => 'on');
-    @toggles = ('submitbugs',);
-
-    ($datatable,$itemcount) = &radiobutton_prefs($settings,\@toggles,\%defaultchecked,
-                                                 \%choices,$itemcount);
+    if ($position eq 'top') {
+        $itemcount = 1;
+        my (%choices,%defaultchecked, at toggles);
+        $choices{'submitbugs'} = &mt('Display link to: [_1]?',
+                                     &Apache::loncommon::modal_link('http://bugs.loncapa.org',
+                                     &mt('LON-CAPA bug tracker'),600,500));
+        %defaultchecked = ('submitbugs' => 'on');
+        @toggles = ('submitbugs');
+        ($datatable,$itemcount) = &radiobutton_prefs($settings,\@toggles,\%defaultchecked,
+                                                     \%choices,$itemcount);
+        $$rowtotal ++;
+    } else {
+        my $css_class;
+        my %existing=&Apache::lonnet::dump('roles',$dom,$confname,'rolesdef_');
+        my %customroles;
+        foreach my $key (keys(%existing)) {
+            if ($key=~/^rolesdef\_(\w+)$/) {
+                my $rolename = $1;
+                my %privs;
+                ($privs{'system'},$privs{'domain'},$privs{'course'}) = split(/\_/,$existing{$key});
+                $customroles{$rolename} = \%privs;
+            }
+        }
+        my $count = 0;
+        my $context = 'domprefs';
+        my $crstype = 'Course';
+        foreach my $role (sort(keys(%customroles))) {
+            my $prefix = 'custhelp'.$count;
+            my %full=();
+            my %levels= (
+                         course => {},
+                         domain => {},
+                         system => {},
+                        );
+            my %levelscurrent=(
+                               course => {},
+                               domain => {},
+                               system => {},
+                              );
+            &Apache::lonuserutils::custom_role_privs($customroles{$role},\%full,\%levels,\%levelscurrent);
+            my @templateroles = &Apache::lonuserutils::custom_template_roles($context,$crstype);
+            $css_class = $itemcount%2?' class="LC_odd_row"':'';
+            $datatable .= '<tr '.$css_class.'><td><label>'.
+                          '<input type="checkbox" name="modifycusthelp" value="'.$count.'" />'.
+                          '<input type="hidden" name="custhelprole'.$count.'" value="'.$role.'" />'.
+                          &mt('Modify').'</label></td>'.
+                          '<td>'.&mt('Existing helpdesk role:').' '.
+                          '<b>'.$role.'</b><br />'.
+                          &Apache::lonuserutils::custom_role_header($context,$crstype,
+                                                                    \@templateroles,$prefix).
+                          &Apache::lonuserutils::custom_role_table($crstype,\%full,\%levels,
+                                                                   \%levelscurrent,$prefix).
+                          '<br /></td>';
+            $count ++;
+            $itemcount ++;
+        }
+        $css_class = $itemcount%2?' class="LC_odd_row"':'';
+        my $newcust = 'custhelp'.$count;
+        my (%privs,%levelscurrent);
+        my %full=();
+        my %levels= (
+                     course => {},
+                     domain => {},
+                     system => {},
+                    );
+        &Apache::lonuserutils::custom_role_privs(\%privs,\%full,\%levels,\%levelscurrent);
+        my @templateroles = &Apache::lonuserutils::custom_template_roles($context,$crstype);
+        $datatable .= '<tr '.$css_class.'><td><span class="LC_nobreak"><label>'.
+                      '<input type="checkbox" name="newcusthelp" value="'.$count.'" />'. &mt('Add').
+                      '</label></span></td>'.
+                      '<td><span class="LC_nobreak">'.
+                      '<b>'.&mt('Name of new helpdesk role:').'</b> '.
+                      '<input type="text" size="20" name="newcusthelpname" value="" />'.
+                      '</span><br />'.
+                      &Apache::lonuserutils::custom_role_header($context,$crstype,
+                                                                \@templateroles,$newcust).
+                      &Apache::lonuserutils::custom_role_table('Course',\%full,\%levels,
+                                                               \%levelscurrent,$newcust).
+                      '<br /><br />'.
+                      '</td></tr>';
+        $count ++;
+        $$rowtotal += $count;
+    }
     return $datatable;
 }
 
@@ -6227,7 +6330,7 @@
                 if ($domservers{$lonhost}) {
                     if (ref($domconfig{'login'}{'headtag'}{$lonhost}) eq 'HASH') {
                         $currheadtagurls{$lonhost} = $domconfig{'login'}{'headtag'}{$lonhost}{'url'};
-                        $currexempt{$lonhost} = $domconfig{'login'}{'headtag'}{$lonhost}{'exempt'}
+                        $currexempt{$lonhost} = $domconfig{'login'}{'headtag'}{$lonhost}{'exempt'};
                     }
                 }
             }
@@ -10430,30 +10533,76 @@
     my %defaultchecked = ('submitbugs' => 'on');
     my @offon = ('off','on');
     my @toggles = ('submitbugs');
+    my %current = ('submitbugs' => '');
     if (ref($domconfig{'helpsettings'}) eq 'HASH') {
-        foreach my $item (@toggles) {
-            if ($defaultchecked{$item} eq 'on') { 
-                if ($domconfig{'helpsettings'}{$item} eq '') {
-                    if ($env{'form.'.$item} eq '0') {
-                        $changes{$item} = 1;
-                    }
-                } elsif ($domconfig{'helpsettings'}{$item} ne $env{'form.'.$item}) {
+        %current = %{$domconfig{'helpsettings'}};
+    }
+    foreach my $item (@toggles) {
+        if ($defaultchecked{$item} eq 'on') { 
+            if ($current{$item} eq '') {
+                if ($env{'form.'.$item} eq '0') {
                     $changes{$item} = 1;
                 }
-            } elsif ($defaultchecked{$item} eq 'off') {
-                if ($domconfig{'helpsettings'}{$item} eq '') {
-                    if ($env{'form.'.$item} eq '1') {
-                        $changes{$item} = 1;
-                    }
-                } elsif ($domconfig{'helpsettings'}{$item} ne $env{'form.'.$item}) {
+            } elsif ($current{$item} ne $env{'form.'.$item}) {
+                $changes{$item} = 1;
+            }
+        } elsif ($defaultchecked{$item} eq 'off') {
+            if ($current{$item} eq '') {
+                if ($env{'form.'.$item} eq '1') {
                     $changes{$item} = 1;
                 }
+            } elsif ($current{$item} ne $env{'form.'.$item}) {
+                $changes{$item} = 1;
+            }
+        }
+        if (($env{'form.'.$item} eq '0') || ($env{'form.'.$item} eq '1')) {
+            $helphash{'helpsettings'}{$item} = $env{'form.'.$item};
+        }
+    }
+
+    my @modify = &Apache::loncommon::get_env_multiple('form.modifycusthelp');
+    my $confname = $dom.'-domainconfig';
+    my %existing=&Apache::lonnet::dump('roles',$dom,$confname,'rolesdef_');
+    if (@modify) {
+        foreach my $num (@modify) {
+            my $rolename = $env{'form.custhelprole'.$num};
+            if ($rolename ne '') {
+                if (exists($existing{'rolesdef_'.$rolename})) {
+                    my $prefix = 'custhelp'.$num;
+                    my %newprivs = &Apache::lonuserutils::custom_role_update($rolename,$prefix);
+                    my %currprivs;
+                    ($currprivs{'s'},$currprivs{'d'},$currprivs{'c'}) =
+                        split(/\_/,$existing{'rolesdef_'.$rolename});
+                    foreach my $level ('c','d','s') {
+                        if ($newprivs{$level} ne $currprivs{$level}) {
+                            $changes{'customrole'}{$rolename} = 1;
+                            my $result = &Apache::lonnet::definerole($rolename,$newprivs{'s'},$newprivs{'d'},
+                                                                     $newprivs{'c'},$confname,$dom);
+                            last;
+                        }
+                    }
+                }
             }
-            if (($env{'form.'.$item} eq '0') || ($env{'form.'.$item} eq '1')) {
-                $helphash{'helpsettings'}{$item} = $env{'form.'.$item};
+        }
+    }
+    if ($env{'form.newcusthelp'} ne '') {
+        my $prefix = 'custhelp'.$env{'form.newcusthelp'};
+        my $rolename = $env{'form.newcusthelpname'};
+        $rolename=~s/[^A-Za-z0-9]//gs;
+        if ($rolename ne '') {
+            unless(exists($existing{'rolesdef_'.$rolename})) {
+                my $errmsg;
+                my $result = &Apache::lonuserutils::store_custom_role($rolename,$prefix,
+                                                                      $confname,$dom);
+                if ($result eq 'ok') {
+                    $changes{'newcustomrole'} = $rolename;
+                } else {
+                    $errmsg = ': '.$result;
+                }
             }
         }
     }
+
     my $putresult;
     if (keys(%changes) > 0) {
         $putresult = &Apache::lonnet::put_dom('configuration',\%helphash,$dom);
@@ -10464,6 +10613,16 @@
                     $resulttext .= '<li>'.&mt('Display link to: [_1] set to "'.$offon[$env{'form.'.$item}].'".',
                                               &Apache::loncommon::modal_link('http://bugs.loncapa.org',
                                               &mt('LON-CAPA bug tracker'),600,500)).'</li>';
+                } elsif ($item eq 'customrole') {
+                    if (ref($changes{'customrole'}) eq 'HASH') {
+                        foreach my $role (sort(keys(%{$changes{'customrole'}}))) {
+                            $resulttext .= '<li>'.&mt('Existing custom role modified: [_1]',
+                                                     $role).'</li>';
+                        }
+                    }
+                } elsif ($item eq 'newcustomrole') {
+                    $resulttext .= '<li>'.&mt('New custom role added: [_1]',
+                                              $changes{'newcustomrole'}).'</li>';
                 }
             }
             $resulttext .= '</ul>';


More information about the LON-CAPA-cvs mailing list