[LON-CAPA-cvs] cvs: loncom /interface lonmsg.pm

[raeburn]

raeburn		Fri Feb 13 01:46:03 2015 EDT

  Modified files:              
    /loncom/interface	lonmsg.pm 
  Log:
  - Coding style: eliminate $_ for readability.
  
  
Index: loncom/interface/lonmsg.pm
diff -u loncom/interface/lonmsg.pm:1.238 loncom/interface/lonmsg.pm:1.239
--- loncom/interface/lonmsg.pm:1.238	Thu Feb 12 21:22:07 2015
+++ loncom/interface/lonmsg.pm	Fri Feb 13 01:46:03 2015
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Routines for messaging
 #
-# $Id: lonmsg.pm,v 1.238 2015/02/12 21:22:07 raeburn Exp $
+# $Id: lonmsg.pm,v 1.239 2015/02/13 01:46:03 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -634,9 +634,9 @@
     my ($domain,$author)=($url=~/^($match_domain)\/($match_username)\//);
     my %errormsgs=&Apache::lonnet::dump('nohist_res_msgs',$domain,$author);
     my $msgs='';
-    foreach (keys(%errormsgs)) {
-	if ($_=~/^\Q$url\E\_\d+$/) {
-	    my %content=&unpackagemsg($errormsgs{$_});
+    foreach my $msg (keys(%errormsgs)) {
+	if ($msg =~ /^\Q$url\E\_\d+$/) {
+	    my %content=&unpackagemsg($errormsgs{$msg});
 	    $msgs.='<p><img src="/adm/lonMisc/bomb.gif" /><b>'.
 		$content{'time'}.'</b>: '.$content{'message'}.
 		'<br /></p>';
@@ -654,9 +654,9 @@
     $url=&Apache::lonnet::declutter($url);
     my ($domain,$author)=($url=~/^($match_domain)\/($match_username)\//);
     my @delmsgs=();
-    foreach (&Apache::lonnet::getkeys('nohist_res_msgs',$domain,$author)) {
-	if ($_=~/^\Q$url\E\_\d+$/) {
-	    push (@delmsgs,$_);
+    foreach my $msg (&Apache::lonnet::getkeys('nohist_res_msgs',$domain,$author)) {
+	if ($msg =~ /^\Q$url\E\_\d+$/) {
+	    push (@delmsgs,$msg);
 	}
     }
     return &Apache::lonnet::del('nohist_res_msgs',\@delmsgs,$domain,$author);
@@ -668,9 +668,9 @@
     $url=&Apache::lonnet::declutter($url);
     my ($domain,$author)=($url=~/^($match_domain)\/($match_username)\//);
     my @delmsgs=();
-    foreach (&Apache::lonnet::getkeys('nohist_res_msgs',$domain,$author)) {
-	if ($_=~/^\Q$url\E/) {
-	    push (@delmsgs,$_);
+    foreach my $msg (&Apache::lonnet::getkeys('nohist_res_msgs',$domain,$author)) {
+	if ($msg =~ /^\Q$url\E/) {
+	    push (@delmsgs,$msg);
 	}
     }
     return &Apache::lonnet::del('nohist_res_msgs',\@delmsgs,$domain,$author);
@@ -681,8 +681,8 @@
 sub all_url_author_res_msg {
     my ($author,$domain)=@_;
     my %returnhash=();
-    foreach (&Apache::lonnet::getkeys('nohist_res_msgs',$domain,$author)) {
-	$_=~/^(.+)\_\d+/;
+    foreach my $msg (&Apache::lonnet::getkeys('nohist_res_msgs',$domain,$author)) {
+	$msg =~ /^(.+)\_\d+/;
 	$returnhash{$1}=1;
     }
     return %returnhash;
@@ -926,8 +926,8 @@
                                        $domain,$user);
     my $msgforward=$userenv{'msgforward'};
     if ($msgforward) {
-        foreach (split(/\,/,$msgforward)) {
-	    my ($forwuser,$forwdomain)=split(/\:/,$_);
+        foreach my $fwd (split(/\,/,$msgforward)) {
+	    my ($forwuser,$forwdomain)=split(/\:/,$fwd);
 	    push(@status,
 	        &user_normal_msg_raw($forwuser,$forwdomain,$subject,$message,
 				     $citation,$baseurl,$attachmenturl,$toperm,