[LON-CAPA-cvs] cvs: loncom /interface lonwhatsnew.pm

[raeburn]

raeburn		Mon Dec 15 17:13:25 2014 EDT

  Modified files:              
    /loncom/interface	lonwhatsnew.pm 
  Log:
  - Coding style: 
   - keys()
   - for readability eliminate use of $_
  
  
Index: loncom/interface/lonwhatsnew.pm
diff -u loncom/interface/lonwhatsnew.pm:1.116 loncom/interface/lonwhatsnew.pm:1.117
--- loncom/interface/lonwhatsnew.pm:1.116	Wed Dec  4 16:26:54 2013
+++ loncom/interface/lonwhatsnew.pm	Mon Dec 15 17:13:25 2014
@@ -1,5 +1,5 @@
 #
-# $Id: lonwhatsnew.pm,v 1.116 2013/12/04 16:26:54 bisitz Exp $
+# $Id: lonwhatsnew.pm,v 1.117 2014/12/15 17:13:25 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -1164,7 +1164,7 @@
     my $thresholdcount = 0;
     my ($tmp) = %thresholdsettings;
     unless ($tmp =~ /^(con_lost|error|no_such_host)/i) {
-        foreach my $item (keys %{$threshold}) { 
+        foreach my $item (keys(%{$threshold})) { 
             if (exists($thresholdsettings{$cid.':threshold_'.$item})) {
                 $$threshold{$item} = 
                              $thresholdsettings{$cid.':threshold_'.$item};
@@ -1179,7 +1179,7 @@
                                               $cdom,$crs,'internal.threshold');
     my ($temp) = %coursesettings;
     unless ($temp =~ /^(con_lost|error|no_such_host)/i) {  
-        foreach my $item (keys %{$threshold}) {
+        foreach my $item (keys(%{$threshold})) {
             unless (exists($thresholdsettings{$cid.':threshold_'.$item})) {
                 if (exists($coursesettings{'internal.threshold_'.$item})) {
                     $$threshold{$item} = 
@@ -1246,9 +1246,13 @@
 sub process_update {
     my ($uname,$udom,$threshold_titles) = @_;
     my $setoutput = '<b>'.&mt('Changes to threshold(s) for problem tracking:').'</b><br/><br />';
-    foreach (keys %env) {
-        next if ($_!~/^form\.(.+)\_setparmval$/);
-        my $name  = $1;
+    foreach my $key (keys(%env)) {
+        my $name;
+        if ($key =~/^form\.(.+)\_setparmval$/) {
+            $name  = $1;
+        } else {
+            next;
+        }
         my $value = $env{'form.'.$name.'_value'};
         if ($name && defined($value) && ($value ne '')) {
             my $put_result = &Apache::lonnet::put('nohist_whatsnew',