[LON-CAPA-cvs] cvs: loncom(version_2_11_X) /interface loncommon.pm

raeburn raeburn at source.lon-capa.org
Sat Aug 31 22:34:29 EDT 2013


raeburn		Sun Sep  1 02:34:29 2013 EDT

  Modified files:              (Branch: version_2_11_X)
    /loncom/interface	loncommon.pm 
  Log:
  - For 2.11
    - Reverting to non-modal window for pop-up (unless browsing from a mobile
      device). Modal windows make it difficult to view documentation while
      simultaneously viewing the interface for which the help is provided.
  
  
Index: loncom/interface/loncommon.pm
diff -u loncom/interface/loncommon.pm:1.1075.2.49 loncom/interface/loncommon.pm:1.1075.2.50
--- loncom/interface/loncommon.pm:1.1075.2.49	Wed Aug 28 14:02:42 2013
+++ loncom/interface/loncommon.pm	Sun Sep  1 02:34:28 2013
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # a pile of common routines
 #
-# $Id: loncommon.pm,v 1.1075.2.49 2013/08/28 14:02:42 raeburn Exp $
+# $Id: loncommon.pm,v 1.1075.2.50 2013/09/01 02:34:28 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -1234,7 +1234,11 @@
     $topic=~s/\W/\_/g;
 
     if (!$stayOnPage) {
-	$link = "javascript:openMyModal('/adm/help/${filename}.hlp',$width,$height,'yes');";
+        if ($env{'browser.mobile'}) {
+	    $link = "javascript:openMyModal('/adm/help/${filename}.hlp',$width,$height,'yes');";
+        } else {
+            $link = "javascript:void(open('/adm/help/${filename}.hlp', 'Help_for_$topic', 'menubar=0,toolbar=1,scrollbars=1,width=$width,height=$height,resizable=yes'))";
+        }
     } elsif ($stayOnPage eq 'popup') {
         $link = "javascript:void(open('/adm/help/${filename}.hlp', 'Help_for_$topic', 'menubar=0,toolbar=1,scrollbars=1,width=$width,height=$height,resizable=yes'))";
     } else {




More information about the LON-CAPA-cvs mailing list