[LON-CAPA-cvs] cvs: loncom /interface/statistics lonstudentassessment.pm

[bisitz]

bisitz		Thu Apr 11 16:23:36 2013 EDT

  Modified files:              
    /loncom/interface/statistics	lonstudentassessment.pm 
  Log:
  XHTML:
  - Escape parameter separators in links
  - selected
  - Removed invalid single quotation mark
  
  
  
Index: loncom/interface/statistics/lonstudentassessment.pm
diff -u loncom/interface/statistics/lonstudentassessment.pm:1.171 loncom/interface/statistics/lonstudentassessment.pm:1.172
--- loncom/interface/statistics/lonstudentassessment.pm:1.171	Sun Dec 16 16:59:34 2012
+++ loncom/interface/statistics/lonstudentassessment.pm	Thu Apr 11 16:23:36 2013
@@ -1,6 +1,6 @@
 # The LearningOnline Network with CAPA
 #
-# $Id: lonstudentassessment.pm,v 1.171 2012/12/16 16:59:34 raeburn Exp $
+# $Id: lonstudentassessment.pm,v 1.172 2013/04/11 16:23:36 bisitz Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -282,7 +282,7 @@
     # Build the 'all students' button
     my $all = '';
     $all .= '<input type="button" value="'.&mt('All Students').'" '.
-            '" onclick="document.Statistics.SelectedStudent.value='.
+            ' onclick="document.Statistics.SelectedStudent.value='.
             "''".';'.'document.Statistics.submit();" />';
     $Str .= $previousbutton.(' 'x5).$all.(' 'x5).$nextbutton;
     return $Str;
@@ -465,7 +465,7 @@
     $Str = qq/<select size="5" name="$elementname">/;
     foreach my $option (@OutputOptions) {
         $Str .= "\n".'    <option value="'.$option->{'value'}.'"';
-        $Str .= " selected " if ($option->{'value'} eq $selected);
+        $Str .= ' selected="selected"' if ($option->{'value'} eq $selected);
         $Str .= ">".&mt($option->{'name'})."<\/option>";
     }
     $Str .= "\n</select>";
@@ -582,7 +582,7 @@
     $Str = qq/<select size="5" name="$elementname">/;
     foreach my $option (@OutputDataOptions) {
         $Str .= "\n".'    <option value="'.$option->{'value'}.'"';
-        $Str .= " selected " if ($option->{'value'} eq $chosen_output->{'value'});
+        $Str .= ' selected="selected"' if ($option->{'value'} eq $chosen_output->{'value'});
         $Str .= ">".&mt($option->{'name'})."<\/option>";
     }
     $Str .= "\n</select>";
@@ -1971,9 +1971,9 @@
                  ($links eq 'all')) {
                 my $link = '/adm/grades'.
                     '?symb='.&escape($resource->shown_symb).
-                        '&student='.$student->{'username'}.
-                            '&userdom='.$student->{'domain'}.
-                                '&command=submission';
+                        '&student='.$student->{'username'}.
+                            '&userdom='.$student->{'domain'}.
+                                '&command=submission';
                 $symbol = &link($symbol, $link);
             }
             $value .= $symbol;
@@ -2129,9 +2129,9 @@
             if ( ($links eq 'yes' && $symbol ne ' ') || ($links eq 'all')) {
                 my $link = '/adm/grades' .
                     '?symb='.&escape($resource->shown_symb).
-                    '&student='.$student->{'username'}.
-                    '&userdom='.$student->{'domain'}.
-                    '&command=submission';
+                    '&student='.$student->{'username'}.
+                    '&userdom='.$student->{'domain'}.
+                    '&command=submission';
                 $symbol = &link($symbol, $link);
             }
             $Str .= $symbol;