[LON-CAPA-cvs] cvs: loncom /auth lonroles.pm

[raeburn]

raeburn		Fri Jan  4 04:03:03 2013 EDT

  Modified files:              
    /loncom/auth	lonroles.pm 
  Log:
  - Eliminate duplicate declaration
  - Eliminate unnecessary lines
  - Actually set $currcrs when checking for courses with new groups.
  
  
Index: loncom/auth/lonroles.pm
diff -u loncom/auth/lonroles.pm:1.280 loncom/auth/lonroles.pm:1.281
--- loncom/auth/lonroles.pm:1.280	Tue Jan  1 03:45:13 2013
+++ loncom/auth/lonroles.pm	Fri Jan  4 04:03:03 2013
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # User Roles Screen
 #
-# $Id: lonroles.pm,v 1.280 2013/01/01 03:45:13 raeburn Exp $
+# $Id: lonroles.pm,v 1.281 2013/01/04 04:03:03 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -611,7 +611,7 @@
                                             }
                                             if (($checkenc) && ($destsymb ne '')) {
                                                 my ($encstate,$unencsymb,$res);
-                                                my $unencsymb = &Apache::lonnet::symbclean($destsymb);
+                                                $unencsymb = &Apache::lonnet::symbclean($destsymb);
                                                 (undef,undef,$res) = &Apache::lonnet::decode_symb($unencsymb);
                                                 &Apache::lonnet::symbverify($unencsymb,$res,\$encstate);
                                                 if ($encstate) {
@@ -2152,7 +2152,6 @@
                     my $status_in_db =
                         &curr_role_status($tstart,$tend,$refresh,$now);
                     my ($rdummy,$rest) = split(/\//,$role,2);
-                    my ($rdummy,$rdomain,$rauthor,$rrole)=split(/\//,$role);
                     my %currpriv;
                     unless (exists($crprivs{$rest})) {
                         my ($rdomain,$rauthor,$rrole)=split(/\//,$rest);
@@ -2406,9 +2405,8 @@
                             }
                             $groupmsg .= '<li><b>'.
                                          $env{'course.'.$cdom.'_'.$cnum.'.description'}.'</b><ul>';
+                            $currcrs = $cdom.'_'.$cnum;
                         }
-                        my ($cdom,$cnum) = split(/\//,$1);
-                        my $group = $2;
                         my $groupdesc;
                         unless (ref($curr_groups{$cdom.'_'.$cnum}) eq 'HASH') {
                             %{$curr_groups{$cdom.'_'.$cnum}} =