[LON-CAPA-cvs] cvs: doc /loncapafiles ntpcheck.piml

[raeburn]

raeburn		Tue Nov  8 07:38:31 2011 EDT

  Modified files:              
    /doc/loncapafiles	ntpcheck.piml 
  Log:
  - Avoid needing to check for specific phrases (in English) to determine if
    ntp is running by using "ps" command to check for ntp process.
  
  
Index: doc/loncapafiles/ntpcheck.piml
diff -u doc/loncapafiles/ntpcheck.piml:1.14 doc/loncapafiles/ntpcheck.piml:1.15
--- doc/loncapafiles/ntpcheck.piml:1.14	Wed Oct 26 11:48:39 2011
+++ doc/loncapafiles/ntpcheck.piml	Tue Nov  8 07:38:31 2011
@@ -3,7 +3,7 @@
 <!-- ntpcheck.piml -->
 <!-- Matthew Hall -->
 
-<!-- $Id: ntpcheck.piml,v 1.14 2011/10/26 11:48:39 goltermann Exp $ -->
+<!-- $Id: ntpcheck.piml,v 1.15 2011/11/08 07:38:31 raeburn Exp $ -->
 
 <!--
 
@@ -38,29 +38,15 @@
 print "Checking to be sure the Network Time Protocol is running properly.\n";
 print "For more information on ntpd please see http://www.ntp.org/\n";
 my $NTPD;
+my $checkcmd = 'ps -ef |grep ntp |grep -v grep';
+my $startntpcmd;
+my $is_running;
 if (('<DIST />' eq 'fedora15') || ('<DIST />' eq 'fedora16')) {
     $NTPD = 'ntpd';
+    $startntpcmd = 'systemctl start ntpd.service';
     if (!-e '/usr/sbin/ntpd') {
         print "ntp is not installed.\n";
         exit;
-    } else {
-        if (open(PIPE,"systemctl status ntpd.service|")) {
-            my @lines = <PIPE>;
-            chomp(@lines);
-            my $is_running;
-            foreach my $line (@lines) {
-                if ($line =~ /Active: active/) {
-                    $is_running = 1;
-                    last; 
-                }
-            }
-            close(PIPE);
-            if (!$is_running) {
-                print "WARNING: ntp is installed but is not currently running.\nPlease verify the configuration of ntp in /etc/ntp.conf and /etc/ntp/step-tickers\nStart ntp by executing\n systemctl start ntpd.service|\n";
-            }
-        } else {
-            print "Could not determine ntp status.\n";
-        }
     }
 } else {
     if (-e "/etc/init.d/ntpd") {
@@ -73,11 +59,20 @@
         print "ntp is not installed.\n";
         exit;
     }
-    my $value = `/etc/init.d/$NTPD status`;
-    if ($value !~ /pid  \d*)/i) {
-        print "WARNING: ntp is installed but is not currently running.\nPlease verify the configuration of ntp in /etc/ntp.conf and /etc/ntp/step-tickers\nStart ntp by executing\n /etc/init.d/$NTPD start\n";
+    $startntpcnd = "/etc/init.d/$NTPD start";
+}
+
+if (open(PIPE,'-|',$checkcmd)) {
+    $is_running = <PIPE>;
+    chomp($is_running);
+    close(PIPE);
+    if (!$is_running) {
+        print "WARNING: ntp is installed but is not currently running.\nPlease verify the configuration of ntp in /etc/ntp.conf and /etc/ntp/step-tickers\nStart ntp by executing\n $startntpcmd\n";
     }
+} else {
+    print "Could not determine ntp status.\n";
 }
+
 # chkconfig barfs to stderr if the target isn't set up right.
 my $checking_bin;
 my $restartchk;