[LON-CAPA-cvs] cvs: loncom /interface loncommon.pm

bisitz bisitz@source.lon-capa.org
Thu, 22 Oct 2009 13:13:12 -0000


bisitz		Thu Oct 22 13:13:12 2009 EDT

  Modified files:              
    /loncom/interface	loncommon.pm 
  Log:
  - Optimized screen ergonomics:
      - Set default vertical text align in data_tables and pick_boxes from middle to top
      - Set default horizontal text align in pick_boxes from right to left
  - Optimized white spaces in HTML source code for data_table rows without additional styles
  
  
Index: loncom/interface/loncommon.pm
diff -u loncom/interface/loncommon.pm:1.899 loncom/interface/loncommon.pm:1.900
--- loncom/interface/loncommon.pm:1.899	Tue Oct 20 08:54:13 2009
+++ loncom/interface/loncommon.pm	Thu Oct 22 13:13:12 2009
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # a pile of common routines
 #
-# $Id: loncommon.pm,v 1.899 2009/10/20 08:54:13 bisitz Exp $
+# $Id: loncommon.pm,v 1.900 2009/10/22 13:13:12 bisitz Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -4993,12 +4993,14 @@
 table.LC_pick_box tr > td.LC_odd_row {
   background-color: $data_table_light;
   padding: 2px;
+  vertical-align: top;
 }
 
 table.LC_data_table tr.LC_even_row > td,
 table.LC_pick_box tr > td.LC_even_row {
   background-color: $data_table_dark;
   padding: 2px;
+  vertical-align: top;
 }
 
 table.LC_data_table tr.LC_data_table_highlight td {
@@ -5305,7 +5307,7 @@
 table.LC_pick_box td.LC_pick_box_title {
   background: $sidebg;
   font-weight: bold;
-  text-align: right;
+  text-align: left;
   vertical-align: top;
   width: 184px;
   padding: 8px;
@@ -6760,14 +6762,14 @@
 	my ($add_class) = @_;
 	$row_count[0]++;
 	my $css_class = ($row_count[0] % 2)?'LC_odd_row':'LC_even_row';
-	$css_class = (join(' ',$css_class,$add_class));
+	$css_class = (join(' ',$css_class,$add_class)) unless ($add_class eq '');
 	return  '<tr class="'.$css_class.'">'."\n";;
     }
     
     sub continue_data_table_row {
 	my ($add_class) = @_;
 	my $css_class = ($row_count[0] % 2)?'LC_odd_row':'LC_even_row';
-	$css_class = (join(' ',$css_class,$add_class));
+	$css_class = (join(' ',$css_class,$add_class)) unless ($add_class eq '');;
 	return  '<tr class="'.$css_class.'">'."\n";;
     }