[LON-CAPA-cvs] cvs: loncom /interface lonmodifycourse.pm

[bisitz]

bisitz		Tue Jun  9 13:26:35 2009 EDT

  Modified files:              
    /loncom/interface	lonmodifycourse.pm 
  Log:
  - Corrected nested HTML tags structure (<form> / <p>)
  - Corrected unbalanced tags (added </p> to menu; removed </p> from kerberos warning)
  - Replaced hardcoded font color by appropriate warning style (kerberos warning)
  - Removed unused color variables
  - Optimized &mt usage
  - Added some line breaks for better code readability
  
  
Index: loncom/interface/lonmodifycourse.pm
diff -u loncom/interface/lonmodifycourse.pm:1.44 loncom/interface/lonmodifycourse.pm:1.45
--- loncom/interface/lonmodifycourse.pm:1.44	Fri May  8 17:22:17 2009
+++ loncom/interface/lonmodifycourse.pm	Tue Jun  9 13:26:35 2009
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # handler for DC-only modifiable course settings
 #
-# $Id: lonmodifycourse.pm,v 1.44 2009/05/08 17:22:17 raeburn Exp $
+# $Id: lonmodifycourse.pm,v 1.45 2009/06/09 13:26:35 bisitz Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -245,7 +245,6 @@
             'back' => "Back to options page",
     );
 
-    my @bgcolors = ('#eeeeee','#cccccc');
     my $cctitle = &Apache::lonnet::plaintext('cc',$type);
     my $dctitle = &Apache::lonnet::plaintext('dc');
     my @modifiable_params = &get_dc_settable();
@@ -271,9 +270,15 @@
     &print_header($r,$cdesc);
     $r->print('
 <h3>'.$lt{'caes'}.$cdesc.'</h3>
-<p>
 <form action="/adm/modifycourse" method="post" name="viewparms">
-'.$lt{'cose'}.'<ul><li>'.&mt('Settings that can be modified by a [_1] using the <a href="/adm/populate">Automated Enrollment Manager</a>.',$cctitle).'</li><li>'.&mt('Settings that may only be modified by a [_1] from this menu.',$dctitle).'</li></ul>
+<p>
+'.$lt{'cose'}.'
+<ul><li>
+'.&mt('Settings that can be modified by a [_1] using the [_2]Automated Enrollment Manager[_3].'
+     ,$cctitle,'<a href="/adm/populate">','</a>').'
+</li><li>
+'.&mt('Settings that may only be modified by a [_1] from this menu.',$dctitle).'
+</li></ul>
 </p><p>
 '.$lt{'cour'}.'
 </p><p>
@@ -282,7 +287,7 @@
 <a href="javascript:changePage(document.viewparms,'."'menu'".')">'.$lt{'back'}.'</a>&nbsp;&nbsp;&nbsp;&nbsp;
 <a href="javascript:changePage(document.viewparms,'."'setparms'".')">'.&mt('Modify [_1]-only settings',$dctitle).'</a>'."\n".
 &hidden_form_elements().
-'</form>');
+'</p></form>');
 }
 
 sub print_setquota {
@@ -410,7 +415,6 @@
             'deus' => "The default authentication method, and default authentication parameter (domain, initial password or argument) are used when automatic enrollment of students in a course requires addition of new user accounts in your domain, and the class list file contains empty entries for the &lt;authtype&gt; and &lt;autharg&gt; properties for the new student. If you choose 'internally authenticated', and leave the initial password field empty, the automated enrollment process will create a randomized password for each new student account that it adds to your LON-CAPA domain.",
             'gobt' => "Save",
     );
-    my @bgcolors = ('#eeeeee','#cccccc');
 
     my @coursepersonnel = &Apache::lonnet::getkeys('nohist_userroles',$cdom,$cnum);
     my @local_ccs = ();
@@ -636,8 +640,13 @@
     }
     if ( $newattr{'authtype'}=~ /^krb/) {
         if ($newattr{'autharg'}  eq '') {
-            $warning = qq(<font color="red" size="+1">).
-	    &mt("As you did not include the default Kerberos domain to be used for authentication in this class, the institutional data used by the automated enrollment process must include the Kerberos domain for each new student").qq(</font></p>);
+            $warning = '<p class="LC_warning">'
+                      .&mt('As you did not include the default Kerberos domain'
+                          .' to be used for authentication in this class, the'
+                          .' institutional data used by the automated'
+                          .' enrollment process must include the Kerberos'
+                          .' domain for each new student.')
+                      .'</p>';
         }
     }