[LON-CAPA-cvs] cvs: loncom /interface loncoursegroups.pm

bisitz bisitz@source.lon-capa.org
Thu, 07 May 2009 16:09:55 -0000


bisitz		Thu May  7 16:09:55 2009 EDT

  Modified files:              
    /loncom/interface	loncoursegroups.pm 
  Log:
  Optimized the design for group settings step 2 (start and end date):
  - Replaced hardcoded table by standard pick_box
  - Removed now unused special styles (done now)
  - Use standard texts for Start and End Dates
  - Replaced "None" by "No end date" to clarify the meaning of the related checkbox
    and to allow proper translation
  
  (work in progress)
  
  
Index: loncom/interface/loncoursegroups.pm
diff -u loncom/interface/loncoursegroups.pm:1.97 loncom/interface/loncoursegroups.pm:1.98
--- loncom/interface/loncoursegroups.pm:1.97	Thu May  7 15:25:37 2009
+++ loncom/interface/loncoursegroups.pm	Thu May  7 16:09:55 2009
@@ -1,6 +1,6 @@
 # The LearningOnline Network with CAPA
 #
-# $Id: loncoursegroups.pm,v 1.97 2009/05/07 15:25:37 bisitz Exp $
+# $Id: loncoursegroups.pm,v 1.98 2009/05/07 16:09:55 bisitz Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -3776,17 +3776,19 @@
                                                       'startdate',$starttime);
     my $endform = &Apache::lonhtmlcommon::date_setter($formname,
                                                       'enddate',$endtime);
-    my $perpetual = 
-	'<span class="LC_nobreak"><label><input type="checkbox" name="no_end_date" />'.
-	&mt('None').'</label></span>';
-    my $table = "<table class=\"LC_descriptive_input\">\n".
-	'<tr><td class="LC_description">'.&mt('Start:').'</td>'.
-        '<td>'.$startform.'</td>'.
-        '<td>&nbsp;</td>'."</tr>\n".
-	'<tr><td class="LC_description">'.&mt('End:').'</td>'.
-        '<td>'.$endform.'</td>'.
-        '<td>'.$perpetual.'</td>'."</tr>\n".
-	"</table>\n";
+    my $perpetual = ' <span class="LC_nobreak"><label>'
+                   .'<input type="checkbox" name="no_end_date" />'
+                   .&mt('No end date')
+                   .'</label></span>';
+    my $table = &Apache::lonhtmlcommon::start_pick_box()
+               .&Apache::lonhtmlcommon::row_title(&mt('Start Date'))
+               .$startform
+               .&Apache::lonhtmlcommon::row_closure()
+               .&Apache::lonhtmlcommon::row_title(&mt('End Date'))
+               .$endform
+               .$perpetual
+               .&Apache::lonhtmlcommon::row_closure(1)
+               .&Apache::lonhtmlcommon::end_pick_box();
     return $table;
 }