[LON-CAPA-cvs] cvs: loncom /interface loncommon.pm lonindexer.pm lonmeta.pm
schulted
schulted@source.lon-capa.org
Tue, 17 Mar 2009 20:07:45 -0000
This is a MIME encoded message
--schulted1237320465
Content-Type: text/plain
schulted Tue Mar 17 20:07:45 2009 EDT
Modified files:
/loncom/interface lonmeta.pm loncommon.pm lonindexer.pm
Log:
Replace deprecated HTML-Attributes with CSS. Optimized tablelayout for ergonomic reasons.
--schulted1237320465
Content-Type: text/plain
Content-Disposition: attachment; filename="schulted-20090317200745.txt"
Index: loncom/interface/lonmeta.pm
diff -u loncom/interface/lonmeta.pm:1.225 loncom/interface/lonmeta.pm:1.226
--- loncom/interface/lonmeta.pm:1.225 Tue Jan 27 15:59:30 2009
+++ loncom/interface/lonmeta.pm Tue Mar 17 20:07:45 2009
@@ -1,7 +1,7 @@
# The LearningOnline Network with CAPA
# Metadata display handler
#
-# $Id: lonmeta.pm,v 1.225 2009/01/27 15:59:30 schafran Exp $
+# $Id: lonmeta.pm,v 1.226 2009/03/17 20:07:45 schulted Exp $
#
# Copyright Michigan State University Board of Trustees
#
@@ -432,7 +432,7 @@
}
# Title
if ($type eq 'title') {
- return '<font size="+1" face="arial">'.$value.'</font>';
+ return $value;
}
# Dates
if (($type eq 'creationdate') ||
@@ -482,7 +482,7 @@
($type eq 'comefrom_list') ||
($type eq 'sequsage_list') ||
($type eq 'dependencies')) {
- return '<font size="-1"><ul>'.join("\n",map {
+ return '<ul class="LC_fontsize_medium">'.join("\n",map {
my $url = &Apache::lonnet::clutter_with_no_wrapper($_);
my $title = &Apache::lonnet::gettitle($url);
if ($title eq '') {
@@ -500,9 +500,9 @@
}
}
$_ = '<li>'.$title.' '.
- &Apache::lonhtmlcommon::crumbs($url,$target,$prefix,$form,'-1',$noformat).
+ &Apache::lonhtmlcommon::crumbs($url,$target,$prefix,$form,'0',$noformat).
'</li>'
- } split(/\s*\,\s*/,$value)).'</ul></font>';
+ } split(/\s*\,\s*/,$value)).'</ul>';
}
# Evaluations
if (($type eq 'clear') ||
@@ -519,7 +519,7 @@
# List of courses
if ($type=~/\_list/) {
my @Courses = split(/\s*\,\s*/,$value);
- my $Str='<font size="-1"><ul>';
+ my $Str='<ul class="LC_fontsize_medium">';
my %descriptions;
foreach my $course (@Courses) {
my %courseinfo =
@@ -538,7 +538,7 @@
$Str .= $descriptions{$course};
}
- return $Str.'</ul></font>';
+ return $Str.'</ul>';
}
# No pretty print found
return $value;
Index: loncom/interface/loncommon.pm
diff -u loncom/interface/loncommon.pm:1.768 loncom/interface/loncommon.pm:1.769
--- loncom/interface/loncommon.pm:1.768 Tue Mar 17 16:11:52 2009
+++ loncom/interface/loncommon.pm Tue Mar 17 20:07:45 2009
@@ -1,7 +1,7 @@
# The LearningOnline Network with CAPA
# a pile of common routines
#
-# $Id: loncommon.pm,v 1.768 2009/03/17 16:11:52 schulted Exp $
+# $Id: loncommon.pm,v 1.769 2009/03/17 20:07:45 schulted Exp $
#
# Copyright Michigan State University Board of Trustees
#
@@ -5911,10 +5911,9 @@
}
table.LC_tableOfContent{
- border-collapse: collapse;
- border-spacing: 0;
+ border:none;
+ border-spacing: 1;
padding: 3px;
- border: 0;
background-color: #FFFFFF;
font-size: 90%;
}
Index: loncom/interface/lonindexer.pm
diff -u loncom/interface/lonindexer.pm:1.189 loncom/interface/lonindexer.pm:1.190
--- loncom/interface/lonindexer.pm:1.189 Thu Feb 26 16:17:30 2009
+++ loncom/interface/lonindexer.pm Tue Mar 17 20:07:45 2009
@@ -1,7 +1,7 @@
# The LearningOnline Network with CAPA
# Directory Indexer
#
-# $Id: lonindexer.pm,v 1.189 2009/02/26 16:17:30 schafran Exp $
+# $Id: lonindexer.pm,v 1.190 2009/03/17 20:07:45 schulted Exp $
#
# Copyright Michigan State University Board of Trustees
#
@@ -178,7 +178,7 @@
# --------------------- define extra fields and buttons in case of special mode
if ($env{'form.catalogmode'} eq 'interactive') {
#SB $extrafield='<td bgcolor="'.$fileclr.'" valign="bottom">'.
- $extrafield='<td valign="bottom">'.
+ $extrafield='<td class="LC_bottom">'.
'<img alt="" src="'.$iconpath.'whitespace1.gif"'.
' class="LC_icon" /></td>';
$colspan=" colspan='2' ";
@@ -189,7 +189,7 @@
}
elsif ($env{'form.catalogmode'} eq 'import') {
#SB $extrafield='<td bgcolor="'.$fileclr.'" valign="bottom">'.
- $extrafield='<td valign="bottom">'.
+ $extrafield='<td class="LC_bottom">'.
'<img alt="" src="'.$iconpath.'whitespace1.gif"'.
' class="LC_icon" /></td>';
$colspan=" colspan='2' ";
@@ -527,13 +527,13 @@
# -------------------------------------------------------- Resource Home Button
my $reshome=$env{'course.'.$env{'request.course.id'}.'.reshome'};
if ($reshome) {
- $r->print("<font size='+2'><a href='");
+ $r->print("<span class=\"LC_fontsize_small\"><a href='");
if ($env{'form.catalogmode'} eq 'import') {
$r->print('javascript:document.forms.fileattr.action="'.&Apache::loncommon::inhibit_menu_check($reshome).'";document.forms.fileattr.submit();');
} else {
$r->print($reshome);
}
- $r->print("'>".&mt('Home').'</a></font>');
+ $r->print("'>".&mt('Home').'</a></span>');
}
$r->print('</form>');
# ------------------------------------------------------ Remember where we were
@@ -549,12 +549,12 @@
#$r->print(&writedebug("Omit:@Omit")) if (@Omit);
#$r->print(&writedebug("Only:@Only")) if (@Only);
$r->print('<br /><br />');
- $r->print(&Apache::loncommon::start_data_table()
+ $r->print(&Apache::loncommon::start_data_table("LC_tableOfContent")
.&Apache::loncommon::start_data_table_header_row());
$r->print("<th $colspan>".&mt('Name')."</th>\n");
$r->print("<th>".&mt('Title')."</th>\n")
if ($hash{'display_attrs_0'} == 1);
- $r->print('<th align="right">'.&mt("Size")." (".&mt("bytes").") ".
+ $r->print('<th class="LC_right">'.&mt("Size")." (".&mt("bytes").") ".
"</th>\n") if ($hash{'display_attrs_1'} == 1);
$r->print("<th>".&mt("Last accessed")."</th>\n")
if ($hash{'display_attrs_2'} == 1);
@@ -846,6 +846,7 @@
my $fnptr = $filecom[3]&$dirptr;
my $msg = &mt('View').' '.$filecom[0].' '.&mt('resources');
$msg = &mt('Close').' '.$filecom[0].' '.&mt('directory') if $diropen eq 'opened';
+ my $nowOpen = ($diropen eq 'opened' ? 1 : 0);
my $tabtag='</td>';
my $i=0;
@@ -877,11 +878,11 @@
$r->print(&Apache::loncommon::inhibit_menu_check('input'));
$r->print ('<input type=hidden name=openuri value="'.
$startdir.'" />'."\n");
- $r->print ('<input type="hidden" name="acts" value="" />'."\n");
- $r->print ('<input src="'.$iconpath.'arrow_up.gif"');
- $r->print (' name="'.$msg.'" type="image" class="LC_indexer_icon" />'.
+ $r->print ('<input type="hidden" name="acts" value="" />'."\n");
+ $r->print ('<a href="#" onClick="document.dirpathUP.submit()"><img src="'.$iconpath.'arrow.up.gif"');
+ $r->print (' name="'.$msg.'" type="image" class="LC_icon" />'.
"\n");
- $r->print(&mt("Up")."</form>$tabtag");
+ $r->print(&mt("Up")."</a></form>$tabtag");
$r->print(&Apache::loncommon::end_data_table_row());
return OK;
}
@@ -904,16 +905,15 @@
my $anchor = $filecom[0];
$anchor =~ s/\W//g;
$r->print ('<a name="'.$anchor.'"></a>');
- $r->print ('<input type="hidden" name="acts" value="" />');
- $r->print ('<input src="'.$iconpath.'folder_pointer_'.
- $diropen.'.gif"');
- $r->print (' name="'.$msg.'" type="image" class="LC_indexer_icon" />'.
+$r->print ('<input type="hidden" name="acts" value="" />');
+ $r->print ('<a href="#" onClick="document.dirpath'.($dnum-1).'.submit()"><img src="'.$iconpath.'arrow.'.($nowOpen ? "open" : "closed" ).'.gif"');
+ $r->print (' name="'.$msg.'" type="image" class="LC_icon" /></a>'.
"\n");
my $quotable_filecom = &Apache::loncommon::escape_single($filecom[0]);
$r->print ('<a href="javascript:gothere(\''.$quotable_filecom.
'\')"><img alt="" src="'.$iconpath.'server.gif"');
- $r->print (' class="LC_icon" /></a>'."\n");
- $r->print (&mt("Domain")." - $listname ");
+ $r->print (' class="LC_icon" />'."\n");
+ $r->print (&mt("Domain")." - $listname </a>");
if (&Apache::lonnet::domain($listname,'description')) {
$r->print("(".&Apache::lonnet::domain($listname,'description').
")");
@@ -931,50 +931,52 @@
$anchor =~ s/\W//g;
#SB $r->print("<tr bgcolor=\"$fileclr\">$extrafield<td valign=$valign>");
$r->print(&Apache::loncommon::start_data_table_row()
- .$extrafield.'<td valign="'.$valign.'">');
+ .$extrafield.'<td class="LC_'.$valign.'">');
&begin_form ($r,$curdir);
$r->print ('<a name="'.$anchor.'"></a><img alt="" src="'.$iconpath.
- 'whitespace1.gif" class="LC_icon" />'."\n");
+ 'whitespace_21.gif" class="LC_icon" />'."\n");
$r->print ('<input type="hidden" name="acts" value="" />');
- $r->print ('<input src="'.$iconpath.'folder_pointer_'.$diropen.
- '.gif"');
- $r->print (' name="'.$msg.'" type="image" class="LC_indexer_icon" />'.
+ $r->print ('<a href="#" onClick="document.dirpath'.($dnum-1).'.submit()">');
+ $r->print ('<img src="'.$iconpath.'arrow.'.($nowOpen ? "open" : "closed" ).
+ '.gif" class="LC_icon"');
+ $r->print (' name="'.$msg.'" type="image" class="LC_indexer_icon" /></a>'.
"\n");
my $quotable_curdir = &Apache::loncommon::escape_single($curdir);
$r->print ('<a href="javascript:gothere(\''.$quotable_curdir
.'\')"><img alt="'.$msg.'" src="'.
- $iconpath.'quill.gif" class="LC_indexer_icon" /></a>');
+ $iconpath.'quill.gif" class="LC_indexer_icon" />');
my $domain=(split(m|/|,$startdir))[2];
my $plainname=&Apache::loncommon::plainname($listname,$domain);
- $r->print ($listname);
- if (defined($plainname) && $plainname) { $r->print(" ($plainname) "); }
- $r->print('</form>'.$tabtag);
+ $r->print ($listname.'</a>');
+
+ if (defined($plainname) && $plainname) { $r->print(" ($plainname) "); }
+ $r->print('</form>'.$tabtag);
$r->print(&Apache::loncommon::end_data_table_row());
- return OK;
+ return OK;
}
# display file
- if (($fnptr == 0 and $filecom[3] ne '') or $absolute) {
- my $title;
- my $filelink = $pathprefix.$filecom[0];
- if ($hash{'display_attrs_0'} == 1) {
- $title = &Apache::lonnet::gettitle($filelink);
- }
- my @file_ext = split (/\./,$listname);
- my $curfext = $file_ext[-1];
- if (@Omit) {
- foreach (@Omit) { return OK if (lc($curfext) eq $_); }
- }
- if (@Only) {
- my $skip = 1;
- foreach (@Only) { $skip = 0 if (lc($curfext) eq $_); }
- return OK if ($skip > 0);
- }
- # Set the icon for the file
- my $iconname = &Apache::loncommon::icon($listname);
+ if (($fnptr == 0 and $filecom[3] ne '') or $absolute) {
+ my $title;
+ my $filelink = $pathprefix.$filecom[0];
+ if ($hash{'display_attrs_0'} == 1) {
+ $title = &Apache::lonnet::gettitle($filelink);
+ }
+ my @file_ext = split (/\./,$listname);
+ my $curfext = $file_ext[-1];
+ if (@Omit) {
+ foreach (@Omit) { return OK if (lc($curfext) eq $_); }
+ }
+ if (@Only) {
+ my $skip = 1;
+ foreach (@Only) { $skip = 0 if (lc($curfext) eq $_); }
+ return OK if ($skip > 0);
+ }
+ # Set the icon for the file
+ my $iconname = &Apache::loncommon::icon($listname);
#SB $r->print("<tr valign='$valign' bgcolor=\"$fileclr\">);
- $r->print(&Apache::loncommon::start_data_table_row()); #SB valign="$valign" ?!?
- $r->print('<td valign="top"><span class="LC_nobreak">');
+ $r->print(&Apache::loncommon::start_data_table_row()); #SB valign="$valign" ?!?
+ $r->print('<td class="LC_middle LC_nobreak">');
if ($env{'form.catalogmode'} eq 'interactive') {
my $quotable_filelink = &Apache::loncommon::escape_single($filelink);
@@ -982,7 +984,7 @@
$quotable_filelink,"')\">");
$r->print("<img alt=\"\" src='",$iconpath,"select.gif' class='LC_icon' /></a>".
"\n");
- $r->print('</span></td><td valign="top"><span class="LC_nobreak">');
+ $r->print('</td><td class="LC_middle"><span class="LC_nobreak">');
} elsif ($env{'form.catalogmode'} eq 'import') {
$r->print("<form name='form$fnum' action=''>\n");
$r->print("<input type='checkbox' name='filelink"."' ".
@@ -992,7 +994,7 @@
$r->print("checked");
}
$r->print(" />\n");
- $r->print('</form></span></td><td valign="top"><span class="LC_nobreak">');
+ $r->print('</form></td><td class="LC_middle"><span class="LC_nobreak">');
$hash{"pre_${fnum}_link"}=$filelink;
$hash{"pre_${fnum}_title"}=$title;
if (!$hash{"pre_${fnum}_title"}) {
@@ -1007,21 +1009,12 @@
$indent--;
}
# General indentation
- if ($indent > 0 and $indent < 14) {
- $r->print("<img alt=\"\" src='",$iconpath,"whitespace",$indent,
- ".gif' class='LC_icon' />\n");
- } elsif ($indent >0) {
- my $ten = int($indent/10.);
- my $rem = $indent%10.0;
my $count = 0;
- while ($count < $ten) {
+ while ($count < $indent) {
$r->print("<img alt=\"\" src=".$iconpath.
- "whitespace10.gif class='LC_icon' />\n");
- $count++;
+ "whitespace_21.gif class='LC_icon' />\n");
+ $count++;
}
- $r->print("<img alt=\"\" src=",$iconpath,"whitespace",$rem,
- ".gif class='LC_icon' />\n") if $rem > 0;
- }
# Sequence open/close icon
if ($filelink=~/\.(page|sequence)$/) {
my $curdir = $startdir.$filecom[0].'/';
@@ -1029,8 +1022,8 @@
$anchor =~ s/\W//g;
$r->print ('<input type="hidden" name="acts" value="" />');
$r->print ('<a name="'.$anchor.'"></a><input src="'.$iconpath.
- 'folder_pointer_'.$diropen.'.gif"');
- $r->print (' name="'.$msg.'" type="image" class="LC_indexer_icon" />'.
+ 'arrow'.($nowOpen ? "open" : "closed" ).'.gif"');
+ $r->print (' name="'.$msg.'" type="image" class="LC_icon" />'.
"\n");
}
# Filetype icons
@@ -1054,13 +1047,13 @@
$r->print('<td> '.($title eq '' ? ' ' : $title).
' </td>'."\n");
}
- $r->print('<td align="right"> ',
+ $r->print('<td class="LC_right"> ',
$filecom[8]," </td>\n")
if $hash{'display_attrs_1'} == 1;
- $r->print('<td> '.
+ $r->print('<td class="LC_nobreak"> '.
(&Apache::lonlocal::locallocaltime($filecom[9]))." </td>\n")
if $hash{'display_attrs_2'} == 1;
- $r->print('<td> '.
+ $r->print('<td class="LC_nobreak"> '.
(&Apache::lonlocal::locallocaltime($filecom[10]))." </td>\n")
if $hash{'display_attrs_3'} == 1;
@@ -1167,36 +1160,31 @@
#SB $r->print("<tr bgcolor=\"$fileclr\">$extrafield<td valign=$valign>");
$r->print(&Apache::loncommon::start_data_table_row()); # SB: bgcolor suggestion: darkgrey ("LC_info_row"?!?)
# $r->print('<tr class="LC_info_row">');
- $r->print($extrafield.'<td valign="'.$valign.'">');
+ $r->print($extrafield.'<td class="LC_middle LC_nobreak">');
&begin_form ($r,$curdir);
my $indentm1 = $indent-1;
- if ($indentm1 < 12 and $indentm1 > 0) {
- $r->print("<img alt=\"\" src=",$iconpath,"whitespace",$indentm1,
- ".gif class='LC_icon' />\n");
- } else {
- my $ten = int($indentm1/10.);
- my $rem = $indentm1%10.0;
- my $count = 0;
- while ($count < $ten) {
- $r->print ("<img alt=\"\" src=",$iconpath
- ,"whitespace10.gif class='LC_icon' />\n");
- $count++;
- }
- $r->print ("<img alt=\"\" src=",$iconpath,"whitespace",$rem,
- ".gif class='LC_icon' />\n") if $rem > 0;
+ my $count = 0;
+ while ($count < $indentm1) {
+ $r->print ("<img alt=\"\" src=",$iconpath
+ ,"whitespace_21.gif class='LC_icon' />\n");
+ $count++;
}
$r->print ('<input type="hidden" name="acts" value="" />');
- $r->print ('<a name="'.$anchor.'"></a><input src="'.$iconpath.
- 'folder_pointer_'.$diropen.'.gif"');
- $r->print (' name="'.$msg.'" type="image" class="LC_indexer_icon" />'.
+ $r->print ('<a name="'.$anchor.'"></a>');
+ $r->print ('<a href="#" onClick="document.dirpath'.($dnum-1).'.submit()"><img src="'.$iconpath.
+ 'arrow.'.($nowOpen ? "open" : "closed" ).'.gif"');
+ $r->print (' name="'.$msg.'" class="LC_icon" /></a>'.
"\n");
my $quotable_curdir = &Apache::loncommon::escape_single($curdir);
- $r->print ('<a href="javascript:gothere(\''
- .$quotable_curdir.'\')">'
- .'<img alt="'.&mt('Open Folder').'"src="'.
- $iconpath.'folder_'.$diropen.'.gif" class="LC_icon" /></a>'.
- "\n");
- $r->print ("$listname</form></td>\n");
+
+ my $location = &Apache::loncommon::lonhttpdurl("/adm/lonIcons");
+ my $icon = "navmap.folder.".($nowOpen ? "open":"closed").'.gif';
+ $r->print ('<a href="javascript:gothere(\''
+ .$quotable_curdir.'\')"">'
+ .'<img alt="'.&mt('Open Folder').'" src="'.
+ $location."/".$icon.'" />'.
+ "\n");
+ $r->print ("$listname</a></form></td>\n");
# Attributes
my $filelink = $startdir.$filecom[0].'/default';
@@ -1205,13 +1193,13 @@
$r->print('<td> '.($title eq '' ? ' ' : $title).
' </td>'."\n");
}
- $r->print('<td align="right"> ',
+ $r->print('<td class="LC_right"> ',
$filecom[8]," </td>\n")
if $hash{'display_attrs_1'} == 1;
- $r->print('<td> '.
+ $r->print('<td class="LC_break"> '.
(&Apache::lonlocal::locallocaltime($filecom[9]))." </td>\n")
if $hash{'display_attrs_2'} == 1;
- $r->print('<td> '.
+ $r->print('<td class="LC_break"> '.
(&Apache::lonlocal::locallocaltime($filecom[10]))." </td>\n")
if $hash{'display_attrs_3'} == 1;
@@ -1311,7 +1299,7 @@
close(FH);
}
}
- $output='<font size="-2">'.$output.'</font>';
+ $output='<span class="LC_fontsize_medium">'.$output.'</span>';
} elsif ($embstyle eq 'img') {
$output='<img alt="'.&mt('Preview').'" src="'.$filelink.'" />';
} elsif ($filelink=~m{^/res/($match_domain)/($match_username)/}) {
--schulted1237320465--