[LON-CAPA-cvs] cvs: loncom /homework response.pm

[raeburn]

raeburn		Tue Dec 23 18:09:36 2008 EDT

  Modified files:              
    /loncom/homework	response.pm 
  Log:
  - Restore pre-1.207 functionality to &mandatory_part_meta().
  - Eliminate previously commented out code (commented out in rev 1.34 - 8/2001)     - moved to POD in 1.207.
  - Eliminate unbalanced 'back' from POD.
  - Remove args from subroutine titles in POD items so perldoc underlines them.
  - Move POD for &mandatory_part_meta() so it precedes subroutine.        
  
  
Index: loncom/homework/response.pm
diff -u loncom/homework/response.pm:1.209 loncom/homework/response.pm:1.210
--- loncom/homework/response.pm:1.209	Sun Dec  7 23:40:57 2008
+++ loncom/homework/response.pm	Tue Dec 23 18:09:36 2008
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # various response type definitons response definition
 #
-# $Id: response.pm,v 1.209 2008/12/07 23:40:57 www Exp $
+# $Id: response.pm,v 1.210 2008/12/23 18:09:36 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -239,40 +239,26 @@
 		      "></stores>\n";
 }
 
-sub mandatory_part_meta {
 =pod
 
-=item meta_part_order
+=item mandatory_part_meta()
 
 Autogenerate metadata for mandatory
-input (from RAT or lonparmset) and 
+input (from RAT or lonparmset) and
 output (to lonspreadsheet)
 of each part
-#
-    return
-   &meta_parameter_write('opendate','date_start','',
-                         'Opening Date').
-   &meta_parameter_write('duedate','date_end','',
-                         'Due Date').
-   &meta_parameter_write('answerdate','date_start','',
-                         'Show Answer Date').
-   &meta_parameter_write('weight','int_zeropos','',
-                         'Available Points').
-   &meta_parameter_write('maxtries','int_pos','',
-                         'Maximum Number of Tries').
-	&meta_package_write('part').
-        &meta_stores_write('solved','string',
-			   'Problem Status').
-        &meta_stores_write('tries','int_zeropos',
-			   'Number of Attempts').
-        &meta_stores_write('awarded','float',
-			   'Partial Credit Factor');
 
 Note: responseid-specific data 'submission' and 'awarddetail'
 not available to spreadsheet -> skip here
 
 =cut
 
+
+sub mandatory_part_meta {
+    return &meta_package_write('part').
+           &meta_stores_write('solved','string','Problem Status').
+           &meta_stores_write('tries','int_zeropos','Number of Attempts').
+           &meta_stores_write('awarded','float','Partial Credit Factor');
 }
 
 sub meta_part_order {
@@ -916,7 +902,7 @@
 
 =pod
 
-=item &getresponse($offset,$resulttype);
+=item &getresponse();
 
 Retreives the current submitted response, helps out in the case of
 scantron mode.
@@ -1020,7 +1006,7 @@
 
 =pod
 
-=item &scored_response($part_id,$response_id);
+=item &scored_response();
 
 Sets the results hash elements
 
@@ -1290,7 +1276,7 @@
 
 =pod
 
-=item setup_prior_tries_hash($func,$data)
+=item setup_prior_tries_hash()
 
   Foreach each past .submission $func is called with 3 arguments
      - the mode to set things up for (currently always 'grade')
@@ -1335,6 +1321,4 @@
  
 =pod
 
-=back
-
 =cut