[LON-CAPA-cvs] cvs: loncom /interface/statistics lonsurveyreports.pm

bisitz bisitz@source.lon-capa.org
Mon, 01 Dec 2008 17:23:40 -0000


bisitz		Mon Dec  1 17:23:40 2008 EDT

  Modified files:              
    /loncom/interface/statistics	lonsurveyreports.pm 
  Log:
  Corrected/optimized radiobutton survey reports (html output):
  - Added missing start and end tags (tr, td)
  - Corrected table closure (normal table needed instead of data_table)
  - Changed headline "Freq" to "Frequency" (already used in all other survey reports)
  - Removed <hr /> (not needed again here)
  
  
Index: loncom/interface/statistics/lonsurveyreports.pm
diff -u loncom/interface/statistics/lonsurveyreports.pm:1.19 loncom/interface/statistics/lonsurveyreports.pm:1.20
--- loncom/interface/statistics/lonsurveyreports.pm:1.19	Thu Oct 30 17:45:25 2008
+++ loncom/interface/statistics/lonsurveyreports.pm	Mon Dec  1 17:23:40 2008
@@ -1,6 +1,6 @@
 # The LearningOnline Network with CAPA
 #
-# $Id: lonsurveyreports.pm,v 1.19 2008/10/30 17:45:25 bisitz Exp $
+# $Id: lonsurveyreports.pm,v 1.20 2008/12/01 17:23:40 bisitz Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -569,15 +569,20 @@
                             sprintf("%.2f",$count/$total*100).'%</td>'.
                         &Apache::loncommon::end_data_table_row().$/;
                 }
-                $Str .= &Apache::loncommon::start_data_table_row().
-                    '<th>'.&mt('Foil Name').'</th>'.
-                    '<th>'.&mt('Text').'</th>'.
-                    '<th>'.&mt('Freq').'</th>'.
-                    '<th>'.&mt('Percent').'</th>'.
-                    &Apache::loncommon::end_data_table_row().$/.
-                    $tmp;
+                $Str.='<tr>'
+                     .'<td colspan="3">'
+                     .&Apache::loncommon::start_data_table()
+                     .&Apache::loncommon::start_data_table_header_row()
+                     .'<th>'.&mt('Foil Name').'</th>'
+                     .'<th>'.&mt('Text').'</th>'
+                     .'<th>'.&mt('Frequency').'</th>'
+                     .'<th>'.&mt('Percent').'</th>'
+                     .&Apache::loncommon::end_data_table_header_row().$/
+                     .$tmp
+                     .&Apache::loncommon::end_data_table()
+                     .'</td></tr>';
             }
-            $Str.= &Apache::loncommon::end_data_table().'<hr />';
+            $Str.= '</table>';
             $r->print($Str);
             $r->rflush();
         }