[LON-CAPA-cvs] cvs: loncom /interface lonmsgdisplay.pm /localize/localize de.pm

bisitz lon-capa-cvs-allow@mail.lon-capa.org
Thu, 23 Oct 2008 10:15:44 -0000


bisitz		Thu Oct 23 10:15:44 2008 EDT

  Modified files:              
    /loncom/interface	lonmsgdisplay.pm 
    /loncom/localize/localize	de.pm 
  Log:
  Optimized Send button texts for internal messages
  - Made translation of button text possible/practical: first concatenate, then translate. Added comments.
  - Replaced "Mail" with "Message": A LON-CAPA internal message is a "Message", not a "Mail". Usage of "Mail" only in external e-mail context recommended.
  - Use only "Send Message", not "Send New Message" - this has more confused than it has helped
  
  
Index: loncom/interface/lonmsgdisplay.pm
diff -u loncom/interface/lonmsgdisplay.pm:1.93 loncom/interface/lonmsgdisplay.pm:1.94
--- loncom/interface/lonmsgdisplay.pm:1.93	Wed Oct  8 14:56:50 2008
+++ loncom/interface/lonmsgdisplay.pm	Thu Oct 23 10:15:37 2008
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Routines for messaging display
 #
-# $Id: lonmsgdisplay.pm,v 1.93 2008/10/08 14:56:50 bisitz Exp $
+# $Id: lonmsgdisplay.pm,v 1.94 2008/10/23 10:15:37 bisitz Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -1239,7 +1239,11 @@
     my $dismsg='';
     my $disbase='';
     my $attachrow;
-    my $func=&mt('Send New');
+    my $func1='Send'; # do not translate here!
+    my %func2=( # do not translate here!
+               'ma'  => 'Message',
+               'msg' => 'Messages',
+              );
     my %lt=&Apache::lonlocal::texthash('us'  => 'Username',
 				       'do'  => 'Domain',
 				       'ad'  => 'Additional Recipients',
@@ -1247,8 +1251,6 @@
                                        'ar'  => 'Allow replies',
 				       'sb'  => 'Subject',
 				       'ca'  => 'Cancel',
-				       'ma'  => 'Mail',
-                                       'msg' => 'Messages',
                                        'gen' => 'Generate messages from a file',
                                        'gmt' => 'General message text',
                                        'tff' => 'The file format for the uploaded portion of the message is',
@@ -1296,7 +1298,7 @@
 	%content=&Apache::lonmsg::unpackagemsg($message{$forwarding},$folder);
 	$dispcrit.='<input type="hidden" name="forwid" value="'.
 	    $forwarding.'" />';
-	$func=&mt('Forward');
+	$func1='Forward'; # do not translate here!
 	
 	$dissub=&mt('Forwarding').': '.$content{'subject'};
 	$dismsg=&mt('Forwarded message from').' '.
@@ -1310,7 +1312,7 @@
 	%content=&Apache::lonmsg::unpackagemsg($message{$replying},$folder);
 	$dispcrit.='<input type="hidden" name="replyid" value="'.
 	    $replying.'" />';
-	$func=&mt('Send Reply to');
+	$func1='Send Reply to'; # do not translate here!
 	
 	$dissub=&mt('Reply').': '.$content{'subject'};       
 	$dismsg='> '.$content{'message'};
@@ -1421,7 +1423,7 @@
                   &mt('Unless you choose otherwise:').'<ul><li>'.
         &mt("The subject in each forwarded message will be <i>'Forwarding:'</i> followed by the original subject.").'</li><li>'.
         &mt("The message itself will begin with a first line: <i>'Forwarded message from'</i> followed by the original sender's name.").'</li></ul></td></tr>');
-        $func=&mt('Forward');
+        $func1='Forward'; # do not translate here!
         $dissub = &mt('Forwarding').': ';
         $subj_size = '10';
         my $extra = '&lt;'.&mt('original subject').'&gt;&nbsp;&nbsp;&nbsp;'.
@@ -1440,7 +1442,7 @@
         foreach my $msg (@to_forward) {
             $r->print('<input type="hidden" name="delmark" value="'.$msg.'" />');
         }
-        $r->print(&submit_button_row($folder,$dismode,$func.' '.$lt{'msg'},
+        $r->print(&submit_button_row($folder,$dismode,&mt($func1.' '.$func2{'msg'}),
                                      \%lt));
     } elsif ($broadcast ne 'upload') {
         $subj_size = '50';
@@ -1462,7 +1464,7 @@
 $dispcrit
 $disbase
 ENDCOMP
-        $r->print(&submit_button_row($folder,$dismode,$func.' '.$lt{'ma'},
+        $r->print(&submit_button_row($folder,$dismode,&mt($func1.' '.$func2{'ma'}),
                                      \%lt));
         $r->print($citation);
         if (exists($env{'form.ref'})) {
Index: loncom/localize/localize/de.pm
diff -u loncom/localize/localize/de.pm:1.151 loncom/localize/localize/de.pm:1.152
--- loncom/localize/localize/de.pm:1.151	Wed Oct 22 17:45:33 2008
+++ loncom/localize/localize/de.pm	Thu Oct 23 10:15:44 2008
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # German Localization Lexicon
 #
-# $Id: de.pm,v 1.151 2008/10/22 17:45:33 bisitz Exp $
+# $Id: de.pm,v 1.152 2008/10/23 10:15:44 bisitz Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -10530,7 +10530,7 @@
 => 'Zurück zur Verzeichnisliste',
 
    'Currently available actions (will open extra window):'
-=> 'Verfügbare Aktionen (öffnet neues Fenster):',
+=> 'Verfügbare Aktionen (öffnen in neuem Fenster):',
 
    'There are no ungelesen messages in this folder.' # !
 => 'In diesem Verzeichnis befinden sich keine ungelesenen Nachrichten.',
@@ -14157,8 +14157,23 @@
    'The message you checked will be forwarded to the recipient(s) you select below.'
 => 'Die Nachricht, die Sie ausgewählt haben, wird an die Empfänger weitergeleitet, die Sie unten auswählen.',
 
-   'Send Reply to'
-=> 'Antworten senden an',
+   'Send Messages'
+=> 'Nachrichten senden',
+
+   'Send Message'
+=> 'Nachricht senden',
+
+   'Send Reply to Messages'
+=> 'Antwort auf Nachrichten absenden',
+
+   'Send Reply to Message'
+=> 'Antwort auf Nachricht absenden',
+
+   'Forward Messages'
+=> 'Nachrichten weiterleiten',
+
+   'Forward Message'
+=> 'Nachricht weiterleiten',
 
    'Save message for re-use'
 => 'Nachricht zur Wiederverwendung speichern',