[LON-CAPA-cvs] cvs: loncom /interface loncommon.pm

[banghart]

banghart		Tue Aug 28 14:32:37 2007 EDT

  Modified files:              
    /loncom/interface	loncommon.pm 
  Log:
  	Bug 5327. Fixes specific problem, but leaves other help issues.
  		Will add those to bug report.
  	Some style changes.
  
  
Index: loncom/interface/loncommon.pm
diff -u loncom/interface/loncommon.pm:1.571 loncom/interface/loncommon.pm:1.572
--- loncom/interface/loncommon.pm:1.571	Tue Aug 28 11:55:49 2007
+++ loncom/interface/loncommon.pm	Tue Aug 28 14:32:36 2007
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # a pile of common routines
 #
-# $Id: loncommon.pm,v 1.571 2007/08/28 15:55:49 raeburn Exp $
+# $Id: loncommon.pm,v 1.572 2007/08/28 18:32:36 banghart Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -721,24 +721,20 @@
 
     my $template = "";
     my $link;
-
+    
     $topic=~s/\W/\_/g;
 
-    if (!$stayOnPage)
-    {
+    if (!$stayOnPage) {
 	$link = "javascript:void(open('/adm/help/${filename}.hlp', 'Help_for_$topic', 'menubar=0,toolbar=1,scrollbars=1,width=$width,height=$height,resizable=yes'))";
-    }
-    else
-    {
+    } else {
 	$link = "/adm/help/${filename}.hlp";
     }
 
     # Add the text
-    if ($text ne "")
-    {
+    if ($text ne "") {
 	$template .= 
-  "<table bgcolor='#3333AA' cellspacing='1' cellpadding='1' border='0'><tr>".
-  "<td bgcolor='#5555FF'><a target=\"_top\" href=\"$link\"><font color='#FFFFFF' size='2'>$text</font></a>";
+            "<table bgcolor='#3333AA' cellspacing='1' cellpadding='1' border='0'><tr>".
+            "<td bgcolor='#5555FF'><a target=\"_top\" href=\"$link\"><font color='#FFFFFF' size='2'>$text</font></a>";
     }
 
     # Add the graphic
@@ -805,14 +801,10 @@
     my ($topic,$component_help,$faq,$bug,$stayOnPage,$width,$height,$text) 
 	= @_;    
     $stayOnPage = 0 if (not defined $stayOnPage);
-    # formerly only used pop-up help (stayOnPage = 0)
+    # only use pop-up help (stayOnPage == 0)
     # if environment.remote is on (using remote control UI)
-    # if ($env{'browser.interface'} eq 'textual' ||
-    #	$env{'environment.remote'} eq 'off' ) {
-    #   $stayOnPage=1;
-    #}
-    # Now making pop-up help the default even with remote control
-    if ($env{'browser.interface'} eq 'textual') {
+    if ($env{'browser.interface'} eq 'textual' ||
+    	$env{'environment.remote'} eq 'off' ) {
         $stayOnPage=1;
     }
     my $output;
@@ -834,15 +826,13 @@
 
 sub top_nav_help {
     my ($text) = @_;
-
     $text = &mt($text);
-
-    my $stayOnPage = 
+    my $stay_on_page = 
 	($env{'browser.interface'}  eq 'textual' ||
 	 $env{'environment.remote'} eq 'off' );
-    my $link=  ($stayOnPage) ? "javascript:helpMenu('display')"
+    my $link = ($stay_on_page) ? "javascript:helpMenu('display')"
 	                     : "javascript:helpMenu('open')";
-    my $banner_link = &update_help_link(undef,undef,undef,undef,$stayOnPage);
+    my $banner_link = &update_help_link(undef,undef,undef,undef,$stay_on_page);
 
     my $title = &mt('Get help');