[LON-CAPA-cvs] cvs: loncom /interface lonhelper.pm

albertel lon-capa-cvs@mail.lon-capa.org
Fri, 05 May 2006 14:35:47 -0000


albertel		Fri May  5 10:35:47 2006 EDT

  Modified files:              
    /loncom/interface	lonhelper.pm 
  Log:
  - xhtml wants onclick
  - style police
  - reorder to be current, then future, then past
  
  
Index: loncom/interface/lonhelper.pm
diff -u loncom/interface/lonhelper.pm:1.139 loncom/interface/lonhelper.pm:1.140
--- loncom/interface/lonhelper.pm:1.139	Fri May  5 06:59:51 2006
+++ loncom/interface/lonhelper.pm	Fri May  5 10:35:44 2006
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # .helper XML handler to implement the LON-CAPA helper
 #
-# $Id: lonhelper.pm,v 1.139 2006/05/05 10:59:51 foxr Exp $
+# $Id: lonhelper.pm,v 1.140 2006/05/05 14:35:44 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -2308,7 +2308,7 @@
     if ($multiselect) {
 	$result .= '<table><tr><td>';
 
-	my $size = scalar(keys %$sections);
+	my $size = scalar(keys(%$sections));
 	$size += 3;		# We have allstudents allpersonel nosection too.
 	if ($size > 5) { 
 	    $size = 5; 
@@ -2323,10 +2323,10 @@
 	    $result .= '<option name="'.$sec.'">'.$sec.'</option>'."\n";
 	}
 	$result .= '</td><td valign="top">';
-	$result .= '<input type="button" name="'.$formprefix.'.select" value="Select" onClick='
+	$result .= '<input type="button" name="'.$formprefix.'.select" value="Select" onclick='
 	    ."'selectSections(\"$formprefix.chosensections\")'".' /></td>';
 	$result .= '<td valign="top"><input type="button" name="'.$formprefix
-	    .'.unselect" value="Unselect"  onClick='.
+	    .'.unselect" value="Unselect"  onclick='.
 	    "'unselectSections(\"$formprefix.chosensections\")' ".' /></td></tr></table>';
     }
 
@@ -2776,19 +2776,18 @@
     #
     if (!$self->{'activeonly'} && ((scalar @$expired_members) > 0)) {
 
-	# Past 
-
-	$result .= $self->render_student_list(\%sections,
-					      $expired_members,
-					      "past",
-					      \%defaultUsers);
-
 	# And future.
 
 	$result .= $self->render_student_list(\%sections,
 					      $future_members,
 					      "future",
 					      \%defaultUsers);
+	# Past 
+
+	$result .= $self->render_student_list(\%sections,
+					      $expired_members,
+					      "past",
+					      \%defaultUsers);
     }