[LON-CAPA-cvs] cvs: loncom /interface lonevaluate.pm

albertel lon-capa-cvs@mail.lon-capa.org
Thu, 02 Mar 2006 21:11:01 -0000


albertel		Thu Mar  2 16:11:01 2006 EDT

  Modified files:              
    /loncom/interface	lonevaluate.pm 
  Log:
  - xhtmlizing
  
  
Index: loncom/interface/lonevaluate.pm
diff -u loncom/interface/lonevaluate.pm:1.17 loncom/interface/lonevaluate.pm:1.18
--- loncom/interface/lonevaluate.pm:1.17	Thu Apr  7 02:56:23 2005
+++ loncom/interface/lonevaluate.pm	Thu Mar  2 16:11:00 2006
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Evaluate
 #
-# $Id: lonevaluate.pm,v 1.17 2005/04/07 06:56:23 albertel Exp $
+# $Id: lonevaluate.pm,v 1.18 2006/03/02 21:11:00 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -89,7 +89,7 @@
 $html
 <head>
 <title>Evaluation submitted</title>
-<script>
+<script type="text/javascript">
     function goback() {
 	if ((window.name=='loncapaclient')) {
             window.location='$showurl';
@@ -106,10 +106,10 @@
        $r->print('Storing feedback: '.
            &Apache::lonnet::put('nohist_resevaldata',\%currenteval,$rdomain,$rauth));
            unless ($already) {
-	       $r->print('<br>Logging first evaluation');
+	       $r->print('<br />Logging first evaluation');
            }
            $r->print(
-            '<script>setTimeout("goback()",2000);</script></body></html>');
+            '<script type="text/javascript">setTimeout("goback()",2000);</script></body></html>');
            return OK;
         } else {
 	    $warning='Please fill out all fields below';
@@ -135,12 +135,12 @@
     }
 # ------------------------------------------------------- Print out eval screen
     my $standardoptions=(<<ENDOPTIONS);
-<option value=0>-</option>
-<option value=1>Strongly Disagree</option>
-<option value=2>Disagree</option>
-<option value=3>Neutral</option>
-<option value=4>Agree</option>
-<option value=5>Strongly Agree</option>
+<option value="0">-</option>
+<option value="1">Strongly Disagree</option>
+<option value="2">Disagree</option>
+<option value="3">Neutral</option>
+<option value="4">Agree</option>
+<option value="5">Strongly Agree</option>
 ENDOPTIONS
     
     my $html=&Apache::lonxml::xmlbegin();
@@ -150,42 +150,42 @@
 <title>The LearningOnline Network with CAPA</title>
 </head>
 $bodytag
-<tt>$title</tt><p>
+<tt>$title</tt><br /><br />
 <h3><font color="red">$warning</font></h3>
 Please rank the following criteria:
-<form method=post name=evaluation>
-<input type=hidden name=submiteval value=true>
-<input type=hidden name=postdata value="$showurl">
+<form method="post" name="evaluation" action="/adm/evaluate">
+<input type="hidden" name="submiteval" value="true" />
+<input type="hidden" name="postdata" value="$showurl" />
 The material appears to be correct
-<br><select name=correct>
+<br /><select name="correct">
 $standardoptions
 </select>
-<hr>
+<hr />
 The material is helpful
-<br><select name=helpful>
+<br /><select name="helpful">
 $standardoptions
 </select>
-<hr>
+<hr />
 The material is covered with sufficient depth
-<br><select name=depth>
+<br /><select name="depth">
 $standardoptions
 </select>
-<hr>
+<hr />
 The material is presented in a clear way
-<br><select name=clear>
+<br /><select name="clear">
 $standardoptions
 </select>
-<hr>
+<hr />
 The resource is technically correct 
 (loads fast enough, does not produce errors, links work, etc) 
-<br><select name=technical>
+<br /><select name="technical">
 $standardoptions
 </select>
-<hr>
+<hr />
 Any comments?
-<br><textarea name=comments cols=40 rows=5>$oldcomments</textarea>
-<script>$dialold</script>
-<br><input type=submit value="Submit Evaluation">
+<br /><textarea name="comments" cols="40" rows="5">$oldcomments</textarea>
+<script type="text/javascript">$dialold</script>
+<br /><input type="submit" value="Submit Evaluation" />
 </form>
 </body>
 </html>