[LON-CAPA-cvs] cvs: loncom /interface lonwhatsnew.pm

[albertel]

albertel		Sat Jul  9 22:31:34 2005 EDT

  Modified files:              
    /loncom/interface	lonwhatsnew.pm 
  Log:
  - err, typo, BUG# 4207, need to not next if !handgradable, need to just skipp the upcoming foreach loop
  
  
  
Index: loncom/interface/lonwhatsnew.pm
diff -u loncom/interface/lonwhatsnew.pm:1.22 loncom/interface/lonwhatsnew.pm:1.23
--- loncom/interface/lonwhatsnew.pm:1.22	Fri Jul  8 06:39:49 2005
+++ loncom/interface/lonwhatsnew.pm	Sat Jul  9 22:31:30 2005
@@ -1,5 +1,5 @@
 #
-# $Id: lonwhatsnew.pm,v 1.22 2005/07/08 10:39:49 www Exp $
+# $Id: lonwhatsnew.pm,v 1.23 2005/07/10 02:31:30 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -264,7 +264,7 @@
         @bombs = sort { &cmp_title($a,$b,\%res_title) } @bombs;
         foreach my $bomb (@bombs) {
             if ($bombnum %2 == 1) {
-                 $rowColor = $rowColor1;
+		$rowColor = $rowColor1;
             } else {
                 $rowColor = $rowColor2;
             }
@@ -567,35 +567,35 @@
 	    foreach my $value (values(%{$handgrade})) {
 		if ($value eq 'yes') { $handgradeable=1; last; }
 	    }
-	    next if (!$handgradeable);
- 
-            foreach my $student (keys(%$classlist)) {
-                my ($uname,$udom) = split(/:/,$student);
-                my %status=&Apache::grades::student_gradeStatus($url,$symb,$udom,$uname,$partlist);
-                my $submitted = 0;
-                my $ungraded = 0;
-                foreach (keys(%status)) {
-                    $submitted = 1 if ($status{$_} ne 'nothing');
-                    $ungraded = 1 if ($status{$_} =~ /^ungraded/);
-                    my ($foo,$partid,$foo1) = split(/\./,$_);
-                    if ($status{'resource.'.$partid.'.submitted_by'} ne '') {
-                        $submitted = 0;
-                    }
-                }
-                next if (!$submitted || !$ungraded);
-                $ctr ++;
-            }
-            if ($ctr) {
-                $$ungraded{$symb}{count} = $ctr;
-                $$ungraded{$symb}{title} = $title;
-                push(@{$tograde}, $symb);
-            }
+	    if ($handgradeable) {
+		foreach my $student (keys(%$classlist)) {
+		    my ($uname,$udom) = split(/:/,$student);
+		    my %status=&Apache::grades::student_gradeStatus($url,$symb,$udom,$uname,$partlist);
+		    my $submitted = 0;
+		    my $ungraded = 0;
+		    foreach (keys(%status)) {
+			$submitted = 1 if ($status{$_} ne 'nothing');
+			$ungraded = 1 if ($status{$_} =~ /^ungraded/);
+			my ($foo,$partid,$foo1) = split(/\./,$_);
+			if ($status{'resource.'.$partid.'.submitted_by'} ne '') {
+			    $submitted = 0;
+			}
+		    }
+		    next if (!$submitted || !$ungraded);
+		    $ctr ++;
+		}
+		if ($ctr) {
+		    $$ungraded{$symb}{count} = $ctr;
+		    $$ungraded{$symb}{title} = $title;
+		    push(@{$tograde}, $symb);
+		}
+	    }
         }
 
 # Check for bombs
         if ($resource->getErrors()) {
             my $errors = $resource->getErrors();
-            $errors =~ s/^,//;
+	    $errors =~ s/^,//;
             my @bombs = split(/,/, $errors);
             my $errorcount = scalar(@bombs);
             my $errorlink = '<a href="/adm/email?display='.