[LON-CAPA-cvs] cvs: loncom /homework imageresponse.pm matchresponse.pm optionresponse.pm radiobuttonresponse.pm rankresponse.pm
albertel
lon-capa-cvs@mail.lon-capa.org
Wed, 22 Jun 2005 12:03:26 -0000
albertel Wed Jun 22 08:03:26 2005 EDT
Modified files:
/loncom/homework imageresponse.pm matchresponse.pm
optionresponse.pm radiobuttonresponse.pm
rankresponse.pm
Log:
- 0 is a valid name for a foil
Index: loncom/homework/imageresponse.pm
diff -u loncom/homework/imageresponse.pm:1.71 loncom/homework/imageresponse.pm:1.72
--- loncom/homework/imageresponse.pm:1.71 Tue Jun 21 17:00:55 2005
+++ loncom/homework/imageresponse.pm Wed Jun 22 08:03:23 2005
@@ -2,7 +2,7 @@
# The LearningOnline Network with CAPA
# image click response style
#
-# $Id: imageresponse.pm,v 1.71 2005/06/21 21:00:55 albertel Exp $
+# $Id: imageresponse.pm,v 1.72 2005/06/22 12:03:23 albertel Exp $
#
# Copyright Michigan State University Board of Trustees
#
@@ -347,7 +347,7 @@
if ($target eq 'web' || $target eq 'grade' || $target eq 'tex' ||
$target eq 'analyze') {
my $name = &Apache::lonxml::get_param('name',$parstack,$safeeval);
- if (!$name) {
+ if ($name eq "") {
&Apache::lonxml::warning("Foils without names exist. This can cause problems to malfunction.");
$name=$Apache::lonxml::curdepth;
}
Index: loncom/homework/matchresponse.pm
diff -u loncom/homework/matchresponse.pm:1.54 loncom/homework/matchresponse.pm:1.55
--- loncom/homework/matchresponse.pm:1.54 Tue Jun 21 17:00:55 2005
+++ loncom/homework/matchresponse.pm Wed Jun 22 08:03:23 2005
@@ -1,7 +1,7 @@
# The LearningOnline Network with CAPA
# Full matching style response
#
-# $Id: matchresponse.pm,v 1.54 2005/06/21 21:00:55 albertel Exp $
+# $Id: matchresponse.pm,v 1.55 2005/06/22 12:03:23 albertel Exp $
#
# Copyright Michigan State University Board of Trustees
#
@@ -216,7 +216,7 @@
my $location=&Apache::lonxml::get_param('location',$parstack,
$safeeval);
&Apache::lonxml::debug("Got a name of :$name:");
- if (!$name) { $name=$Apache::lonxml::curdepth; }
+ if ($name eq "") { $name=$Apache::lonxml::curdepth; }
&Apache::lonxml::debug("Using a name of :$name:");
push @{ $Apache::response::itemgroup{'names'} }, $name;
$Apache::response::itemgroup{"$name.text"} = $text;
Index: loncom/homework/optionresponse.pm
diff -u loncom/homework/optionresponse.pm:1.128 loncom/homework/optionresponse.pm:1.129
--- loncom/homework/optionresponse.pm:1.128 Tue Jun 21 17:00:55 2005
+++ loncom/homework/optionresponse.pm Wed Jun 22 08:03:23 2005
@@ -1,7 +1,7 @@
# LearningOnline Network with CAPA
# option list style responses
#
-# $Id: optionresponse.pm,v 1.128 2005/06/21 21:00:55 albertel Exp $
+# $Id: optionresponse.pm,v 1.129 2005/06/22 12:03:23 albertel Exp $
#
# Copyright Michigan State University Board of Trustees
#
@@ -632,7 +632,7 @@
if ($value ne 'unused') {
my $name = &Apache::lonxml::get_param('name',$parstack,$safeeval);
&Apache::lonxml::debug("Got a name of :$name:");
- if (!$name) {
+ if ($name eq "") {
&Apache::lonxml::warning("Foils without names exist. This can cause problems to malfunction.");
$name=$Apache::lonxml::curdepth;
}
Index: loncom/homework/radiobuttonresponse.pm
diff -u loncom/homework/radiobuttonresponse.pm:1.101 loncom/homework/radiobuttonresponse.pm:1.102
--- loncom/homework/radiobuttonresponse.pm:1.101 Tue Jun 21 17:00:55 2005
+++ loncom/homework/radiobuttonresponse.pm Wed Jun 22 08:03:23 2005
@@ -1,7 +1,7 @@
# The LearningOnline Network with CAPA
# mutliple choice style responses
#
-# $Id: radiobuttonresponse.pm,v 1.101 2005/06/21 21:00:55 albertel Exp $
+# $Id: radiobuttonresponse.pm,v 1.102 2005/06/22 12:03:23 albertel Exp $
#
# Copyright Michigan State University Board of Trustees
#
@@ -607,7 +607,7 @@
my $value = &Apache::lonxml::get_param('value',$parstack,$safeeval);
if ($value ne 'unused') {
my $name = &Apache::lonxml::get_param('name',$parstack,$safeeval);
- if (!$name) {
+ if ($name eq "") {
&Apache::lonxml::warning("Foils without names exist. This can cause problems to malfunction.");
$name=$Apache::lonxml::curdepth;
}
Index: loncom/homework/rankresponse.pm
diff -u loncom/homework/rankresponse.pm:1.47 loncom/homework/rankresponse.pm:1.48
--- loncom/homework/rankresponse.pm:1.47 Tue Jun 21 17:00:55 2005
+++ loncom/homework/rankresponse.pm Wed Jun 22 08:03:23 2005
@@ -1,7 +1,7 @@
# The LearningOnline Network with CAPA
# rank style response
#
-# $Id: rankresponse.pm,v 1.47 2005/06/21 21:00:55 albertel Exp $
+# $Id: rankresponse.pm,v 1.48 2005/06/22 12:03:23 albertel Exp $
# Copyright Michigan State University Board of Trustees
#
# This file is part of the LearningOnline Network with CAPA (LON-CAPA).
@@ -428,7 +428,7 @@
if ($value ne 'unused') {
my $name = &Apache::lonxml::get_param('name',$parstack,$safeeval);
&Apache::lonxml::debug("Got a name of :$name:");
- if (!$name) {
+ if ($name eq "") {
&Apache::lonxml::warning("Foils without names exist. This can cause problems to malfunction.");
$name=$Apache::lonxml::curdepth;
}