[LON-CAPA-cvs] cvs: doc /loncapafiles updatequery.piml

www lon-capa-cvs@mail.lon-capa.org
Sat, 21 May 2005 00:40:03 -0000


www		Fri May 20 20:40:03 2005 EDT

  Modified files:              
    /doc/loncapafiles	updatequery.piml 
  Log:
  Trying to prevent people from making ugly choices for their domain and
  machine names, like they often do. Fixing that is painful.
  
  Just saving my work, I am unable to understand the logic of this script.
  
  The things I change apparently do not get called.
  
  
Index: doc/loncapafiles/updatequery.piml
diff -u doc/loncapafiles/updatequery.piml:1.36 doc/loncapafiles/updatequery.piml:1.37
--- doc/loncapafiles/updatequery.piml:1.36	Wed Mar 23 13:43:24 2005
+++ doc/loncapafiles/updatequery.piml	Fri May 20 20:40:01 2005
@@ -1,6 +1,6 @@
 <!-- updatequery.piml -->
 
-<!-- $Id: updatequery.piml,v 1.36 2005/03/23 18:43:24 albertel Exp $ -->
+<!-- $Id: updatequery.piml,v 1.37 2005/05/21 00:40:01 www Exp $ -->
 
 <!--
 
@@ -206,7 +206,17 @@
 
 **** Domain ****
 [this does NOT need to correspond to internet address domains,
- examples might be "msu" or "bionet" or "vermontcc"]
+ good examples might be "msu" or "bionet" or "vermontcc",
+ bad examples are "physics" (too general)
+   or "michiganstateuniversity" (too long)
+   or "msuedu" (internet domain, just make it "msu")
+   or "msuphysics" (only if there is a good reason to limit)
+   or "mydomain" (what is that?)
+ Please make this name short AND descriptive of your organization.
+ Note that the domain is very hard to change later.
+ Double-check with the LON-CAPA group at MSU if this domain is 
+ going to be part of the main production cluster, since it needs
+ to be unique.]
 END
 
 # get domain name
@@ -231,6 +241,9 @@
   foreach my $bad (@bad_domain_names) {
     $bad_domain_flag=1 if $choice eq $bad;
   }
+  if ($choice=~/capa/i) {
+     $bad_domain_flag=1;
+  }
   if ($ipdomain and $choice=~/^\s*$/) {
     $choice=$ipdomain;
     open(OUT,'&gt;&gt;/tmp/loncapa_updatequery.out');
@@ -238,20 +251,21 @@
     close(OUT);
     $lonDefDomain=$choice;
     $flag=1;
-  }
-  elsif ($choice!~/\_/ and $choice=~/^\w+$/) {
+  } elsif (length($choice)>12) {
+    print "Name too long\n";
+  } elsif (length($choice)<2) {
+    print "Name too short\n";
+  } elsif ($choice!~/\_/ and $choice=~/^\w+$/) {
     open(OUT,'&gt;&gt;/tmp/loncapa_updatequery.out');
     print(OUT 'lonDefDomain'."\t".$choice."\n");
     close(OUT);
     $lonDefDomain=$choice;
     $r='l';
     $flag=1;
-  }
-  elsif ($bad_domain_flag) {
+  } elsif ($bad_domain_flag) {
     print "Invalid input ('$choice' conflicts with LON-CAPA namespace).\n";
     print "Please try something different than '$choice'\n";
-  }
-  else {
+  } else {
     print "Invalid input (only alphanumeric characters supported).\n";
   }
 }
@@ -296,8 +310,9 @@
 [this does NOT need to correspond to internet address names;
  this name MUST be unique to the whole LON-CAPA network;
  we recommend that you use a name based off of your institution;
- good examples: "msul1" or "bionetl1";
- bad examples: "loncapabox" or "studentsinside"]
+ good examples: "msul1" or "bioneta2";
+ bad examples: "loncapabox" or "studentsinside".
+ Note that machine names are very hard to change later.]
 END
 # get machine name
 # accept if valid, if not valid, tell user and repeat
@@ -315,22 +330,26 @@
 }
   my $choice=&lt;&gt;;
   chomp($choice);
-  if ($lonHostID and $choice=~/^\s*$/) {
+  if ($choice=~/capa/i) {
+    print "Invalid input (names containing 'capa' are reserved).\n";
+  } elsif ($lonHostID and $choice=~/^\s*$/) {
     $choice=$lonHostID;
     open(OUT,'&gt;&gt;/tmp/loncapa_updatequery.out');
     print(OUT 'lonHostID'."\t".$choice."\n");
     close(OUT);
     $lonHostID=$choice;
     $flag=1;
-  }
-  elsif ($choice!~/\_/ and $choice=~/^\w+$/) {
+  } elsif (length($choice)>15) {
+    print "Name too long\n";
+  } elsif (length($choice)<4) {
+    print "Name too short\n";
+  } elsif ($choice!~/\_/ and $choice=~/^\w+$/) {
     open(OUT,'&gt;&gt;/tmp/loncapa_updatequery.out');
     print(OUT 'lonHostID'."\t".$choice."\n");
     close(OUT);
     $lonHostID=$choice;
     $flag=1;
-  }
-  else {
+  } else {
     print "Invalid input (only alphanumeric characters supported).\n";
   }
 }