[LON-CAPA-cvs] cvs: loncom /interface/statistics lonproblemanalysis.pm

[matthew]

matthew		Fri Mar 11 16:14:41 2005 EDT

  Modified files:              
    /loncom/interface/statistics	lonproblemanalysis.pm 
  Log:
  Removed debugging spew.
  OR analysis: Set $correct to 0 if it's undefined so we output '0' instead
  of ''.
  
  
Index: loncom/interface/statistics/lonproblemanalysis.pm
diff -u loncom/interface/statistics/lonproblemanalysis.pm:1.116 loncom/interface/statistics/lonproblemanalysis.pm:1.117
--- loncom/interface/statistics/lonproblemanalysis.pm:1.116	Mon Feb 28 18:07:32 2005
+++ loncom/interface/statistics/lonproblemanalysis.pm	Fri Mar 11 16:14:41 2005
@@ -1,6 +1,6 @@
 # The LearningOnline Network with CAPA
 #
-# $Id: lonproblemanalysis.pm,v 1.116 2005/02/28 23:07:32 matthew Exp $
+# $Id: lonproblemanalysis.pm,v 1.117 2005/03/11 21:14:41 matthew Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -1170,7 +1170,6 @@
     my ($r,$problem,$problem_data,$Students) = @_;
     my ($resource,$respid) = ($problem->{'resource'},
                               $problem->{'respid'});
-    &Apache::lonnet::logthis('option response analysis on '.$resource->symb);
     # Note: part data is not needed.
     my $PerformanceData = &Apache::loncoursedata::get_response_data
         (\@Apache::lonstatistics::SelectedSections,
@@ -1216,7 +1215,6 @@
     if (! defined($Concepts)) {
         $Concepts = [];
     }
-    &Apache::lonnet::logthis('got '.scalar(@$PerformanceData).' data points');
     my %response_data = &OR_analyze_by_tries($r,$PerformanceData,
                                                      $mintries,$maxtries);
     my $analysis = '';
@@ -1273,7 +1271,6 @@
     if (defined($Concepts)) { $num_concepts = scalar(@$Concepts); }
     #
     for (my $try=$mintries;$try<=$maxtries;$try++) {
-        &Apache::lonnet::logthis('try = '.$try);
         if (! defined($response_data{'_total'}->[$try]) ||
             $response_data{'_total'}->[$try] == 0) { 
             if ($try > 1) {
@@ -1307,18 +1304,16 @@
                 ('Correct Concepts','Concept Number','Percent Correct',
                  100,$plotcolors,undef,\@concept_plot_data,{xskip=>1});
         }
-        &Apache::lonnet::logthis('got here a_0');
         #
         # Create Foil Plots
         my $data_count = $response_data{'_total'}->[$try];
         my $correct = $response_data{'_correct'}->[$try];
+        if (! defined($correct)) { $correct = 0; }
         my @Datasets;
         foreach my $option ('_correct',@{$ORdata->{'_Options'}}) {
-            &Apache::lonnet::logthis('checking option '.$option);
             next if (! exists($foil_plot[$try]->{$option}));
             push(@Datasets,$foil_plot[$try]->{$option});
         }
-        &Apache::lonnet::logthis('got here a');
         #
         # Put a blank in the data set between concepts
         for (my $set =0;$set<=$#Datasets;$set++) {
@@ -1335,7 +1330,6 @@
         }
         #
         # Set up the labels needed for the bar graph
-        &Apache::lonnet::logthis('got here b');
         my @Labels;
         my $idx = 1;
         foreach my $concept (@{$Concepts}) {
@@ -1351,9 +1345,7 @@
         
         #
         #
-        &Apache::lonnet::logthis('got here c');
         next if (! defined($Datasets[0]));
-        &Apache::lonnet::logthis('got here d');
         for (my $i=0; $i< scalar(@{$Datasets[0]});$i++) {
             $Datasets[0]->[$i]=0;
         }
@@ -1362,7 +1354,6 @@
         my $incorrect_graph = &Apache::loncommon::DrawBarGraph
             ('Incorrect Statements','Statement','% Chosen Incorrectly',
              100,$plotcolors,\@Labels,@Datasets,{xskip=>1});
-        &Apache::lonnet::logthis('incorrect graph = '.$incorrect_graph);
         $analysis_html.= 
             '<tr><td colspan="4" align="center">'.
             '<font size="+1">'.