[LON-CAPA-cvs] cvs: loncom /interface lonspeller.pm

www lon-capa-cvs@mail.lon-capa.org
Thu, 02 Dec 2004 16:40:01 -0000


www		Thu Dec  2 11:40:01 2004 EDT

  Modified files:              
    /loncom/interface	lonspeller.pm 
  Log:
  Bug #3652: Abuse of alert() in spell checker.
  
  
Index: loncom/interface/lonspeller.pm
diff -u loncom/interface/lonspeller.pm:1.7 loncom/interface/lonspeller.pm:1.8
--- loncom/interface/lonspeller.pm:1.7	Thu Jul 29 09:38:31 2004
+++ loncom/interface/lonspeller.pm	Thu Dec  2 11:40:00 2004
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Interface routines for Aspell
 #
-# $Id: lonspeller.pm,v 1.7 2004/07/29 13:38:31 www Exp $
+# $Id: lonspeller.pm,v 1.8 2004/12/02 16:40:00 www Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -65,9 +65,11 @@
 	    my $suggestions=join(' ',$speller->suggest($word));
 	    $suggestions=~s/\'/\\\'/gs;
 	    if (($suggestions) && (!$insidelink)) {
-		$output.='<a href="javascript:alert('."'".
-		    $suggestions."');".
-		    '">';
+		$output.='<a href="javascript:spellwin=window.open('.
+		    &Apache::lonhtmlcommon::javascript_nothing().
+		    ',\'spellwin\',\'height=140,width=280,resizable=yes,scrollbars=yes,location=no,menubar=no,toolbar=no\');'.
+                    'spellwin.'.&Apache::lonhtmlcommon::javascript_docopen.';spellwin.document.writeln(\'<html><body><h3>'.$word.
+                    '</h3>'.$suggestions.'</body></html>\');spellwin.document.close();spellwin.focus()">';
 	    }
 	    $output.='<font color="red">'.$word.'</font>';
 	    if (($suggestions) && (!$insidelink)) { $output.='</a>'; }