[LON-CAPA-cvs] cvs: loncom /interface lonsource.pm
Guy Albertelli II
guy@albertelli.com
Wed, 7 Jul 2004 14:39:58 -0400 (EDT)
Hi Josh,
Getting close.
Some nit picks,
- sub delete_file, seems to instead be a 'delete_and_copy_file'
- don't use "/home/httpd/html", directly, use
$Apache::lonnet::perlvar{'lonDocRoot'} instead. (Some day we hope to be able to move the root dir around.)
my $problem_filename = "/home/httpd/html".$filename;
- sub hander has uncuddled else, please cuddle them.
- both <input type="button" don't have a /> and thus aren't valid xhtml
Otherwise, looks good.
--
guy@albertelli.com LON-CAPA Developer 0-7-4-1-