[LON-CAPA-cvs] cvs: loncom /xml scripttag.pm

albertel lon-capa-cvs@mail.lon-capa.org
Sun, 08 Jun 2003 21:03:19 -0000 

albertel		Sun Jun  8 17:03:19 2003 EDT

  Modified files:              
    /loncom/xml	scripttag.pm 
  Log:
  - I like using encode
  
  
Index: loncom/xml/scripttag.pm
diff -u loncom/xml/scripttag.pm:1.94 loncom/xml/scripttag.pm:1.95
--- loncom/xml/scripttag.pm:1.94	Sat Jun  7 20:51:56 2003
+++ loncom/xml/scripttag.pm	Sun Jun  8 17:03:19 2003
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # <script> definiton
 #
-# $Id: scripttag.pm,v 1.94 2003/06/08 00:51:56 www Exp $
+# $Id: scripttag.pm,v 1.95 2003/06/08 21:03:19 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -282,15 +282,14 @@
   my $result;
   if ($target eq 'web') {
     my $output=&Apache::lonxml::endredirection;
+    $output =~ s/[\n\r]/ /g;
+    $output=&HTML::Entities::encode($output,'<>&"\'');
     my $linktext= &Apache::lonxml::get_param('linktext',$parstack,$safeeval);
     if (!$linktext) { $linktext='<sup>*</sup>'; }
     my $width= &Apache::lonxml::get_param('width',$parstack,$safeeval);
     if (!$width) { $width='500'; }
     my $height= &Apache::lonxml::get_param('height',$parstack,$safeeval);
     if (!$height) { $height='200'; }
-    $output =~ s/[\n\r]/ /g;
-    $output =~ s/\'/\\\&\#39\;/g;
-    $output =~ s/\"/\&quot\;/g;
     $result = "<a href=\"javascript:newWindow=open(\'\',\'new_W\',\'width=$width,height=$height,scrollbars=1\');newWindow.document.open(\'text/html\',\'replace\');newWindow.document.writeln(\'<html><head><title>newwindow</title></head><body bgcolor=&quot;#FFFFFF&quot;> $output </body></html>\');newWindow.document.close();void(0);\">$linktext</a>";
   } elsif ($target eq 'tex') {
       $result = '}';