[LON-CAPA-cvs] cvs: loncom /homework matchresponse.pm

[albertel]

albertel		Thu Mar 20 14:38:42 2003 EDT

  Modified files:              
    /loncom/homework	matchresponse.pm 
  Log:
  - eliminating an unneeded global
  
  
Index: loncom/homework/matchresponse.pm
diff -u loncom/homework/matchresponse.pm:1.11 loncom/homework/matchresponse.pm:1.12
--- loncom/homework/matchresponse.pm:1.11	Thu Mar 20 13:26:34 2003
+++ loncom/homework/matchresponse.pm	Thu Mar 20 14:38:41 2003
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Full matching style response
 #
-# $Id: matchresponse.pm,v 1.11 2003/03/20 18:26:34 sakharuk Exp $
+# $Id: matchresponse.pm,v 1.12 2003/03/20 19:38:41 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -33,8 +33,6 @@
 use Math::Random();
 use Apache::optionresponse;
 
-my @Items = ();
-
 BEGIN {
     &Apache::lonxml::register('Apache::matchresponse',('matchresponse'));
 }
@@ -89,6 +87,7 @@
     my $result;
     %Apache::response::itemgroup=();
     %Apache::matchresponse::itemtable=();
+
     if ($target eq 'edit') {
 	$result=&Apache::edit::tag_start($target,$token);
 	$result.=&Apache::edit::select_arg('Randomize Order:','randomize',
@@ -128,10 +127,9 @@
     foreach my $name (@names) {
 	$letter_name_map{$alphabet[$i]}=$name;
 	$name_letter_map{$name}=$alphabet[$i];
-	$Items[$i] = $alphabet[$i];
 	$i++;
     }
-     $Apache::response::itemgroup{'letter_name_map'}=\%letter_name_map;
+    $Apache::response::itemgroup{'letter_name_map'}=\%letter_name_map;
     $Apache::response::itemgroup{'name_letter_map'}=\%name_letter_map;
     if ($target eq 'web') {
 	my $table='<table>';
@@ -386,7 +384,7 @@
 	my $lastresponse=$Apache::lonhomework::history{"resource.$part.$id.submission"};
 	my %lastresponse=&Apache::lonnet::str2hash($lastresponse);    
 	my @alphabet=('A'..'Z');
-        my @Items_letter = splice @alphabet, 0, $#Items + 1;
+	my @used_letters=sort(keys(%letter_name_map));
 	foreach my $name (@whichfoils) {
 	    my $lastopt=$lastresponse{$name};
 	    my $last_letter=$name_letter_map{$lastopt};
@@ -401,7 +399,7 @@
 		}
 	    }
 	    my $option;
-	    foreach $option (sort(keys(%letter_name_map))) {
+	    foreach $option (@used_letters) {
 		if ($option eq $last_letter) {
 		    if ($target ne 'tex') {$optionlist.="<option selected=\"on\">$option</option>\n";}
 		} else {
@@ -419,12 +417,12 @@
 	    if ($target ne 'tex') {
 		$question.='<br />'.$optionlist.$text."\n";
 		if ($Apache::lonhomework::type eq 'exam') {
-		    $question.=&Apache::optionresponse::webbubbles(\@Items_letter,\@Items);
+		    $question.=&Apache::optionresponse::webbubbles(\@used_letters,\@used_letters);
 		}
 	    } else {		
 		if ($Apache::lonhomework::type eq 'exam') {
 		    $question.=' '.$optionlist.$text."\n";
-		    $question.=&Apache::optionresponse::bubbles(\@Items_letter,\@Items).'\end{enumerate} \vskip -7 mm \strut ';
+		    $question.=&Apache::optionresponse::bubbles(\@used_letters,\@used_letters).'\end{enumerate} \vskip -7 mm \strut ';
 	        } else {
 		    $question.=' \\\\ '.$optionlist.$text."\n";
 		}