[LON-CAPA-cvs] cvs: loncom /homework grades.pm

Guy Albertelli II guy@albertelli.com
Fri, 28 Feb 2003 16:33:01 -0500 (EST)


Hi Hon-Kie,

2 nitpicks:

1)
Rather than doing 
            $parts{$minder.'.'.$title} = join '::',@{$parts};

and then later
        my @parts = split(/::/,$parts{$_});


Why not do
            $parts{$minder.'.'.$title} = $parts;


and later
        my @parts = @{ $parts{$_} };

This way when some creates a problem that has a part with :: in it,
this won't blow up. (Part ids are allowed to have letters,numbers,-,
and : in them.


2) why even save the data, why not do the display inside the map
   iterator?


-- 
guy@albertelli.com  LON-CAPA Developer  0-7-7-4-