[LON-CAPA-cvs] cvs: loncom /homework radiobuttonresponse.pm

[albertel]

albertel		Tue Jan  7 17:13:07 2003 EDT

  Modified files:              
    /loncom/homework	radiobuttonresponse.pm 
  Log:
  - Fixes BUG#1132 not respecting max in radiobutton response.
  
  
Index: loncom/homework/radiobuttonresponse.pm
diff -u loncom/homework/radiobuttonresponse.pm:1.62 loncom/homework/radiobuttonresponse.pm:1.63
--- loncom/homework/radiobuttonresponse.pm:1.62	Mon Dec  2 12:06:08 2002
+++ loncom/homework/radiobuttonresponse.pm	Tue Jan  7 17:13:07 2003
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # mutliple choice style responses
 #
-# $Id: radiobuttonresponse.pm,v 1.62 2002/12/02 17:06:08 albertel Exp $
+# $Id: radiobuttonresponse.pm,v 1.63 2003/01/07 22:13:07 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -278,12 +278,11 @@
     #pick a true statement
     my $whichtrue = int(&Math::Random::random_uniform() * ($#truelist+1));
     &Apache::lonxml::debug("Max is $max, From $#truelist elms, picking $whichtrue");
-    my $numinserted;
     my (@toplist, @bottomlist);
     my $topcount=0;
     # assign everyone to either toplist/bottomlist or whichfalse
     # which false is randomized, toplist bottomlist are in order
-    while ((($numinserted) < $max-1) && ($#falselist > -1)) {
+    while ((($#whichfalse) < $max-2) && ($#falselist > -1)) {
 	&Apache::lonxml::debug("Have $#whichfalse max is $max");
 	my $afalse=int(&Math::Random::random_uniform() * ($#falselist+1));
 	&Apache::lonxml::debug("From $#falselist elms, picking $afalse");