[LON-CAPA-cvs] cvs: loncom /interface londropadd.pm

[matthew]

matthew		Fri Sep 13 11:33:40 2002 EDT

  Modified files:              
    /loncom/interface	londropadd.pm 
  Log:
  Fixes bug 742.  The code used to clear out the settings for certain columns
  if the label for the second column was set.  The offending for loop has been
  removed and comments have been added to confuse and enlighten the unwary.
  
  
Index: loncom/interface/londropadd.pm
diff -u loncom/interface/londropadd.pm:1.48 loncom/interface/londropadd.pm:1.49
--- loncom/interface/londropadd.pm:1.48	Mon Sep  9 16:54:52 2002
+++ loncom/interface/londropadd.pm	Fri Sep 13 11:33:39 2002
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler to drop and add students in courses 
 #
-# $Id: londropadd.pm,v 1.48 2002/09/09 20:54:52 matthew Exp $
+# $Id: londropadd.pm,v 1.49 2002/09/13 15:33:39 matthew Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -308,19 +308,34 @@
     verify_message(vf,founduname,foundpwd,foundname,foundid,foundsec);
 }
 
+//
+// vf = this.form
+// tf = column number
+//
+// values of nw
+//
+// 0 = none
+// 1 = username
+// 2 = names (lastname, firstnames)
+// 3 = fname (firstname)
+// 4 = mname (middlename)
+// 5 = lname (lastname)
+// 6 = gen   (generation)
+// 7 = id
+// 8 = section
+// 9 = ipwd  (password)
+//
 function flip(vf,tf) {
    var nw=eval('vf.f'+tf+'.selectedIndex');
    var i;
+   // make sure no other columns are labeled the same as this one
    for (i=0;i<=vf.nfields.value;i++) {
       if ((i!=tf) && (eval('vf.f'+i+'.selectedIndex')==nw)) {
           eval('vf.f'+i+'.selectedIndex=0;')
       }
    }
-   if (tf==1 && nw!=0) {
-      for (i=2;i<=5;i++) {
-         eval('vf.f'+i+'.selectedIndex=0;')
-      }
-   }
+   // If we set this to 'lastname, firstnames', clear out all the ones
+   // set to 'fname','mname','lname','gen' (3,4,5,6) currently.
    if (nw==2) {
       for (i=0;i<=vf.nfields.value;i++) {
          if ((eval('vf.f'+i+'.selectedIndex')>=3) &&
@@ -329,6 +344,8 @@
          }
       }
    }
+   // If we set this to one of 'fname','mname','lname','gen' (3,4,5,6),
+   // clear out any that are set to 'lastname, firstnames' (2)
    if ((nw>=3) && (nw<=6)) {
       for (i=0;i<=vf.nfields.value;i++) {
          if (eval('vf.f'+i+'.selectedIndex')==2) {
@@ -336,6 +353,8 @@
          }
       }
    }
+   // If we set the password, make the password form below correspond to 
+   // the new value.
    if (nw==9) {
        changed_radio('int',document.studentform);
        set_auth_radio_buttons('int',document.studentform);