[LON-CAPA-cvs] cvs: loncom /interface lonparmset.pm

www lon-capa-cvs@mail.lon-capa.org
Sat, 07 Sep 2002 18:48:27 -0000


www		Sat Sep  7 14:48:27 2002 EDT

  Modified files:              
    /loncom/interface	lonparmset.pm 
  Log:
  User remarked on "goofy" behavior of "set" checkbox. Turns out, he was
  filling in a value, and then clicked on the "set" checkbox. As a result,
  the checkbox was "off" ... why? onchange is triggered only after the field
  lost focus - and it did so, because the user clicked on the "set" box.
  
  OnFocus might be a little wasteful, but less goofy.
  
  
Index: loncom/interface/lonparmset.pm
diff -u loncom/interface/lonparmset.pm:1.68 loncom/interface/lonparmset.pm:1.69
--- loncom/interface/lonparmset.pm:1.68	Sat Sep  7 14:25:42 2002
+++ loncom/interface/lonparmset.pm	Sat Sep  7 14:48:26 2002
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler to set parameters for assessments
 #
-# $Id: lonparmset.pm,v 1.68 2002/09/07 18:25:42 www Exp $
+# $Id: lonparmset.pm,v 1.69 2002/09/07 18:48:26 www Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -1429,7 +1429,7 @@
 	}
 	foreach (sort keys %descriptions) {
             # onchange is javascript to automatically check the 'Set' button.
-            my $onchange = 'onchange="javascript:window.document.forms'.
+            my $onchange = 'onFocus="javascript:window.document.forms'.
                 '[\'envform\'].elements[\''.$_.'_setparmval\']'.
                 '.checked=true;"';
 	    $output.='<tr><td>'.$descriptions{$_}.'</td>'.
@@ -1438,7 +1438,7 @@
                 '<td><input type=checkbox name="'.$_.'_setparmval"></td>'.
                 '</tr>'."\n";
 	}
-        my $onchange = 'onchange="javascript:window.document.forms'.
+        my $onchange = 'onFocus="javascript:window.document.forms'.
             '[\'envform\'].elements[\'newp_setparmval\']'.
             '.checked=true;"';
 	$output.='<tr><td><i>Create New Environment Variable</i><br />'.